[Done v1.5.5] PHP 5.4 warnings: Illegal string offset

Assuming there were no other code change dependencies in play,
I tested the new code in the two github links posted above on a a ZC 1.51 shop:

1. RE: https://github.com/zencart/zencart/commit/274f4857062bd6df6cc73286272cb78fc86946c9

Tested the code changes in twelve files on above github page

After editing the twelve files, added virtual download products to shopping cart, then clicked "Go to Checkout", then observed the following error:

https://domainname/shop/index.php?main_page=checkout_shipping

Error in Firefox: "The page isn't redirecting properly. Firefox has detected that the server is redirecting the request for this address in a way that will never complete. This problem can sometimes be caused by disabling or refusing to accept cookies."

I ensured Firefox was not blocking cookies, and indeed, checking out with download products in the cart worked before updating the twelve files. I observe the same result in IE.

Had no issue checking out with physical products.

2. In regards to the file update for tpl_checkout_shipping_default.php

The github change code for the above file shows "$checked = FALSE;" as a pre-existing line of code.

// set the radio button to be checked if it is the method chosen
$checked = FALSE;

however, this line does not already appear in the zc 1.51 stock file.

And yet github does not show the line of code "$checked = FALSE;" as new
(not displayed in green with a "+" symbol) indicating it should be added.

I went ahead added that code line.

3. Re: https://github.com/zencart/zencart/commit/8f47bc47bdf6c8a189f51d00e26deb80026d2886

Employed the code changes in /includes/functions/sessions.php

Following that, I observed the sessionid (zenid) was no longer appended to the shop URL while navigating through the shop (and user tracking mod logs showed the same).

Observed no related error or warnings in either the server error log or zc logs.

Reverting to the stock sessions.php, zenid was again employed.

My understanding, is that the two github posts, are the changes made to 1.6.0, not the changes that we need to make to 1.5.0, or 1.5.1
I made the changes discussed in the posts here, and that is what worked. I am still running 1.5.0

I made all of the file changes discussed on the first page, and I am now getting this error again:
[04-Dec-2013 15:49:10 America/Denver] PHP Warning: Illegal string offset 'cost' in /home2/redsauto/public_html/includes/classes/order.php on line 355
There are only 3 of these in my cache, when I have had 19 orders since I switched to php 5.4
How do I determine what is setting this error now, being that it is such a low occurrence?

vanhorn_s:

I made all of the file changes discussed on the first page, and I am now getting this error again:
[04-Dec-2013 15:49:10 America/Denver] PHP Warning: Illegal string offset 'cost' in /home2/redsauto/public_html/includes/classes/order.php on line 355
There are only 3 of these in my cache, when I have had 19 orders since I switched to php 5.4
How do I determine what is setting this error now, being that it is such a low occurrence?
Of the 19 orders, were 3 of them using a different shipping method?

lat9 some of my client are still getting lots of error logs to after making all the changes. I'm not sure about the shipping method. Any ideas

countrycharm: Which changes are "all the changes"?

lat9:

countrycharm: Which changes are "all the changes"?

I already stated it here.

http://www.zen-cart.com/showthread.php?202319-PHP-5-4-warnings-Illegal-string-offset&p=1224510#post1224510

lat9:

Of the 19 orders, were 3 of them using a different shipping method?
They have all been USPS

The changes made for Zen Cart v1.5.2 were much more "intense" that those that I proposed in this thread. Please see https://github.com/zencart/zencart/commit/274f4857062bd6df6cc73286272cb78fc86946c9 for the full set of changes made to v1.5.2 surrounding this issue.

What is the impact of this error? Does it prevent the order from being completed, or just have the possibility of incorrect data? (We use flat-rate shipping, so we shouldn't be invoking any special calculations; however, we've had 10 of these errors within the past 2 months.) The fix appears extensive, and I don't want to break my store applying the fix (I'm good at that) if it's not a severe problem.

rayw1679:

What is the impact of this error? Does it prevent the order from being completed, or just have the possibility of incorrect data? (We use flat-rate shipping, so we shouldn't be invoking any special calculations; however, we've had 10 of these errors within the past 2 months.) The fix appears extensive, and I don't want to break my store applying the fix (I'm good at that) if it's not a severe problem.

I haven't done the extensive fix yet, but what I will do, is backup the files first, make the changes, then upload. If there is a problem, I will go right back to my backup files.

I have had this error show up when there was no order, so it could be affecting sales.

Thank you.

lat9:

The changes made for Zen Cart v1.5.2 were much more "intense" that those that I proposed in this thread. Please see https://github.com/zencart/zencart/commit/274f4857062bd6df6cc73286272cb78fc86946c9 for the full set of changes made to v1.5.2 surrounding this issue.

So running Zen Cart v1.5.1, PHP 5.4

I made all of these changes and initially orders were going to a blank page upon confirmation.. I checked the error logs and I got errors about missing columns.. So I removed all the modified the blocks in the /includes/classes/order.php file which referred to these missing columns..

After that no more PHP 5.4 errors..

DrByte:

The following changes are incorporated into the next ZC version to handle the errors reported in this thread:

https://github.com/zencart/zencart/commit/274f4857062bd6df6cc73286272cb78fc86946c9

https://github.com/zencart/zencart/commit/8f47bc47bdf6c8a189f51d00e26deb80026d2886

DrByte

I am trying to get the posted fixes on this thread to work on a 1.5.1 cart with php 5.4. The errors still persist. I was going back over the files I worked on comparing to the posted fixes to see if I made a mistake. Looking at the order.php file and comparing to the github link

https://github.com/zencart/zencart/commit/274f4857062bd6df6cc73286272cb78fc86946c9

and also this thread

http://www.zen-cart.com/showthread.php?210291-PHP-5-4-12-PHP-Warning-Illegal-string-offset-cost

I noticed a difference in line 368 + on github

'shipping_cost' => isset($_SESSION['shipping']['cost']) ? $_SESSION['shipping']['cost'] : 0,

and thread 210291

'shipping_cost' => (isset($_SESSION['shipping']['cost']) ? $_SESSION['shipping']['cost'] : 0), 

which would be correct?

Use the one on github; the one from the thread contains unnecessary parentheses.

lat9:

Use the one on github; the one from the thread contains unnecessary parentheses.

Thanks for that.

I started from the beginning and uploaded just the patched /includes/classes/order.php file. The error message for the order.php file is gone now but was still getting

Warning: Illegal string offset 'id' in /home1/xxx/public_html/includes/modules/order_total/ot_shipping.php on line 41
Warning: Illegal string offset 'id' in /home1/xxx/public_html/includes/classes/shipping.php on line 32

(both of the above are unmodified files)

next I applied the patch to /includes/modules/order_total/ot_shipping.php on line 77

That left me with these latest errors

Warning: Illegal string offset 'id' in /home1/xxx/public_html/includes/modules/order_total/ot_shipping.php on line 41

Warning: Illegal string offset 'id' in /home1/xxx/public_html/includes/modules/order_total/ot_shipping.php on line 77

Warning: Illegal string offset 'id' in /home1/xxx/public_html/includes/classes/shipping.php on line 32

I went ahead with the patches for

/includes/modules/pages/checkout_shipping/header_php.php, starting around line 70:
/includes/modules/pages/checkout_payment/header_php.php (line 36):
/includes/modules/pages/checkout_confirmation/header_php.php (line 43):

didn't help. still getting the latest errors.

Because you didn't include the /includes/classes/order.php in your patches I tried restoring the order.php file to original and that brought back the orders error again. I put the patched file back again and am back to the latest 3 errors.

any ideas?

I just noticed this error today too, does anyone know if this affects whether or not a customer can checkout, I just now noticed it for the first time this morning.

I have this error;
3-Dec-2015 13:04:29 Europe/Zurich] PHP Warning: Illegal string offset 'id' in ....../catalog/includes/modules/payment/paypalwpp.php on line 200.

Showed up 4 times starting at 12,00 and so far the error shown is the last one.

Strange thing is nobody has used Paypal so far today on my site so what is triggering paypalwpp.php?
No Paypal error messages.

I am using v1.5.1 with the classic template

Anybody have an idea could be causing this?

marton_1:

Strange thing is nobody has used Paypal so far today on my site so what is triggering paypalwpp.php?Perhaps they "started" checkout but didn't complete ... hence no evidence of completing purchases yet.
marton_1:

I have this error;
3-Dec-2015 13:04:29 Europe/Zurich] PHP Warning: Illegal string offset 'id' in ....../catalog/includes/modules/payment/paypalwpp.php on line 200.

...

I am using v1.5.1 with the classic template

Anybody have an idea could be causing this?

Yes. ZC v1.5.1 is not compatible with PHP 5.4, and one of the symptoms of that is about 50 things that can trigger "Illegal string offset" errors.
Ref: https://www.zen-cart.com/content.php?48-what-are-the-server-requirements-to-run-zen-cart

You need to upgrade.