Product Listing Sorter Drop-Down [Support Thread]

Does not work in v157 PHP 7.4, I get a deprecated message. I looked in Github but did not see a fix

PHP Deprecated: The each() function is deprecated. This message will be suppressed on further calls in C:\xampp73a\htdocs\Zencart157b\catalog\includes\modules\mytemplate\dynamic_filter.php on line 14.

I tried replacing ```
while(list($key, $value) = each ($_GET))

with

while(list($key) = key ($_GET))
while(list($value) = current ($_GET))

Which exhausted my scanty PHP knowledge and did not fix the problem

...dynamic_filter.php on line 14

This file is not part of product listing sorter.

yeah, the support thread for said module is here:

https://www.zen-cart.com/showthread.php?193289-Dynamic-Filter-Support-Thread/page16

@marton

you can try:

// replace
while(list($key, $value) = each ($_GET))
// with
foreach ($_GET as $key => $value)

best.

torvista:

This file is not part of product listing sorter.

Apologies, I was working on two plugins and got them mixed up :(

Anyway, I have a real question!

Is anybody using this plugin with 157b and PHP7.4?
I ask because I have some display issues in the product listing and want to check if I screwed up when installing.
Everything else works fine.

As a result of your prompting I'm overhauling this for 157 right now. Yes there are issues.
I should complete it over the weekend...

carlwhat:

yeah, the support thread for said module is here:

https://www.zen-cart.com/showthread.php?193289-Dynamic-Filter-Support-Thread/page16

@marton

you can try:

// replace
while(list($key, $value) = each ($_GET))
// with
foreach ($_GET as $key => $value)

> 
> 
> best.

Many thanks for your fix which worked fine and was above and beyond the call of duty :)

Next problem in the correct thread.

Good news but feeling guilty :)

I've updated the Github. Please report issues there.

torvista:

I've updated the Github. Please report issues there.

Your installation instructions say "\includes\functions\extra_functions.php - CORE FILE MODIFICATION to function zen_create_sort_heading".

I assume "extra_functions.php" is a typo and you mean "functions_general.php" which is the only file there?
Thanks for

I assume "extra_functions.php" is a typo and you mean "functions_general.php" which is the only file there?
Correct. Thanks for pointing that out.

How do you resize the dropdown bar?

How do you resize ...
Same as anything on a html page: with css, in this case targeting the id "productListingSorter" of the dropdown.

I've downloaded the zc1.5.7 version of the add-on from GitHub and installed it. If I want a custom sort order to be the default sort order, is the design intent to require the sort order to be entered in the admin? Example: 9a. Or is a code change required? The custom sort order is not a product listing column.
Dave

Yes, enter the default sort order in the admin, even if it does not match any of the column numbers ¡n in the layout, it should get used...

I am having trouble with the built in product listing of "Display Product Listing Default Sort Order" as my preferred sort is price (in my case is 3a). It works fine for non attribute products, but is not working for priced by attribute products. Will this module in any way allow me to sort all products including attribute pricing as default?
I am using 1.5.7 and Westminster template.
Thanks.....

So I installed this module and it did not address the issue I am having. Anyone??
I am trying to sort by Ascending by price which in my case is 3a. However the priced by attributes products are not sorting by price.

Any help would be awesome. I am using 1.5.7 and the site is a temporary one till I get this resolved and I will then finish. My site is most4less.com

Thanks in advance.

chuckrey:

I am having trouble with the built in product listing of "Display Product Listing Default Sort Order" as my preferred sort is price (in my case is 3a). It works fine for non attribute products, but is not working for priced by attribute products. Will this module in any way allow me to sort all products including attribute pricing as default?
I am using 1.5.7 and Westminster template.
Thanks.....

Well Never Mind. I simply went to the Store Manager and Updated the Attribute and Product Price Sorter and all good.

While it is good you have sorted your issue, if you have a problem (something that should work, but doesn't) with your site, installing something else into the mix will never fix it, but just make things more difficult for you to solve and for others to help as you have added more (non-standard) variables in the equation.