If this is your first visit, check our documentation. To post, register or login.
Forums / Bug Reports / [No bug]extra opening in includesmodulespagesadvanced_search_resultheader_php.php

[No bug]extra opening in includesmodulespagesadvanced_search_resultheader_php.php

Locked

Started by design75 on 10 Apr 2013, 9:18 AM · Views: 1,424

Results 1 to 4 of 4
This thread is locked. New replies are disabled.
10 Apr 2013, 9:18 AM
#1
design75 avatar

design75

Totally Zenned

Join Date:
Dec 2009
Location:
Amersfoort, The Netherlands
Posts:
2,862
Plugin Contributions:
5

[No bug]extra opening in includesmodulespagesadvanced_search_resultheader_php.php

In includes\modules\pages\advanced_search_result\header_php.php on line245 there is an opening bracket in the code, but it isn't closed.

$where_str = " WHERE (p.products_status = 1
               AND p.products_id = pd.products_id
               AND pd.language_id = :languagesID
               AND p.products_id = p2c.products_id
               AND p2c.categories_id = c.categories_id ";

It doesn't give any errors, at least not experienced by me, but I found it during troubleshooting some custom code.
This bracket has been there at least since ZC 1.38, but could be on earlier versions to.
My guess is it is not necessary to use the bracket and it could be removed from the code.

10 Apr 2013, 12:40 PM
#2
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [No bug]extra opening in includesmodulespagesadvanced_search_resultheader_php.php

I believe if you look further in the code you will see how the $where_str is still being built and the lines of:

    $where_str .= ")";

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

10 Apr 2013, 2:00 PM
#3
design75 avatar

design75

Totally Zenned

Join Date:
Dec 2009
Location:
Amersfoort, The Netherlands
Posts:
2,862
Plugin Contributions:
5

Re: [No bug]extra opening in includesmodulespagesadvanced_search_resultheader_php.php

:blush:

You're right. Soooo many bracket's. Imust have counted the opening and closing brackets a dozen times and still miss one.

10 Apr 2013, 2:46 PM
#4
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [No bug]extra opening in includesmodulespagesadvanced_search_resultheader_php.php

Not a problem ... that can be a confusing file in there ... :cool:

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!