Forums / Code Collaboration / Working on new Installer for v1.6.0 ...

Working on new Installer for v1.6.0 ...

Started by wilt on 9 May 2013, 3:44 PM · Views: 15,519

Results 21 to 40 of 42
12 May 2013, 6:47 PM
#21
commentics avatar

commentics

New Zenner

Join Date:
Oct 2012
Posts:
7
Plugin Contributions:
1

Working on new Installer for v1.6.0 ...

Minor grammatical change for the 'htaccess support' help window.

This maybe because you are not using Apache as your Web Server ..
This may be because you are not using Apache as your Web Server ..

12 May 2013, 7:39 PM
#22
wilt avatar

wilt

Oji-san

Join Date:
Jun 2003
Location:
Newcastle UK
Posts:
1,934
Plugin Contributions:
3

Re: Working on new Installer for v1.6.0 ...

torvista:

With mysl server off and my pc disconnected from the internet no page detects the absence of the mysql server...it only gets flagged after entering the db details on Database setup page and pressing Continue.

Its a small point but I am thinking brand new user here and a bit of psychology, I know I would want the initial inspection page to tell me that all is not well, but would be irritated on being informed only after filling in form fields...which no doubt would time out before I had fixed the problem.

Some further info on this. The initial page does some checking on the availablity of MySql, however only tries the actual connection if there is an existing configure.php.

If there is no configure.php. then testing the connection becomes problematic, as we don't know any details about the mysql server. We can asssume that host=localhost, but this is not always the case for some hosting providers. Also, to test the connection I would normally have to pass a user/password. Altough I guess I could pass some nulll parameters for that, and just look at what the error was.

Even then, I would have to make the error a non-fatal one, given that I can't assume localhost.

Still thinking on this one.

12 May 2013, 11:16 PM
#23
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,878
Plugin Contributions:
7

Re: Working on new Installer for v1.6.0 ...

Still thinking on this one.

This is the "problem" with sticking your head above the parapet and asking for opinions for once, everyone and his dog will nitpick to death on (non) issues that maybe don't deserve the time spent on them, at the expense of progress. Law of diminishing returns.

Still, I would say its an indication of how (some) people in the forum really just want to contribute when they can (are allowed to) and want to make the product the best it can be. Do it once and right, where possible.

I think the installer has to be particularly comprehensive/friendly/fault-free as its the first and maybe last contact a new user will have. Helps to alleviate the shock of the classic template.

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

13 May 2013, 12:15 PM
#24
wilt avatar

wilt

Oji-san

Join Date:
Jun 2003
Location:
Newcastle UK
Posts:
1,934
Plugin Contributions:
3

Re: Working on new Installer for v1.6.0 ...

torvista:

This is the "problem" with sticking your head above the parapet and asking for opinions for once, everyone and his dog will nitpick to death on (non) issues that maybe don't deserve the time spent on them, at the expense of progress. Law of diminishing returns.

I guess the whole point of moving the devlopment stuff to Github and the forum posts is to 'stick our head over the parapet'

So far there hasn't been too much 'nitpicking to death', and I am appreciative of the feedback so far. Replies here have been useful and welcome.

20 Aug 2013, 4:16 PM
#25
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,878
Plugin Contributions:
7

Re: Working on new Installer for v1.6.0 ...

Just ran the installer (as downloaded today) and it hung at the end of creating database with this log error

PHP Fatal error: Maximum execution time of 30 seconds exceeded in ......\zc160\includes\classes\db\mysql\query_factory.php on line 40

30s is the default setting in php.ini on the current verisons (1.82/1.83) of Xampp.

It completed ok when changed to 60s so maybe a

ini_set('max_execution_time', 60);

is required somewhere in the installer.

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

20 Aug 2013, 5:50 PM
#26
lhungil avatar

lhungil

Totally Zenned

Join Date:
Feb 2012
Location:
mostly harmless
Posts:
1,816
Plugin Contributions:
4

Re: Working on new Installer for v1.6.0 ...

torvista:

Just ran the installer (as downloaded today) and it hung ...
Maybe just call "set_time_limit(30);" inside ajaxGetProgressValues.php to restart the 30 second timeout each time the progress is refreshed? Maybe combined with a "cancel" button during the install / upgrade process? May be a little spammy, but would ensure no timeout as long as the person installing is sitting on a screen with the install processing....

The glass is not half full. The glass is not half empty. The glass is simply too big!
Where are the Zen Cart Debug Logs? Where are the HTTP 500 / Server Error Logs?
Zen Cart related projects maintained by lhûngîl : Plugin / Module Tracker

22 Aug 2013, 12:59 PM
#27
frank18 avatar

frank18

Deceased

Join Date:
Nov 2007
Location:
Sunny Coast, Australia
Posts:
3,427
Plugin Contributions:
2

Re: Working on new Installer for v1.6.0 ...

Just my 5 cents to the new installer:

Had first 'contact' with ZC1.6.0 today. Downloaded using git and followed the commands as outlined by swguy - no problems.

Ran the installer on my local dev server and encountered no problems at all. Just a bit puzzled by the message (not verbatim): '....no .htaccess support, you are either not running Apache...... etc'

I am running a fully fledged LAMP stack on a Linux Mint 15 (alas Ubuntu 13.04) box. That box is hosting several 1.3.9h and 1.5.1 installs - all running w/o .htaccess problems.

Despite the warning about .htaccess ZC 1.6.0 fired up without problems, store side and admin.

Parameters of the dev server:

Server Information
Server Host: Andromeda (127.0.1.1) Database Host: localhost (127.0.0.1)
Server OS: Linux 3.8.0-19-generic Database: MySQL 5.5.32-0ubuntu0.13.04.1
Server Date: 08/22/2013 22:48:14 Database Date: 08/22/2013 22:48:14
Server Up Time: 22:48:14 up 5:35, 1 user, load average: 0.47, 0.34, 0.27 HTTP Server: Apache/2.2.22 (Ubuntu)
PHP Version: 5.4.9-4ubuntu2.2 (Zend: 2.4.0) PHP Memory Limit: 128M PHP Safe Mode: Off
PHP File Uploads: On Max Size: 5M POST Max Size: 8M
Database Data Size: 371 kB Database Index Size: 538 kB

PHP Version 5.4.9-4ubuntu2.2

System Linux Andromeda 3.8.0-19-generic #30-Ubuntu SMP Wed May 1 16:36:13 UTC 2013 i686
Build Date Jul 15 2013 18:03:31
Server API Apache 2.0 Handler
Virtual Directory Support disabled
Configuration File (php.ini) Path /etc/php5/apache2
Loaded Configuration File /etc/php5/apache2/php.ini
Scan this dir for additional .ini files /etc/php5/apache2/conf.d
Additional .ini files parsed /etc/php5/apache2/conf.d/10-pdo.ini, /etc/php5/apache2/conf.d/20-curl.ini, /etc/php5/apache2/conf.d/20-gd.ini, /etc/php5/apache2/conf.d/20-mysql.ini, /etc/php5/apache2/conf.d/20-mysqli.ini, /etc/php5/apache2/conf.d/20-pdo_mysql.ini, /etc/php5/apache2/conf.d/mcrypt.ini

All in all I like the new installer, less fuss and very clear and simple to run.

Still - what's the story with the .htaccess warning?

Thanks / Frank

NOTE: We are sorry that Frank is no longer with us.
We are grateful for all his contributions to the Zen Cart community.

22 Aug 2013, 1:38 PM
#28
lhungil avatar

lhungil

Totally Zenned

Join Date:
Feb 2012
Location:
mostly harmless
Posts:
1,816
Plugin Contributions:
4

Re: Working on new Installer for v1.6.0 ...

lhungil:

Maybe just call "set_time_limit(30);" ...
Now that I am more awake, something like this would need to go into the code performing the upgrade... Maybe between longer steps...

frank18:

...
Ran the installer on my local dev server and encountered no problems at all. Just a bit puzzled by the message (not verbatim): '....no .htaccess support, you are either not running Apache...... etc' ...
This check is done by testing to see if your webserver is honoring the restrictions placed in the "/includes/.htaccess". It does this by calling CURL against your webserver to request the file "/includes/filenames.php". If the request does not return a 403 status (forbidden / access denied) the restrictions are probably not taking effect and this error message is displayed...

What happens if you go to that location using your browser? If you get the 403... Can you check what is returned around line 318 / 319 of "/zc_install/includes/classes/class.systemChecker.php"?

If you do not get the 403... Could be because of Apache is not reading .htaccess files (disabled)... Or could be one of the directives is failing (or overrides are not allowed)... Is there anything in the Apache error logs?

The glass is not half full. The glass is not half empty. The glass is simply too big!
Where are the Zen Cart Debug Logs? Where are the HTTP 500 / Server Error Logs?
Zen Cart related projects maintained by lhûngîl : Plugin / Module Tracker

22 Aug 2013, 3:44 PM
#29
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: Working on new Installer for v1.6.0 ...

lhungil:

Now that I am more awake, something like this would need to go into the code performing the upgrade... Maybe between longer steps...Right. We've put it into application_top since all the smaller steps re-run that. And used a higher number too.

lhungil:

This check is done by testing to see if your webserver is honoring the restrictions placed in the "/includes/.htaccess". It does this by calling CURL against your webserver to request the file "/includes/filenames.php". If the request does not return a 403 status (forbidden / access denied) the restrictions are probably not taking effect and this error message is displayed...
Correct. If the /includes/.htaccess file is working correctly, then it will deny access for any browser to any .php file under the /includes/ folder or subfolders. And that's what the installer is testing when that message is displayed to you.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

22 Aug 2013, 9:16 PM
#30
frank18 avatar

frank18

Deceased

Join Date:
Nov 2007
Location:
Sunny Coast, Australia
Posts:
3,427
Plugin Contributions:
2

Re: Working on new Installer for v1.6.0 ...

DrByte:

Correct. If the /includes/.htaccess file is working correctly, then it will deny access for any browser to any .php file under the /includes/ folder or subfolders. And that's what the installer is testing when that message is displayed to you.

Thought so, thanks

lhungil:

If you do not get the 403... Could be because of Apache is not reading .htaccess files (disabled)... Or could be one of the directives is failing (or overrides are not allowed)... Is there anything in the Apache error logs?

Found nothing in the logs relating to this issue

NOTE: We are sorry that Frank is no longer with us.
We are grateful for all his contributions to the Zen Cart community.

23 Aug 2013, 2:29 AM
#31
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: Working on new Installer for v1.6.0 ...

The .htaccess testing was added in v1.5.0, and is not unique to v1.6.0.
If you are wanting to discuss the matter further, please use another forum thread for that, since it is off topic.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

14 Dec 2013, 2:36 PM
#32
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,878
Plugin Contributions:
7

Re: Working on new Installer for v1.6.0 ...

On the first access into the admin, you are asked to select country and zone.
After selecting Spain I was only offered the zones for the US.

Should the widget be working for the log files?

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

18 Dec 2013, 5:28 AM
#33
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: Working on new Installer for v1.6.0 ...

These should probably be separate threads, especially if you're encountering specific problems with them.

torvista:

On the first access into the admin, you are asked to select country and zone.
After selecting Spain I was only offered the zones for the US.Yes, the dropdown hasn't been made dynamic yet. You're welcome to submit a pull request if you want to tackle that.

torvista:

Should the widget be working for the log files?It is for me thus far.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

18 Dec 2013, 8:03 AM
#34
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,878
Plugin Contributions:
7

Re: Working on new Installer for v1.6.0 ...

It is for me thus far.
Click on the Pencil for the widget settings, then just click on update. I get a popup.
An unknown response was received while processing an ajax call. The action you requested could not be completed. with a couple of Network Error 500 in the Firebug console and a debug log
[18-Dec-2013 08:55:11 Europe/Berlin] PHP Fatal error: Call to undefined function get_logs_data() in blah-blah\includes\classes\dashboardWidgets\class.zcDashboardWidgetLogs.php on line 22(WinXP, Xampp, Ffox/Chrome/Opera/IE8)

I think there needs to be a new forum section for 1.60 comments and bugs as

  1. 1.6 is not relevant to most people so posts should not be mixed in with bug reports for the current production code of 1.5x
  2. people may try out 1.60 but can't figure out how to report bugs via Github, like me, nor be up to fixing and sumitting pull requests, also like me.

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

18 Dec 2013, 9:40 PM
#35
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: Working on new Installer for v1.6.0 ...

torvista:

  1. people may try out 1.60 but can't figure out how to report bugs via Github, like me, nor be up to fixing and sumitting pull requests, also like me.
    Do you have a github account? (it's free)
    If so, I'm pretty sure you should be able to create issues by clicking this: https://github.com/zencart/zencart/issues/new

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

19 Dec 2013, 6:31 PM
#36
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: Working on new Installer for v1.6.0 ...

torvista:

I think there needs to be a new forum section for 1.60 comments and bugs as

  1. 1.6 is not relevant to most people so posts should not be mixed in with bug reports for the current production code of 1.5x
  2. people may try out 1.60 but can't figure out how to report bugs via Github, like me, nor be up to fixing and sumitting pull requests, also like me.
    http://www.zen-cart.com/forumdisplay.php?165-ZCDEV-v160-Development-Bugs

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

12 Jan 2014, 9:41 AM
#37
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,878
Plugin Contributions:
7

Re: Working on new Installer for v1.6.0 ...

Is there any provision/hooks in the new installer to allow the use of other languages during installation?

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

25 Apr 2016, 4:59 PM
#38
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,878
Plugin Contributions:
7

Re: Working on new Installer for v1.6.0 ...

The installer trawls though the defines in the existing admin configure.php file to check all is well (existing files in the right place, existing database connections working etc.).
However I note it uses the first instance of the constant it finds, whether in use or commented out (for whatever development reason).
So, if the commented define is first in line, and it is not correct for that installation, it doesn't check out and so no Upgrade is offered.
Not asking for this oddity to be taken into account, but it caught me out (for a good while).

"Why multiple defines" you ask...well I have the development sites files/all my files synced/duplicated across various pc's so I can work at whichever is convenient and although the local pc's virtual hosts definitions can be identical, their filesystem location may not be, so DIR_FS_CATALOG may vary.
So I have this in the file, so it works in any of them.

$dir1 = 'D:/Documents/some location.../public_html/tienda_155/';
$dir2 = 'D:/My Documents/some other location.../public_html/tienda_155/';
etc...
if ( is_dir($dir1) ) {
define('DIR_FS_CATALOG', $dir1);
} elseif ( is_dir($dir2) ) {
define('DIR_FS_CATALOG', $dir2);
etc...
}
The installer was picking up $dir1 as the directory.

Still, I've learnt how the installer works now!

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

26 Apr 2016, 3:00 AM
#39
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: Working on new Installer for v1.6.0 ...

torvista:

The installer trawls though the defines in the existing admin configure.php file to check all is well (existing files in the right place, existing database connections working etc.).
However I note it uses the first instance of the constant it finds, whether in use or commented out (for whatever development reason).
So, if the commented define is first in line, and it is not correct for that installation, it doesn't check out and so no Upgrade is offered.
Not asking for this oddity to be taken into account, but it caught me out (for a good while).

"Why multiple defines" you ask...well I have the development sites files/all my files synced/duplicated across various pc's so I can work at whichever is convenient and although the local pc's virtual hosts definitions can be identical, their filesystem location may not be, so DIR_FS_CATALOG may vary.
So I have this in the file, so it works in any of them.

The installer was picking up $dir1 as the directory.

Still, I've learnt how the installer works now!

Well that certainly might explain why someone recently reported having their DIR_WS_IMAGES path set to something non functional and obscure...

ZC Installation/Maintenance Support <- Site
Contribution for contributions welcome...

26 Apr 2016, 3:37 AM
#40
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: Working on new Installer for v1.6.0 ...

mc12345678:

Well that certainly might explain why someone recently reported having their DIR_WS_IMAGES path set to something non functional and obscure...
In the context of zc_install, not likely. If it were installer-related, then it would affect other things more broadly.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.