Forums / Upgrading to 1.5.x / functions_email.php Charset CHARSET : "iso-8859-1" or UFT-8

functions_email.php Charset CHARSET : "iso-8859-1" or UFT-8

Started by peace_freak on 11 May 2013, 11:36 PM · Views: 1,474

Results 1 to 3 of 3
11 May 2013, 11:36 PM
#1
peace_freak avatar

peace_freak

Zen Follower

Join Date:
Apr 2006
Posts:
354
Plugin Contributions:
0

functions_email.php Charset CHARSET : "iso-8859-1" or UFT-8

I believe that zen-cart is basically using UTF-8. I just came across the:

includes/functions/functions_email.php

that has the charset as:

CHARSET : "iso-8859-1";

Should it be changed to UTF-8?

Thanks!

11 May 2013, 11:41 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: functions_email.php Charset CHARSET : "iso-8859-1" or UFT-8

You are misquoting the code.

The full line is this: ```
$mail->CharSet = (defined('CHARSET')) ? CHARSET : "iso-8859-1";


And, if you read it correctly it uses iso-8859-1 only IF the constant for 'CHARSET' is not defined.  And, since any properly installed Zen Cart WILL already have CHARSET defined, that means iso-8859-1 would never be used. That code is only a fallback for VERY RARE situations when CHARSET isn't defined. 
And, if CHARSET is not defined, then there will be numerous far more serious issues.

So, in summary: ignore it.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

12 May 2013, 1:02 AM
#3
peace_freak avatar

peace_freak

Zen Follower

Join Date:
Apr 2006
Posts:
354
Plugin Contributions:
0

Re: functions_email.php Charset CHARSET : "iso-8859-1" or UFT-8

Thank you!