Payment method messages not reset in tpl_checkout_success_default.php

If a payment method (like authorizenet_aim) sets a value into the session variable 'payment_method_messages', those messages are displayed on the checkout success page. If a message was set by one payment method and the customer, during the same session, chose to create another order using a different payment method then those same messages would be displayed to the customer at the conclusion of the second order ... since the session variable is never reset.

Current code fragment in tpl_checkout_success_default.php:

<!-- bof payment-method-alerts -->
<?php
if (isset($_SESSION['payment_method_messages']) && $_SESSION['payment_method_messages'] != '') {
?>
  <div class="content">
  <?php echo $_SESSION['payment_method_messages']; ?>
  </div>
<?php
}
?>
<!-- eof payment-method-alerts -->

Proposed addition in red:

<!-- bof payment-method-alerts -->
<?php
if (isset($_SESSION['payment_method_messages']) && $_SESSION['payment_method_messages'] != '') {
?>
  <div class="content">
  <?php echo $_SESSION['payment_method_messages']; ?>
  </div>
<?php
  unset($_SESSION['payment_method_messages']);
}
?>
<!-- eof payment-method-alerts -->

Good catch of a rare scenario.

As far as fixing, rather than add more business logic to the template, it's probably better to change it like this:

• add to the header_php file: ```
  $additional_payment_messages = '';
  if (isset($_SESSION['payment_method_messages']) && $_SESSION['payment_method_messages'] != '') {
  $additional_payment_messages = $_SESSION['payment_method_messages'];
  unset($_SESSION['payment_method_messages']);
  }

- edit the template file:```
<!-- bof payment-method-alerts -->
<?php
if (isset($additional_payment_messages) && $additional_payment_messages != '') {
?>
  <div class="content">
  <?php echo $additional_payment_messages; ?>
  </div>
<?php
}
?>
<!-- eof payment-method-alerts -->

Thanks, DrByte, I was just being lazy in my proposed fix.