Bug in v1.6.0 class.base.php

The notify function in the current v1.6.0 /includes/classes/class.base.php (https://github.com/zencart/zencart/blob/v160/includes/classes/class.base.php) has a small issue. Since the NOTIFIER_TRACE value is always a string, the fragment NOTIFIER_TRACE != 0 of the following statement never evaluates to true, causing the if-clause to never be executed.

   if (defined('NOTIFIER_TRACE') && NOTIFIER_TRACE != '' && NOTIFIER_TRACE != 0 && NOTIFIER_TRACE != FALSE && NOTIFIER_TRACE != 'false') {

To correct, either remove the fragment or convert it to an exact-match:

   if (defined('NOTIFIER_TRACE') && NOTIFIER_TRACE != '' && NOTIFIER_TRACE !== 0 && NOTIFIER_TRACE != FALSE && NOTIFIER_TRACE != 'false') {

Once I corrected the above, many debug log files were generated with:

[23-Jul-2013 20:33:37] PHP Warning:  array_merge() [<a href='function.array-merge'>function.array-merge</a>]: Argument #2 is not an array in C:\xampp\htdocs\testsite\includes\classes\class.base.update.php on line 58

which results from the following:

$paramArray = array_merge($param1,$param2,$param3,$param4,$param5,$param6,$param7));

To get rid of the PHP warnings (I'm running PHP 5.4.8) and to not flood the already going-to-be-large file with meaningless information, I recoded that line as

      $paramArray = $param1;
      for ($i = 2; $i < 8; $i++) {
        $param_n = "param$i";
        if ($$param_n !== NULL) {
          $paramArray[$param_n] = $$param_n;
        }
      }

That not only removes the warning but also includes the $param{1-7} values ***only ***if they've been specified.

lat9:

Since the NOTIFIER_TRACE value is always a string
Why is that?
Can't it be defined as an integer, or a boolean?

It's coming out of the database, so it's always a string value. In the plugin version, the value can be either 'true' or 'false'; in the v1.6.0 version, it looks like the value can be set to 'true', 'print_r', 'var_export' or 'var_dump' ... none of which will evaluate true with the 'NOTIFIER_TRACE != 0' portion of the if-statement.

lat9:

It's coming out of the database, so it's always a string value.
Oops - I was still thinking it was just a define in a custom PHP file.

In the plugin version, it's controllable via a setting in Configuration->Logging ...