Discount Coupon not excluding Shipping charges

Hi!

My problem is that the discount coupon is not excluding Shipping charges on checkout even though as per settings it "false".

Following are its settings:
Admin > Modules > Order Total > Discount Coupon

Discount Coupon

This module is installed
true

Sort Order
280

Include Shipping
false

Include Tax
false

Re-calculate Tax
Standard

Tax Class
--none--

Tried uninstall and re install also, enable/disable too.

~Time

I'm having this exact issue and haven't found the solution so far... anyone?

What are your settings on the Discount Coupon itself?

Coupon Name :: ANGELMORETESTS
Coupon Amount :: $40.00
Start Date :: 10/24/2014
End Date :: 10/24/2015
Uses per Coupon :: Unlimited
Uses per Customer :: Unlimited
Valid Product List :: --none--
Valid Categories List :: --none--
Date Created :: 10/24/2014

Free shipping box :: unchecked

Could you post the Order Totals that you are seeing with the Discount Coupon set?

Absolutely :

Sub-Total: $29.00
Zone Rates (Shipping to US): $3.95
Discount Coupon: -$40.00
Total: $0.00

And what were you expecting to see?

The total should be $3.95. Shipping shouldn't be covered no matter how much the order is when the setup is Include Shipping: false.

Thanks for your help, Linda!

This is not a 100% fix to everything in the file:
/includes/modules/order_total/ot_coupon.php

But try changing the code to the code in RED:

            case 'F': // amount Off
[B]//[/B]              $od_amount['total'] = zen_round($coupon->fields['coupon_amount'] * ($orderTotalDetails['orderTotal']>0), $currencyDecimalPlaces);
[B]              $od_amount['total'] = zen_round(($coupon->fields['coupon_amount'] > $orderTotalDetails['orderTotal'] ? $orderTotalDetails['orderTotal'] : $coupon->fields['coupon_amount']) * ($orderTotalDetails['orderTotal']>0), $currencyDecimalPlaces);[/B]

and see how that works for you ...

NOTE: this is not a solution for everyone, but a temporary fix for you at this time ...

Linda,
Not quite there... now it doesn't apply the coupon at all unless they spend more than the coupon amount. My test order above wasn't discounted at all.

Thought I checked that ... let me go back to the drawing board ... :lookaroun

Are you using the original ot_coupon.php file from Zen Cart v151?

Yep, I ran a comparison to make sure. Thanks for your help! It's much appreciated.

And you changed to code around line 418 to read:

            case 'F':
[B]//[/B]              $od_amount['total'] = zen_round($coupon->fields['coupon_amount'] * ($orderTotalDetails['orderTotal']>0), $currencyDecimalPlaces);
[B]              $od_amount['total'] = zen_round(($coupon->fields['coupon_amount'] > $orderTotalDetails['orderTotal'] ? $orderTotalDetails['orderTotal'] : $coupon->fields['coupon_amount']) * ($orderTotalDetails['orderTotal']>0), $currencyDecimalPlaces);
[/B]              $od_amount['type'] = $coupon->fields['coupon_type']; // amount off 'F' or amount off and free shipping 'O'
              $ratio = $od_amount['total']/$orderTotalDetails['orderTotal'];
              break;

Yes, copied your code exactly.

Could you go to phpMyAdmin and browse the table:
coupons

and find this coupon and see what the contents of the field:
coupon_type

is set to ... is that an F?

Yep, F.

Could you show what you are seeing in the totals when you use this new code?

It isn't making a lot of sense as this is working without issue for me ...

I am assuming you have the same settings on the Discount Coupon ot_coupon in the Modules ... Order Totals ... and that the Discount Coupon is still set to 40.00 with no restrictions ...

OK, this code actually doesn't apply the coupon at all, regardless of the total amount. I thought I'd try it again just in case I somehow messed it up.

1 x ... $29.00
1 x ... $20.00
Sub-Total: $49.00
Zone Rates (Shipping to US): $3.95
Total: $52.95