Zen Cart Logo
Forums / Bug Reports / [Done v1.6.0] admin->option_values type invalid doctype

[Done v1.6.0] admin->option_values type invalid doctype

Locked

Views: 1,227

Results 1 to 3 of 3
This thread is locked. New replies are disabled.
4 Dec 2013, 10:04 PM
#1
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,872
Plugin Contributions:
7

[Done v1.6.0] admin->option_values type invalid doctype

<!doctsype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

and while I'm at it, this doctype, while apparently valid, renders quirks mode.
Just wondering why it has not been changed to a recommended version ie:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

http://www.w3.org/QA/2002/04/valid-dtd-list.html

12 Dec 2013, 8:06 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
177

Re: [Done v1.6.0] admin->option_values type invalid doctype

You initially reported this against v1.5.2.

torvista:

<!doctsype

That's been there in that particular file since v1.1.0. (So I've updated your post to reflect that it applies to v1.2.x since there's no v1.1.x entry to choose from since it's 10 years old).

  1. What specific problems is it causing for you? Or is this feedback just being reported by a validator tool?

We've fixed it for v1.6.0, but I'm interested in the scope of impact on your actual use of the code.

The rest of your note about doctype similarly affects almost all the other admin files, and is already addressed in v1.6.0.

  1. Is your validator tool reporting problems with the 1.6.0 code?
14 Dec 2013, 2:53 PM
#3
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,872
Plugin Contributions:
7

Re: [Done v1.6.0] admin->option_values type invalid doctype

  1. Is your validator tool reporting problems with the 1.6.0 code?
    For example on the admin index, mostly warnings about using obsolete table attributes instead of css, an unencoded ampersand and an unclosed div. Same warnings when pasted into the W3C online validator.