6 Jan 2014, 2:38 PM
Administrator
- Join Date:
- Sep 2009
- Location:
- Stuart, FL
- Posts:
- 14,086
- Plugin Contributions:
- 56
Mismatched table-row/column tags in options_values_manager.php
The file /admin/options_values_manager.php generates invalid HTML, based on missing/unbalanced closing table-row/column pairs. There are a couple of places that require correction:
<?php
// hide buttons when editing
if ($action== 'update_option_value') {
?>
<td width='120' align="center" class="smallText"> </td>
<?php
} else {
?>
<!-- <td align="center" class="smallText"> <?php echo '<a href="' . zen_href_link(FILENAME_OPTIONS_VALUES_MANAGER, 'action=update_option_value&value_id=' . $values_values->fields['products_options_values_id'] . (isset($_GET['value_page']) ? '&value_page=' . $_GET['value_page'] : ''), 'NONSSL') . '">'; ?><?php echo zen_image_button('button_edit.gif', IMAGE_UPDATE); ?></a> <?php echo '<a href="' . zen_href_link(FILENAME_OPTIONS_VALUES_MANAGER, 'action=delete_option_value&value_id=' . $values_values->fields['products_options_values_id'] . '&option_id=' . $option_id, 'NONSSL') , '">'; ?><?php echo zen_image_button('button_delete.gif', IMAGE_DELETE); ?></a> </td> -->
<td align="center" class="smallText"> <?php echo '<a href="' . zen_href_link(FILENAME_OPTIONS_VALUES_MANAGER, 'action=update_option_value&value_id=' . $values_values->fields['products_options_values_id'] . (isset($_GET['option_page']) ? '&option_page=' . $_GET['option_page'] . '&' : '') . (isset($_GET['value_page']) ? '&value_page=' . $_GET['value_page'] . '&' : '') . (isset($_GET['attribute_page']) ? '&attribute_page=' . $_GET['attribute_page'] : '') ) . '">'; ?><?php echo zen_image_button('button_edit.gif', IMAGE_UPDATE); ?></a> <?php echo '<a href="' . zen_href_link(FILENAME_OPTIONS_VALUES_MANAGER, 'action=delete_option_value&value_id=' . $values_values->fields['products_options_values_id'] . (isset($_GET['option_page']) ? '&option_page=' . $_GET['option_page'] . '&' : '') . (isset($_GET['value_page']) ? '&value_page=' . $_GET['value_page'] . '&' : '') . (isset($_GET['attribute_page']) ? '&attribute_page=' . $_GET['attribute_page'] : '') ) , '">'; ?><?php echo zen_image_button('button_delete.gif', IMAGE_DELETE); ?></a> </td>
<?php
// $values_values->MoveNext();
}
?>
<?php
}
$max_values_id_values = $db->Execute("select max(products_options_values_id) + 1
as next_id from " . TABLE_PRODUCTS_OPTIONS_VALUES);
$next_id = $max_values_id_values->fields['next_id'];
//-bof-BUGFIX-close current <tr>
?>
</tr>
<?php
//-eof-BUGFIX-close current <tr>
// good one
$values_values->MoveNext();
}
?>
<?php
/*-BUGFIX-remove previous tr
</tr>
*/ ?>
<tr>
<td colspan="5"><?php echo zen_black_line(); ?></td>
</tr>
<?php
if ($action != 'update_option_value') {
?>
and, then, further down in the file:
<?php
echo '</form>';
?>
</tr>
<tr>
<td colspan="5"><?php echo zen_black_line(); ?></td>
</tr>
<?php
}
}
?>
<?php
/*-BUGFIX-remove stray end tags
</td>
</tr>
*/ ?>
<?php if ($_SESSION['option_names_values_copier'] == '0') { ?>
<table align="center" width="90%">