Westminster New

Thanks!
Another question - does the template alter /includes/modules/pages/featured_products/header_php.php? Now my featured products listing breaks.

kalastaja:

Thanks!
Another question - does the template alter /includes/modules/pages/featured_products/header_php.php? Now my featured products listing breaks.

You have the files for BOTH templates.. If you see a /includes/modules/pages/featured_products/header_php.php file in the install package, consider it modified... simple

or you could answer your own question and compare the /includes/modules/pages/featured_products/header_php.php file in the install package to the default Zen Cart version of the file..

Either way, this is a pretty easy DIY kind of answer..

DivaVocals:

Either way, this is a pretty easy DIY kind of answer..
Sorry. Wrong question. Any idea why the westminster file breaks for me? This what the system says:

[05-Feb-2015 19:29:58 Europe/Helsinki] PHP Fatal error:  1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'limit 10' at line 1 ::  limit 10 ==> (as called by) /home/fh2fuvvy/public_html/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php on line 23 <== in /home/fh2fuvvy/public_html/includes/classes/db/mysql/query_factory.php on line 155

If I replace it with ZenCart original it works.

kalastaja:

Sorry. Wrong question. Any idea why the westminster file breaks for me? This what the system says:

[05-Feb-2015 19:29:58 Europe/Helsinki] PHP Fatal error: 1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'limit 10' at line 1 :: limit 10 ==> (as called by) /home/fh2fuvvy/public_html/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php on line 23 <== in /home/fh2fuvvy/public_html/includes/classes/db/mysql/query_factory.php on line 155

> If I replace it with ZenCart original it works.

This file is not in the template package:

/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php 

Thanks,

Anne

picaflor-azul:

This file is not in the template package:
/includes/templates/template_default/templates/tpl_modules_products_featured_listing.php
Ok, but the problem would seem to be the header_php.php, because if I change it to file that comes with ZenCart, it works!
As far as I can understand the header-file does (or doesn't) do something, which the backfires in the tpl_modules_products_featured_listing-file

Wanted to share this.. In the reviews sidebox, the text color is white on a white background.. This is a no no with the search engines.. Here's Google's policy:

Hidden text and links

Hiding  text or links in your content to manipulate Google’s search rankings  can be seen as deceptive and is a violation of Google’s [Webmaster Guidelines](https://support.google.com/webmasters/answer/answer.py?answer=35769). Text (such as excessive keywords) can be hidden in several ways, including:

• Using white text on a white background

• Locating text behind an image

• Using CSS to position text off-screen

• Setting the font size to 0

• Hiding a link by only linking one small character—for example, a hyphen in the middle of a paragraph

I changed the following in the stylesheet to address

.sideBoxContentItem a, #reviewsContent a {
    font-weight: normal;
    clear: both;
[B]    color: #FFF;[/B]
    margin-bottom: 20px;
    padding-bottom: 10px;
}
}

Note I simply removed the color:#fff;.. The links should now inherit the default links colors.

DivaVocals:

Wanted to share this.. In the reviews sidebox, the text color is white on a white background.. This is a no no with the search engines.. Here's Google's policy:

I changed the following in the stylesheet to address

.sideBoxContentItem a, #reviewsContent a {
font-weight: normal;
clear: both;
[B] color: #FFF;[/B]
margin-bottom: 20px;
padding-bottom: 10px;
}
}

> 
> Note I simply removed the color:#fff;.. The links should now inherit the default links colors.

Thanks for catching this bug.  The text is not supposed to be white.  I'll put this on the list for a future update.

Thanks,

Anne

Just wanted to post an update to the jquery.slimmenu.min.js file. I believe that this update fixes the problem that some users were having with long category lists and the menu collapsing on touch devices.

Just replace the includes/templates/westminster_new/jscript/jquery.slimmenu.min.js file with the following:

/**
 * jquery.slimmenu.js
 * http://adnantopal.github.io/slimmenu/
 * Author: @adnantopal
 * Copyright 2013, Adnan Topal (atopal.com)
 * Licensed under the MIT license.
 * update by dusty73 https://github.com/dusty73/slimmenu/commit/70d5c15bdbefeb2bad8f96d6387719c88b84d1e6
 */
(function(e,t,n,r){function u(t,n){this.element=t;this.$elem=e(this.element);this.options=e.extend({},s,n);this.init()}var i="slimmenu",s={resizeWidth:"768",collapserTitle:"Main Menu",animSpeed:"medium",easingEffect:null,indentChildren:false,childrenIndenter:"  "};var o=0;u.prototype={init:function(){var n=this.options,r=this.$elem,i='<div class="menu-collapser">'+n.collapserTitle+'<div class="collapse-button"><span class="icon-bar"></span><span class="icon-bar"></span><span class="icon-bar"></span></div></div>',s;r.before(i);s=r.prev(".menu-collapser");r.on("click",".sub-collapser",function(t){t.preventDefault();t.stopPropagation();var r=e(this).closest("li");if(e(this).hasClass("expanded")){e(this).removeClass("expanded");e(this).find("i").html("▼");r.find(">ul").slideUp(n.animSpeed,n.easingEffect)}else{e(this).addClass("expanded");e(this).find("i").html("▲");r.find(">ul").slideDown(n.animSpeed,n.easingEffect)}});s.on("click",".collapse-button",function(e){e.preventDefault();r.slideToggle(n.animSpeed,n.easingEffect)});this.resizeMenu({data:{el:this.element,options:this.options}});e(t).on("resize",{el:this.element,options:this.options},this.resizeMenu)},resizeMenu:function(n){var r=e(t),i=n.data.options,s=e(n.data.el),a=e("body").find(".menu-collapser");if(o==r.width()){return}o=r.width();s.find("li").each(function(){if(e(this).has("ul").length){if(e(this).has(".sub-collapser").length){e(this).children(".sub-collapser i").html("▼")}else{e(this).append('<span class="sub-collapser"><i>▼</i></span>')}}e(this).children("ul").hide();e(this).find(".sub-collapser").removeClass("expanded").children("i").html("▼")});if(i.resizeWidth>=r.width()){if(i.indentChildren){s.find("ul").each(function(){var t=e(this).parents("ul").length;if(!e(this).children("li").children("a").has("i").length){e(this).children("li").children("a").prepend(u.prototype.indent(t,i))}})}s.find("li").has("ul").off("mouseenter mouseleave");s.addClass("collapsed").hide();a.show()}else{s.find("li").has("ul").on("mouseenter",function(){e(this).find(">ul").stop().slideDown(i.animSpeed,i.easingEffect)}).on("mouseleave",function(){e(this).find(">ul").stop().slideUp(i.animSpeed,i.easingEffect)});s.find("li > a > i").remove();s.removeClass("collapsed").show();a.hide()}},indent:function(e,t){var n="";for(var r=0;r<e;r++){n+=t.childrenIndenter}return"<i>"+n+"</i>"}};e.fn[i]=function(t){return this.each(function(){if(!e.data(this,"plugin_"+i)){e.data(this,"plugin_"+i,new u(this,t))}})}})(jQuery,window,document)

I will include this in the next template update also.

Thanks,

Anne

picaflor-azul:

Just wanted to post an update to the jquery.slimmenu.min.js file. I believe that this update fixes the problem that some users were having with long category lists and the menu collapsing on touch devices.

Just replace the includes/templates/westminster_new/jscript/jquery.slimmenu.min.js file with the following:

I will include this in the next template update also.

Thanks,

AnneIf this is one of the two posted fixes in the Slim Menu Github repo, then YEP they both work and solve the problem finally.. There are pull requests for both, but last time I checked the author hadn't yet accepted either pull request.

Don't have time today to troubleshoot, but that change made no positive difference.

Galaxy Tab 3 800x1280 px
No initial detectable difference, Android/FireFox. menu still collapses
Android/Chrome replaces menu triangles (or arrows) with question marks. Collapsing menu still exists.

picaflor-azul:

Just wanted to post an update to the jquery.slimmenu.min.js file. I believe that this update fixes the problem that some users were having with long category lists and the menu collapsing on touch devices.

RixStix:

Don't have time today to troubleshoot, but that change made no positive difference.

Galaxy Tab 3 800x1280 px
No initial detectable difference, Android/FireFox. menu still collapses
Android/Chrome replaces menu triangles (or arrows) with question marks. Collapsing menu still exists.

RixStix.. Go to the Slimmenu authors GitHub repo.. There's an issue I created where I tagged/linked/rounded up all the posted fixes for this known and annoying issue.. I tried them both and they BOTH worked for me on my Android devices.

RixStix:

Don't have time today to troubleshoot, but that change made no positive difference.

Galaxy Tab 3 800x1280 px
No initial detectable difference, Android/FireFox. menu still collapses
Android/Chrome replaces menu triangles (or arrows) with question marks. Collapsing menu still exists.

I have confirmation from several testers that it is working. Perhaps you have not implemented it properly on your site?

Thanks,

Anne

picaflor-azul:

I have confirmation from several testers that it is working. Perhaps you have not implemented it properly on your site?

Possibly. It could be cache/cookie/etc related. I'll try again later. All I did was copy/paste the code into the existing file.

Samsung GalaxyTab3 800 x 1280 px

RixStix:

Possibly. It could be cache/cookie/etc related. I'll try again later. All I did was copy/paste the code into the existing file.

Samsung GalaxyTab3 800 x 1280 px

or it could be that there are characters in this code that don't belong:

html("▼")}

I saw this particular character throughout this code..

DivaVocals:

or it could be that there are characters in this code that don't belong:

html("▼")}

> 
> I saw this particular character throughout this code..

You are correct.  Try the attached file instead.

Thanks,

Anne

Sorry, this is the correct attachment.

Thanks,

Anne

picaflor-azul:

Sorry, this is the correct attachment.

Maybe I should be a bit more specific. I have cleared history and cookies from both Android Chrome and Android FireFox browsers and see no difference in menu functionality before and after replacing the file. Maybe we are differing in our terminology.

Categories/subcategories have 2 tappable buttons each. The text and the arrow. Functionality differs depending upon which is tapped.
Tapping the text button, will cause sub-categories to appear but collapse.
Tapping the arrow associated with the categories will cause the sub-category to appear and not collapse.

My expectation was that either tappable button (text or arrow) should yield the same response/functionality and not experience collapsing menus.

Were your testers using an Android device with a screen resolution of 800 x 1280 px?
Am I looking for something different than this patch is intended?

Using Diva's github suggestion did not yield any different results.

RixStix:

Maybe I should be a bit more specific. I have cleared history and cookies from both Android Chrome and Android FireFox browsers and see no difference in menu functionality before and after replacing the file. Maybe we are differing in our terminology.

Categories/subcategories have 2 tappable buttons each. The text and the arrow. Functionality differs depending upon which is tapped.
Tapping the text button, will cause sub-categories to appear but collapse.
Tapping the arrow associated with the categories will cause the sub-category to appear and not collapse.

My expectation was that either tappable button (text or arrow) should yield the same response/functionality and not experience collapsing menus.

Were your testers using an Android device with a screen resolution of 800 x 1280 px?
Am I looking for something different than this patch is intended?

Using Diva's github suggestion did not yield any different results.
I am testing with three Android devices and the behavior is corrected on all three..

I click the hamburger icon, menu displays, I scroll to the bottom of the menu and the menu does not collapse.
I click on the text of a top level menu item, and the menu collapses and takes me to the link associated with the top level menu item
I click on a submenu arrow and the sub menu appears. Again scrolling down does not cause the menu to collapse.
I click on the text of a sub-menu item, and the menu collapses and takes me to the link associated with the sub-menu item

Works perfect on all devices.. My test group Android and Apple users report that the functionality works as expected.

I did not expect that tapping the text and tapping the arrow icons would yield the same result.. neither did my test users (and I do not tell them what to expect because I want their GENUINE reactions)..

I expected that the arrows would open/close menus or sub-menus, I expected the text would take me to an associated link.. Perhaps this is because this is how a similar desktop menu would have behaved. So I don't expect DIFFERENT behavior on a mobile device.. I do expect that hover will likely not work on a mobile device..

While customizing the left slide out menu, I decided to change the name for the ezpages. Well, the ezpages weren't showing up after I did that! So I changed it back to Useful Links but they're still not showing up. I didn't change any ezpage or template settings in admin. Any idea? I've tried everything to get them back in the top drop down menu :( https://www.bellaornamenti.com Thank you, Andrea

Thanks for sharing this, I too have fixed this for my store that is using this awesome template :-)

DivaVocals:

Wanted to share this.. In the reviews sidebox, the text color is white on a white background.. This is a no no with the search engines.. Here's Google's policy:

I changed the following in the stylesheet to address

.sideBoxContentItem a, #reviewsContent a {
font-weight: normal;
clear: both;
[B] color: #FFF;[/B]
margin-bottom: 20px;
padding-bottom: 10px;
}
}

> 
> Note I simply removed the color:#fff;.. The links should now inherit the default links colors.