23 May 2014, 2:42 PM
Totally Zenned
- Join Date:
- Sep 2004
- Location:
- Western Massachusetts
- Posts:
- 2,361
- Plugin Contributions:
- 1
[Done 1.5.3] Paypal Status Check - incorrect nesting of condition check
In includes/modules/payment/paypaldp.php - for the function update_status()...
The condition checks for order amount exceeding 10,000 or order total = 0 (starting at line 231) are currently nested inside the check for the payment zone at line 205:
if ($this->enabled && (int)$this->zone > 0 && isset($order->billing['country']['id']))
The resulting effect of this is that if there is no payment zone set for the module (ie: MODULE_PAYMENT_PAYPALDP_ZONE = 0), these order amount condition checks are completely bypassed.
Shouldn't these two order amount condition checks be moved outside the zone check at line 205?
(I also checked the fileset for v1.5.2-RC2 - issue is the same there)
Neville
An assumption is what you arrive at when you get tired of thinking...
