[Not a bug] Use of zen_record_admin_activity without defines

5 Jan 2015, 9:38 AM

Zen Follower

Join Date:: Feb 2005
Location:: Italy
Posts:: 178
Plugin Contributions:: 0

[Not a bug] Use of zen_record_admin_activity without defines

Hi all, I found in v154 that there are 85 occurrences of zen_record_admin_activity in 29 files where text messages are written directly in english without the use of defines.

I believe that this should be corrected.

Paolo De Dionigi
Co-maintainer of Zen Cart Italia

5 Jan 2015, 2:40 PM

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,513
Plugin Contributions:: 176

Re: [Not a bug] Use of zen_record_admin_activity without defines

That was intentional. It's a PCI requirement, and hard-coding the messages makes it harder for malicious intruders to hide their tracks.
Much like server operating-system logging, which is in English despite what languages are configured on the server, this provides an audit trail that can be used to understand malicious activity and more effectively recover from damages done.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

5 Jan 2015, 4:37 PM

s_p_ike

Zen Follower

Join Date:: Feb 2005
Location:: Italy
Posts:: 178
Plugin Contributions:: 0

Re: [Not a bug] Use of zen_record_admin_activity without defines

Ok, I didn't know. Thank you for explaining.

Paolo De Dionigi
Co-maintainer of Zen Cart Italia