Responsive Sheffield Blue v2.0

jpda:

I agree! My point was 'acceptable compared to the alternative', i.e. having the js problem whenever one of the new, specials or featured are empty (which occurs automatically w/o notice). The best solution is to change the test in the tpl_modules_*_php files and only show the meaningful tabs.
On the other hand, the links to new, featured and specials in info boxes or footer are always visible (once being activated), whether such products exist or not.

Any idea which add-on could be incompatible?

Cheers,

jpda

Gotcha, agree, needs to work. The "add-on" that seems to be the issue in regards to these three tabs seems to be includes/templates/responsive_sheffield_blue/jscript/cbpFWTabs.js

Either when it is initially called in includes/templates/responsive_sheffield_blue/templates/tpl_index_default.php or in the code of the javascript. Either the javascript shouldnotbe shown/loaded at all, or if loaded should not cause issues if something else was purposefully missing. See javascript is an added feature. If the customer/guest were to access the site with javascript disabled, then one would expect that everything should work. It may not look as pretty, but it should still work... Then when the javascript is added it should not then prevent operation but instead slip intoo the mix... But sometimes little things don't quite work as expected or they are modified beyond original intent. Can't get it all every time. :)

picaflor-azul:

This is not really a bug in the template. In a future update I will probably include a js that makes all boxes the same height.

You can either add a min-value to the .centerBoxContentsProducts or you can use a javascript to make all of the centerBoxContentsProducts boxes the same height.

Thanks,

Anne

could i really quick as the min value i add to the style sheet?
do i add a max value too if so?
i know you are very busy so if anyone else knows what line that is i would greatly appreciate it

sweetmade:

could i really quick as the min value i add to the style sheet?
do i add a max value too if so?
i know you are very busy so if anyone else knows what line that is i would greatly appreciate it
In stylesheet.css line 266. Add the code in red. You can play around with the values 350px and 400px using web developer tools.

.centerBoxContentsAlsoPurch, .centerBoxContentsProducts, .centerBoxContentsNew, .centerBoxContentsFeatured, .centerBoxContentsSpecials{border:1px solid #dbdbce;background:#f7f7f7;padding:20px 0px;width:30% !important;transition:background 2s ease; -webkit-transition:background 2s ease;-moz-transition: background 2s ease;  -o-transition:background 2s ease;text-align:center;margin-left:15px;margin-bottom:20px;min-height:350px;max-height:400px;}

Cheers,

jpda

jpda:

In stylesheet.css line 266. Add the code in red. You can play around with the values 350px and 400px using web developer tools.

.centerBoxContentsAlsoPurch, .centerBoxContentsProducts, .centerBoxContentsNew, .centerBoxContentsFeatured, .centerBoxContentsSpecials{border:1px solid #dbdbce;background:#f7f7f7;padding:20px 0px;width:30% !important;transition:background 2s ease; -webkit-transition:background 2s ease;-moz-transition: background 2s ease; -o-transition:background 2s ease;text-align:center;margin-left:15px;margin-bottom:20px;min-height:350px;max-height:400px;}

> 
> Cheers,
> 
> jpda

thank you very much

mc12345678:

Gotcha, agree, needs to work. The "add-on" that seems to be the issue in regards to these three tabs seems to be includes/templates/responsive_sheffield_blue/jscript/cbpFWTabs.js

Either when it is initially called in includes/templates/responsive_sheffield_blue/templates/tpl_index_default.php or in the code of the javascript. Either the javascript shouldnotbe shown/loaded at all, or if loaded should not cause issues if something else was purposefully missing. See javascript is an added feature. If the customer/guest were to access the site with javascript disabled, then one would expect that everything should work. It may not look as pretty, but it should still work... Then when the javascript is added it should not then prevent operation but instead slip intoo the mix... But sometimes little things don't quite work as expected or they are modified beyond original intent. Can't get it all every time. :)
Found a rather simple solution:
In includes\templates\responsive_sheffield_blue\templates\tpl_index_default.php:
I added these lines (in red):

 * Modified by Anne (Picaflor-Azul.com) Responsive Sheffield Blue v1.0 v2.0
 */
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_NEW_PRODUCTS));// added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_FEATURED_PRODUCTS_MODULE)); // added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_SPECIALS_INDEX));// added jpda

(I'm not sure if this complies with ZC's rules and regulations, there might be a better way to get $zc_show_featured, $zc_show_specials and $zc_show_new_products?)

And I added the code in red to these lines: (under //bof module navigation)

while (!$show_display_nav->EOF) {
  switch ($show_display_nav->fields['configuration_key']) {
  case 'SHOW_PRODUCT_INFO_MAIN_FEATURED_PRODUCTS':
    if ($zc_show_featured) echo '<li><a href="section-2" class="icon-shop"><span>' . BOX_HEADING_FEATURED_PRODUCTS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_SPECIALS_PRODUCTS':
    if ($zc_show_specials) echo '<li><a href="section-3" class="icon-cup"><span>' . BOX_HEADING_SPECIALS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_NEW_PRODUCTS':
    if ($zc_show_new_products) echo '<li><a href="section-1" class="icon-food"><span>' . BOX_HEADING_WHATS_NEW . '</span></a></li>'. "\n";
    break;
  }
  $show_display_nav->MoveNext();
}

Restored the next three files to the original template files from RSB v2.0 :
includes\templates\responsive_sheffield_blue\templates\tpl_modules_specials_default.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_featured_products.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_whats_new.php
(However, I changed the section id's to be consistent with tpl_index_default.php)

Only tabs will be shown that actually contain information AND are allowed by settings in admin>index listing.

Cheers,

jpda

jpda:

Found a rather simple solution:
In includes\templates\responsive_sheffield_blue\templates\tpl_index_default.php:
I added these lines (in red):

• Modified by Anne (Picaflor-Azul.com) Responsive Sheffield Blue v1.0 v2.0
  */
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_NEW_PRODUCTS));// added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_FEATURED_PRODUCTS_MODULE)); // added jpda
  include(DIR_WS_MODULES . zen_get_module_directory(FILENAME_SPECIALS_INDEX));// added jpda
  

> 
> (I'm not sure if this complies with ZC's rules and regulations, there might be a better way to get $zc_show_featured, $zc_show_specials and $zc_show_new_products?)
> 
> And I added the code in red to these lines: (under //bof module navigation)
> ```
while (!$show_display_nav->EOF) {
  switch ($show_display_nav->fields['configuration_key']) {
  case 'SHOW_PRODUCT_INFO_MAIN_FEATURED_PRODUCTS':
    if ($zc_show_featured) echo '<li><a href="section-2" class="icon-shop"><span>' . BOX_HEADING_FEATURED_PRODUCTS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_SPECIALS_PRODUCTS':
    if ($zc_show_specials) echo '<li><a href="section-3" class="icon-cup"><span>' . BOX_HEADING_SPECIALS . '</span></a></li>'. "\n";
    break;
  case 'SHOW_PRODUCT_INFO_MAIN_NEW_PRODUCTS':
    if ($zc_show_new_products) echo '<li><a href="section-1" class="icon-food"><span>' . BOX_HEADING_WHATS_NEW . '</span></a></li>'. "\n";
    break;
  }
  $show_display_nav->MoveNext();
}

Restored the next three files to the original template files from RSB v2.0 :
includes\templates\responsive_sheffield_blue\templates\tpl_modules_specials_default.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_featured_products.php
includes\templates\responsive_sheffield_blue\templates\tpl_modules_whats_new.php
(However, I changed the section id's to be consistent with tpl_index_default.php)

Only tabs will be shown that actually contain information AND are allowed by settings in admin>index listing.

Cheers,

jpda

Cool: I assume something similar would need to be done to tpl_index_categories as was to tpl_index_default or did the problem not exist when navigating categories and only on the home page of the site?

spawnie69:

How can I remove Brands from the top header? I am at https://www.gelcandlecompany.com/demo

I tried looking at includes/templates/responsive_sheffield_blue/templates/tpl_modules_mobile_categories_tabs.php
and found this area but not sure where to disable:

<li class="brands-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand -->

          <ul >
           <?php

$show_manufacturers= true;

Am I looking at the right file?

Yes, you can remove the entire brands section from the tpl_modules_mobile_categories_tabs.php, or you can use css to hide the brands drop down.

Thanks,

Anne

spawnie69:

Have I missed something? How can I set to 3 columns? I see only 2 at my homepage.

This template can be used as a 1, 2, or 3 column layout. Turn left/right hand columns on/off in admin--configuration--layout settings.

Thanks,

Anne

On the product info page how would you add the text "click for larger image" under the product image???? Right now I have no text under the product picture.

fjbern1943:

On the product info page how would you add the text "click for larger image" under the product image???? Right now I have no text under the product picture.

There may be a constant defined for this. Check the includes/templates/responsive_sheffield_blue/templates/tpl_modules_main_product_image.php

Thanks,

Anne

mc12345678:

Cool: I assume something similar would need to be done to tpl_index_categories as was to tpl_index_default or did the problem not exist when navigating categories and only on the home page of the site?
Yes, the problem exists there as well.
Thanks, good point! Didn't notice because in admin>layout settings CATEGORIES_START_MAIN was set to '' (blank).
I applied exactly the same changes to tpl_index_categories.php, problem solved.

Cheers,

jpda

picaflor-azul:

There may be a constant defined for this. Check the includes/templates/responsive_sheffield_blue/templates/tpl_modules_main_product_image.php

Thanks,

Anne

Here s the right answer:
goto: /includes/languages/responsive_sheffield_blue/english.php
Line #291 : define('TEXT_CLICK_TO_ENLARGE', '');
and change to: define('TEXT_CLICK_TO_ENLARGE', 'Click to Enlarge');

fjbern1943:

Here s the right answer:
goto: /includes/languages/responsive_sheffield_blue/english.php
Line #291 : define('TEXT_CLICK_TO_ENLARGE', '');
and change to: define('TEXT_CLICK_TO_ENLARGE', 'Click to Enlarge');

I am happy that you figured it out ;)

Thanks,

Anne

Hi Anne,

When I click 'Featured' in the footer of the demo, I see TEXT_NO_PRODUCTS (undefined) from includes/modules/responsive_sheffield_blue/product_listing.php on line 269. The same happens in my local demo clicking 'Specials' or 'New Arrivals' in the footer if there is nothing to show. I think the constant TEXT_NO_PRODUCTS is only used in searches, defined as 'There is no product that matches the search criteria.'
I could add a define for TEXT_NO_PRODUCTS to includes/languages/responsive_sheffield_blue/english.php but that would be the same text for Featured, Specials and New.
Any idea how to select one of three applicable defines in product_listing.php on line 269?

Thanks,

jpda

I'm using One of Anne's other templates but there is a lot of crossover. She defines it in

includes/languages/english/westminster_new/index.php

Line #42 : define('TEXT_NO_PRODUCTS', 'There are no products to list in this category.'); 

Line #43 : define('TEXT_NO_PRODUCTS2', 'There is no product available from this manufacturer.'); 
]

I don't know why there and not the English.php though. And the wording is vague enough you could use for all 3 situations.

Lruskauff

jpda:

Hi Anne,

When I click 'Featured' in the footer of the demo, I see TEXT_NO_PRODUCTS (undefined) from includes/modules/responsive_sheffield_blue/product_listing.php on line 269. The same happens in my local demo clicking 'Specials' or 'New Arrivals' in the footer if there is nothing to show. I think the constant TEXT_NO_PRODUCTS is only used in searches, defined as 'There is no product that matches the search criteria.'
I could add a define for TEXT_NO_PRODUCTS to includes/languages/responsive_sheffield_blue/english.php but that would be the same text for Featured, Specials and New.
Any idea how to select one of three applicable defines in product_listing.php on line 269?

Thanks,

jpda

If you do a search of the forum you will find that this has already been asked and answered.

Thanks,

Anne

jpda:

No need to change tpl_modules_mobile_categories_tabs.php.
Add this line ```
ul.slimmenu li.brands-li{display:none;}

> 
> Cheers,
> 
> jpda

Thank you jpda!
I managed to take out the Brands from the top menu from my sheffield blue template. <https://www.gelcandlecompany.com/demo>
Before I proceed to go forward with my upgrade I noticed that I won't need the Information and sub menus links as well.
To do this where do I need to place  {display:none;} somewhere else on the same page as tpl_modules_mobile_categories_tabs.php ?

Cheers!

spawnie69:

Thank you jpda!
I managed to take out the Brands from the top menu from my sheffield blue template. https://www.gelcandlecompany.com/demo
Before I proceed to go forward with my upgrade I noticed that I won't need the Information and sub menus links as well.
To do this where do I need to place {display:none;} somewhere else on the same page as tpl_modules_mobile_categories_tabs.php ?

Cheers!

You can use:

ul.slimmenu li.info-li{display:none;}

Thanks,

Anne

lruskauff:

I'm using One of Anne's other templates but there is a lot of crossover. She defines it in

includes/languages/english/westminster_new/index.php

Line #42 : define('TEXT_NO_PRODUCTS', 'There are no products to list in this category.');

Line #43 : define('TEXT_NO_PRODUCTS2', 'There is no product available from this manufacturer.');
]

> I don't know why there and not the English.php though.  And the wording is vague enough you could use for all 3 situations.
> 
> Lruskauff

I did find those defines, they are stock Zen Cart, but in RSBv2.0 apparently not loaded when you click featured, specials or new products from the footer.
Thanks for your response!

Cheers,


jpda

jpda:

I did find those defines, they are stock Zen Cart, but in RSBv2.0 apparently not loaded when you click featured, specials or new products from the footer.
Thanks for your response!

Cheers,

jpda

I am happy that you figured it out.

Thanks,

Anne