Zen Cart Logo
Forums / General Questions / November 2015 Security Patch html_output.php css styling conflict?

November 2015 Security Patch html_output.php css styling conflict?

Views: 3,741

Results 1 to 7 of 7
5 Dec 2015, 6:33 PM
#1
marcopolo avatar

marcopolo

Totally Zenned

Join Date:
May 2008
Location:
United States
Posts:
516
Plugin Contributions:
2

November 2015 Security Patch html_output.php css styling conflict?

Applying the patch is causing my shipping estimator button to enlarge, not sure why?

This part of the patch is casuing the issue:

File:** html_output.php**

changed:

    $mouse_out_class  = 'cssButton ' . (($type == 'submit') ? 'submit_button ' : 'normal_button ') . $sec_class;
    $mouse_over_class = 'cssButtonHover ' . (($type == 'button') ? 'normal_button ' : '') . $sec_class . $sec_class . 'Hover';

to:

    $mouse_out_class  = 'cssButton ' . (($type == 'submit') ? 'submit_button button ' : 'normal_button button ') . $sec_class;
    $mouse_over_class = 'cssButtonHover ' . (($type == 'button') ? 'normal_button button ' : '') . $sec_class . $sec_class . 'Hover';

Here is a before and after pic

before applying update:

Attachment 15844

after applying update:

Attachment 15845

5 Dec 2015, 8:10 PM
#2
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: November 2015 Security Patch html_output.php css styling conflict?

What version of ZC, and what other mods were/are installed?

5 Dec 2015, 8:12 PM
#3
marcopolo avatar

marcopolo

Totally Zenned

Join Date:
May 2008
Location:
United States
Posts:
516
Plugin Contributions:
2

Re: November 2015 Security Patch html_output.php css styling conflict?

Zencart 1.5.4 with many mods, too many to list.

5 Dec 2015, 8:17 PM
#4
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: November 2015 Security Patch html_output.php css styling conflict?

marcopolo:

Zencart 1.5.4 with many mods, too many to list.

Which of them modified html_output? As I recall from looking at the suggested replacement, the diff file and having read through several postings about the differences, none of them identified the above as a difference. That leads me to think that one of the other plugins made that change. Sorry for not doing an independent search at the moment, but I have limited resources to confirm or deny that the suggested/provided change(s) modified those lines from original.

5 Dec 2015, 8:19 PM
#5
marcopolo avatar

marcopolo

Totally Zenned

Join Date:
May 2008
Location:
United States
Posts:
516
Plugin Contributions:
2

Re: November 2015 Security Patch html_output.php css styling conflict?

None of the mods modified the html_output file, the only change to that file was the security patch edits.

5 Dec 2015, 8:27 PM
#6
marcopolo avatar

marcopolo

Totally Zenned

Join Date:
May 2008
Location:
United States
Posts:
516
Plugin Contributions:
2

Re: November 2015 Security Patch html_output.php css styling conflict?

I doubled checked and did a compare of my file before applying patch to a fresh copy of the file and mine was modified, must have been done from the template I'm using because I log all changes to files and did not make the change. I can now see the changes the patch needs to make, thanks.

5 Dec 2015, 8:29 PM
#7
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: November 2015 Security Patch html_output.php css styling conflict?

Well, just pulled some magic but those lines in the ZC 1.5.4 and curently downloadable version of html_output are the same... And both match what is provided above as the changed to part... If you want them now differently sized, could either revert those lines of code or better could modify the css applicable for the effect(s).