[Closed] FEEDBACK ON BETA of v1.5.5

charmedbytina2:

I re-ordered the tpl_product_info_display.php and the right sideboxes drop to the footer area and move to the left.

You can see it here

I also want to add a background image and it will not appear when background coding is added to the stylesheetin the "body" area.

The background image is working. If you want it to show you would need to remove the background color from the #headerWrapper and #mainWrapper.

There is a bug in the tpl_header.php file and I just submitted a fix for it ;)

Thanks,

Anne

picaflor-azul:

The background image is working. If you want it to show you would need to remove the background color from the #headerWrapper and #mainWrapper.

There is a bug in the tpl_header.php file and I just submitted a fix for it ;)

Thanks,

Anne

Anne,

Thanks! I'll look for the updated file and try the background image again.

charmedbytina2:

On the right side, I have Search and Product Notifications

zip file attachedAttachment #15885

If I compare your file to the original there appears to be a lot of extra </div> in it and if I remove those it seems to fix it ...

Ajeh:

If I compare your file to the original there appears to be a lot of extra </div> in it and if I remove those it seems to fix it ...

Ok - I'll try that! Thanks

charmedbytina2:

Ok - I'll try that! Thanks

There was a misplaced </div> in the tpl_header.php file. You can see the new zip file for the correction.

You may also have mismatched tags in your page that will cause problems. The easiest way to find any errors is to run the page through the w3c html validator ;)

Thanks,

Anne

picaflor-azul:

The easiest way to find any errors is to run the page through the w3c html validator
They all appear to be template errors not associated with ZenCart coding

https://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fcrazycatlady.site%2Findex.php%3Fmain_page%3Dproduct_info%26cPath%3D1%26products_id%3D1&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en#errors

Thanks for the input. I've implemented the suggestions by Ajeh and Anne. Looking better!

Now, I have a new error. Product Listings are not displaying in the same format.

Look at the attached pages.

First Product

Second Product

lat9:

Fresh install, using zip-file created at approximately 10am EST.

System Setup step. Need to determine whether you're going to use the US or UK spelling of license/licence:

License
Agree to licence terms:
(Check the box to agree to GPL 2 licence terms. Click the title in the left column to view the license.)

> **lat9:**
>
> zc_install, Step: Database Setup.
> 
> Click on the link entitled Database Tablename Prefix.  The help text reads:
> ```
What is the prefix you would like used for database tables? Example: 'zen_' TIP: Leave empty if no prefix is needed.
You can use prefixes to allow more than one store to share the same database.

My thought is that some more literally-inclined people are going to include the single-quotes because the example text contained them:

'zen_'

> Perhaps use either bold or italic to emphasize the **zen_**, moving the "TIP" to the next line?
Verified that these are corrected in the zip-file just created/downloaded.

charmedbytina2:

Thanks for the input. I've implemented the suggestions by Ajeh and Anne. Looking better!

Now, I have a new error. Product Listings are not displaying in the same format.

Look at the attached pages.

First Product

Second Product

If you want the image and description to be centered you need to check the css and html. For example, right now, there is a float:left; on the #productMainImage. In the html there is also a class "forward" which will float right if not removed.

Don't forget that with a responsive design, any changes you make on a desktop may effect the tablet and mobile layout. Be sure to check your changes on various devices and orientations as you go along.

Thanks,

Anne

Just noticed this: In admin - tools - developer tools.

I did a search and the results returned look a little wonky. See image attached.

charmedbytina2:

Just noticed this: In admin - tools - developer tools.

I did a search and the results returned look a little wonky. See image attached.

Yes, that's another side-effect of the change to use either <pre> or <code> to format the results, as I'd mentioned here.

lat9:

Yes, that's another side-effect of the change to use either <pre> or <code> to format the results, as I'd mentioned here.

Derh! Maybe it's too early for "eggnog"? I guess I should have looked at this thread a little closer - apologies!

charmedbytina2:

Derh! Maybe it's too early for "eggnog"? I guess I should have looked at this thread a little closer - apologies!
It's never too early for eggnog! Your posting included the jagged output display (which I was too lazy to include), so it's all good.

The file /admin/customers.php has been changed from the ZC1.5.4 base, but the header comments still reflect last-changed in v1.5.4.

lat9:

Admin, Tools->Developers Tool Kit. It looks like either the CSS or layout was changed so that a mono-type font is now used for the display:

It's quite ugly (IMO) now and very difficult to read. Can this be changed back?

P.S. I ***do ***like the new highlighting of the searched-for term!

charmedbytina2:

Just noticed this: In admin - tools - developer tools.

I did a search and the results returned look a little wonky. See image attached.

FWIW, I changed the file /admin/includes/developers_tool_kit.css, removing the lines highlighted to restore the display to a non-monospaced font:

/*
 * @package Admin 
 * @copyright Copyright 2003-2015 Zen Cart Development Team
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: Author: DrByte  Modified in v1.6.0 $
 */

.dtk-highlite {font-weight: bold; color: rgb(255, 10, 5);}
[B].dtk-foundline, .dtk-foundline-multi {font-family: courier;}[/B]
.dtk-foundline-multi {background-color: rgba(4, 211, 216, 0.12);}
[B].dtk-contextline {font-family: courier;}
.dtk-linenum {font-family: courier;}[/B]

/*
 * @package Admin 
 * @copyright Copyright 2003-2015 Zen Cart Development Team
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: Author: DrByte  Modified in v1.6.0 $
 */

.dtk-highlite {font-weight: bold; color: rgb(255, 10, 5);}
[B].dtk-foundline, .dtk-foundline-multi {font-family: courier;}[/B]
.dtk-foundline-multi {background-color: rgba(4, 211, 216, 0.12);}
[B].dtk-contextline {font-family: courier;}
.dtk-linenum {font-family: courier;}[/B]

You could just change those to Verdanda, sans-serif to cover 90% of the issue ...

That's, in essence, what the font falls back to with those lines removed!

is there any additional documentation on how to install and/or setup the responsive design stuff?

What are you trying to setup?

Changes made to sql statements in includes/functions/functions_lookups did not use $db->bindVars(

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = " . (int) $products_id;

  global $db;
  return ($db->Execute($query)->RecordCount() > 0);
}

Could/should be:

function zen_has_product_attributes_downloads_status($products_id) {
  if (!defined('DOWNLOAD_ENABLED') || DOWNLOAD_ENABLED != 'true') {
    return false;
  }

  $query = "select pad.products_attributes_id
              from " . TABLE_PRODUCTS_ATTRIBUTES . " pa
              inner join " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . " pad
              on pad.products_attributes_id = pa.products_attributes_id
              where pa.products_id = :products_id:";

  global $db;
  $query = $db->bindvars($query, ':products_id:', $products_id, 'integer');
  return ($db->Execute($query)->RecordCount() > 0);
}