If this is your first visit, check our documentation. To post, register or login.
Forums / Zen Cart Code Suggestions / suggestion for includes/modules/meta_tags.php

suggestion for includes/modules/meta_tags.php

Started by carlwhat on 15 Apr 2016, 3:36 PM · Views: 48

Results 1 to 3 of 3
15 Apr 2016, 3:36 PM
#1
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,974
Plugin Contributions:
8

suggestion for includes/modules/meta_tags.php

hi,
i looked at the giuthub code for v160, and not sure if i should post an issue there or here, so i'm going with here. if i should i should do it over there, please let me know.

in the above mentioned script, there are frequent occurrences of:

str_replace('"','',

in my experience, i have found that the * character was causing issues with my meta tags. so i declared an array at the beginning of the script and modified the "many" instance of the str_replace:

$bad_characters = array('"','*');

str_replace($bad_characters,'',

while i am unsure how many other people have had problems with meta tag data, it would be nice to only have define once what characters need to get removed from their meta_tags.

best.

author of square Webpay, now with Apple Pay and Google Pay.
mXworks
donations: venmo or paypal accepted.
premium consistent excellent support. available for hire.

15 Apr 2016, 4:26 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,512
Plugin Contributions:
176

Re: suggestion for includes/modules/meta_tags.php

I like the suggestion.

We plan to merge the v155 updates into the v160 branch in the next week. After that it would be ideal for you to do a PR with your suggested changes.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

15 Apr 2016, 4:38 PM
#3
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,974
Plugin Contributions:
8

Re: suggestion for includes/modules/meta_tags.php

i am more of a bitbucket guy than github...

still trying to figure github out but i will give it a whirl!

thanks.

author of square Webpay, now with Apple Pay and Google Pay.
mXworks
donations: venmo or paypal accepted.
premium consistent excellent support. available for hire.