Forums / General Questions / METATAGS_DIVIDER - is there a issue on PHP Version: 5.6.15 (Zend: 2.6.0) ?

METATAGS_DIVIDER - is there a issue on PHP Version: 5.6.15 (Zend: 2.6.0) ?

Started by mesnitu on 16 Jul 2016, 12:59 PM · Views: 740

Results 1 to 5 of 5
16 Jul 2016, 12:59 PM
#1
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

METATAGS_DIVIDER - is there a issue on PHP Version: 5.6.15 (Zend: 2.6.0) ?

This is not working for me at modules/meta_tags.php

if (!defined('METATAGS_DIVIDER')) define('METATAGS_DIVIDER', ', ');

No comma is added to the keywords . Only way I can do this is to replace the METATAGS_DIVIDER with ', ' at :

while (!$keywords_metatags->EOF) {
$keywords_string_metatags .= zen_clean_html($keywords_metatags->fields['categories_name']) .', ';
$keywords_metatags->MoveNext();
}

Not sure is this is related to the php version... and in fact I can live quite well changing this, but just for curiosity .... I wonder

Tahnks.

“Though the problems of the world are increasingly complex, the solutions remain embarrassingly simple.” ― Bill Mollison

16 Jul 2016, 1:08 PM
#2
lat9 avatar

lat9

Administrator

Join Date:
Sep 2009
Location:
Stuart, FL
Posts:
14,139
Plugin Contributions:
56

Re: METATAGS_DIVIDER - is there a issue on PHP Version: 5.6.15 (Zend: 2.6.0) ?

That's because the constant META_TAGS_DIVIDER has already been defined ... by the previous loading of /includes/languages/english{/YOUR_TEMPLATE}/meta_tags.php.

16 Jul 2016, 1:37 PM
#3
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: METATAGS_DIVIDER - is there a issue on PHP Version: 5.6.15 (Zend: 2.6.0) ?

Thanks
If check both files, the default languages/LANG/meta_tags and the "overwritten" file, and both of them the
define('METATAGS_DIVIDER', ' ');

is just a space.

the define('TERTIARY_SECTION', ', '); is a comma.
So I guess I have to change the keywords separator to this one.

Thanks

“Though the problems of the world are increasingly complex, the solutions remain embarrassingly simple.” ― Bill Mollison

16 Jul 2016, 4:22 PM
#4
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: METATAGS_DIVIDER - is there a issue on PHP Version: 5.6.15 (Zend: 2.6.0) ?

mesnitu:

Thanks
If check both files, the default languages/LANG/meta_tags and the "overwritten" file, and both of them the
define('METATAGS_DIVIDER', ' ');

is just a space.

the define('TERTIARY_SECTION', ', '); is a comma.
So I guess I have to change the keywords separator to this one.

Thanks

mesnitu, I know you like to do some things the hard way, but if you change the divider from META_TAGS_DIVIDER to TERTIARY_SECTION then when you later decide to change the value of TERTIARY_SECTION because it is not what you want, you will find (if you look) that now your original problem (using a space instead of a comma) is now a new problem and using whatever TERTIARY_SECTION was changed to...

META_TAGS_DIVIDER as just pointed out is first defined in the language files and then made sure to be defined in the current module file so that at least everything doesn't get squished together.

It would be advisable instead to just define METATAGS_DIVIDER in the applicable language(s) and template override(s) to fit your needs..

ZC Installation/Maintenance Support <- Site
Contribution for contributions welcome...

16 Jul 2016, 4:37 PM
#5
mesnitu avatar

mesnitu

Totally Zenned

Join Date:
Aug 2014
Location:
Lisbon
Posts:
597
Plugin Contributions:
0

Re: METATAGS_DIVIDER - is there a issue on PHP Version: 5.6.15 (Zend: 2.6.0) ?

mc12345678:

mesnitu, I know you like to do some things the hard way

:D Yeap, the story of my life !

ok, thanks for the advice. I've never even notice that the META_TAGS_DIVIDER was define to be a empty space. Makes no sense to me to be use for a keyword divider.
Got to check all this. All I need it's commas in the keywords.
But now it's very hot, and my brain hurts as monthy python said.

Thanks

“Though the problems of the world are increasingly complex, the solutions remain embarrassingly simple.” ― Bill Mollison