Forums / Bug Reports / [Done v155b] Fax number on tpl_account_edit_default.php

[Done v155b] Fax number on tpl_account_edit_default.php

Views: 864

Results 1 to 2 of 2
4 Oct 2016, 8:58 AM
#1
istilah avatar

istilah

New Zenner

Join Date:
Jan 2006
Location:
Netherlands
Posts:
48
Plugin Contributions:
0

[Done v155b] Fax number on tpl_account_edit_default.php

small remark:
even if the setting in admin->customer details-> fax, have been set to false, the faxnumber is still visible on the account_edit page.

I would suggest changing the code from template_default/ tpl_account_edit_default.php

from:

<label class="inputLabel" for="fax"><?php echo ENTRY_FAX_NUMBER; ?></label>

<?php echo zen_draw_input_field('fax', $account->fields['customers_fax'], 'id="fax" placeholder="' . ENTRY_FAX_NUMBER_TEXT . '"', 'tel'); ?> <br class="clearBoth" />

to:

<?php if (ACCOUNT_FAX_NUMBER == 'true' ) { ?>

<label class="inputLabel" for="fax"><?php echo ENTRY_FAX_NUMBER; ?></label>

<?php echo zen_draw_input_field('fax', $account->fields['customers_fax'], 'id="fax" placeholder="' . ENTRY_FAX_NUMBER_TEXT . '"', 'tel'); ?> <br class="clearBoth" /> <?php } ?>

I wonder if anybody is still using faxes, in my humble opinion it is quite obsolete. Maybe get rid of the fax number alltogether in next versions?

Greeting
Ronald

12 Oct 2016, 12:36 AM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,515
Plugin Contributions:
176

Re: [Done v155b] Fax number on tpl_account_edit_default.php

Good points. Thanks for reporting this.

https://github.com/zencart/zencart/pull/1311

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.