[Done v1.5.6] PHP Warning: A non-numeric value encountered... - PHP 7 warnings

mesnitu:

Thanks!!!
Less one problem !
The issue was on the modify file. It had this
$list_box_contents ='';

instead of this
$list_box_contents = array();

... don't know why, probably some update that I miss.
Now it ok !

Good. Yes, php is becoming more stringent about properly identifying how a variable is intended to be used and basically validating that the data is the type expected to use as well as other improvements in the language.

[13-Jan-2018 18:24:07 Europe/Lisbon] PHP Warning:  A non-numeric value encountered in /home/xxxxxx/public_html/includes/modules/pages/advanced_search_result/header_php.php on line 370

The code:

$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
  $pfrom = $_GET['pfrom'] / $rate;
  $pto = $_GET['pto'] / $rate;
}

I did check on git to see if there were updates on this , but I see no changes.
Should I use a float($rate) ?

Thanks

mesnitu:

[13-Jan-2018 18:24:07 Europe/Lisbon] PHP Warning: A non-numeric value encountered in /home/xxxxxx/public_html/includes/modules/pages/advanced_search_result/header_php.php on line 370

> 
> The code: 
> ```php
$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
  $pfrom = $_GET['pfrom'] / $rate;
  $pto = $_GET['pto'] / $rate;
}

I did check on git to see if there were updates on this , but I see no changes.
Should I use a float($rate) ?

Thanks
Nope, the issue there is that the pfrom/pto values, if not set in the form, come back as '' (a non-numeric value). Try the following instead:

$rate = $currencies->get_value($_SESSION['currency']);
if ($rate) {
  $pfrom = ((float)$_GET['pfrom']) / $rate;
  $pto = ((float)$_GET['pto']) / $rate;
}

Thanks, I'll try that

torvista:

Line 50 is pretty meaty so I'll leave this for those who seem to enjoy these challenges.......

$format_string = $this->currencies[$currency_type]['symbol_left'] . number_format(zen_round($number * $rate, $this->currencies[$currency_type]['decimal_places']), $this->currencies[$currency_type]['decimal_places'], $this->currencies[$currency_type]['decimal_point'], $this->currencies[$currency_type]['thousands_point']) . $this->currencies[$currency_type]['symbol_right'];

I added 

   if (!is_numeric($number)) $number = 0;

at line 46 in includes/classes/currencies.php

I added

if (!is_numeric($number)) $number = 0;

at line 46.

....in classes/currencies.php, to clarify.

Seen this a couple of times:

[29-May-2018 07:16:10 America/Los_Angeles] PHP Warning: Creating default object from empty value in admin/product.php on line 224

Fix is pretty straightforward - above line 224 in admin/product.php add

      if (!is_object($pInfo)) $pInfo = new StdClass();

I am having the same error
PHP Warning: A non-numeric value encountered in ..../public_html/includes/classes/categories_ul_generator.php on line 73

Line 73 is
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '');
Coming from the block code
if (($this->data[$category_id]) && (($this->max_level == '0') || ($this->max_level > $level+1))) {
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '');
}
$result .= $this->child_end_string;

What is the fix for this error?
zen cart 1.5.5f

TamyA:

I am having the same error
PHP Warning: A non-numeric value encountered in ..../public_html/includes/classes/categories_ul_generator.php on line 73

Line 73 is
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '');
Coming from the block code
if (($this->data[$category_id]) && (($this->max_level == '0') || ($this->max_level > $level+1))) {
$result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '');
}
$result .= $this->child_end_string;

What is the fix for this error?
zen cart 1.5.5f
Change line 58 of the file from:

$level = $level;

To:

$level = (int)$level;

mc12345678:

Change line 58 of the file from:

$level = $level;

> To:
> ```
$level = (int)$level;

Sorry, more than likely will need to add the above at or around line 58 so that $level will be forced to be an integer. In newer php versions it is/will be possible to cast/expect the value to be an integer, but to maintain the existing backwards compatibility the above was the way chosen.

mc12345678:

Sorry, more than likely will need to add the above at or around line 58 so that $level will be forced to be an integer. In newer php versions it is/will be possible to cast/expect the value to be an integer, but to maintain the existing backwards compatibility the above was the way chosen.

Thanks a million, it seems to work, so far no error files in the /logs directory, thanks again.

Hi, buddies,

after upgrade of my shop to version 1.5.5f and upgrade of PHP to 7.1, I recieved PHP Warning with "a non numeric value encountered" for categories_ul_generator.php and thanks to your updates was able to resolve it fast.

However now I´m stuck,

I recieved the same PHP warning here:

[01-Nov-2018 00:33:02 UTC] Request URI: /index.php?main_page=shopping_cart, IP address: xxx
#1 zones->quote() called at [/home/xxx/public_html/includes/classes/shipping.php:171]
#2 shipping->quote() called at [/home/xxx/public_html/includes/modules/shipping_estimator.php:140]
#3 require(/home/xxx/public_html/includes/modules/shipping_estimator.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php:194]
#4 require(/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php:171]
#5 require(/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/home/xxx/public_html/index.php:97]

[01-Nov-2018 00:33:02 UTC] PHP Warning: A non-numeric value encountered in /home/xxx/public_html/includes/modules/shipping/zones.php on line 257

line 257 in zones.php looks like this:

$shipping_cost = ($shipping) + constant('MODULE_SHIPPING_ZONES_HANDLING_' . $dest_zone);

any help would be very much appreciated, guys

Doomm:

Hi, buddies,

after upgrade of my shop to version 1.5.5f and upgrade of PHP to 7.1, I recieved PHP Warning with "a non numeric value encountered" for categories_ul_generator.php and thanks to your updates was able to resolve it fast.

However now I´m stuck,

I recieved the same PHP warning here:

[01-Nov-2018 00:33:02 UTC] Request URI: /index.php?main_page=shopping_cart, IP address: xxx
#1 zones->quote() called at [/home/xxx/public_html/includes/classes/shipping.php:171]
#2 shipping->quote() called at [/home/xxx/public_html/includes/modules/shipping_estimator.php:140]
#3 require(/home/xxx/public_html/includes/modules/shipping_estimator.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php:194]
#4 require(/home/xxx/public_html/includes/templates/responsive_classic/templates/tpl_shopping_cart_default.php) called at [/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php:171]
#5 require(/home/xxx/public_html/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/home/xxx/public_html/index.php:97]

[01-Nov-2018 00:33:02 UTC] PHP Warning: A non-numeric value encountered in /home/xxx/public_html/includes/modules/shipping/zones.php on line 257

line 257 in zones.php looks like this:

$shipping_cost = ($shipping) + constant('MODULE_SHIPPING_ZONES_HANDLING_' . $dest_zone);

any help would be very much appreciated, guys
Looks like in your zones shipping module that for each applicable zone that a value needs to be entered instead of an empty string. So, if there is no handling fee, then a value of 0 should be entered instead of leaving it blank.

So if I understand it correctly, this should be done from the admin and there is no need to change of the code.

Thank you very much for your time and help.

Doomm:

So if I understand it correctly, this should be done from the admin and there is no need to change of the code.

Thank you very much for your time and help.
No need, but an improvement in the base code could be made to default to a 0 instead of empty, but typing in a value of 0 should resolve that warning.

mc12345678:

No need, but an improvement in the base code could be made to default to a 0 instead of empty, but typing in a value of 0 should resolve that warning.

I´m so sorry, I´m not following you (not really a coder, here) and I´m very grateful for your patience.

Could you please direct me where in this php file (zones.php), should I be looking for this empty string?

Editing the zc155f version of /includes/modules/shipping/zones.php, find:

// class constructor
    function __construct() {
      $this->code = 'zones';
      $this->title = MODULE_SHIPPING_ZONES_TEXT_TITLE;
      $this->description = MODULE_SHIPPING_ZONES_TEXT_DESCRIPTION;
      $this->sort_order = MODULE_SHIPPING_ZONES_SORT_ORDER;
      $this->icon = '';
      $this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;
      $this->tax_basis = MODULE_SHIPPING_ZONES_TAX_BASIS;

and add the highlighted fragments:

// class constructor
    function __construct() {
      $this->code = 'zones';
      $this->title = MODULE_SHIPPING_ZONES_TEXT_TITLE;
      $this->description = MODULE_SHIPPING_ZONES_TEXT_DESCRIPTION;
      $this->sort_order = [B](int)[/B]MODULE_SHIPPING_ZONES_SORT_ORDER;
      $this->icon = '';
      $this->tax_class = [B](int)[/B]MODULE_SHIPPING_ZONES_TAX_CLASS;
      $this->tax_basis = MODULE_SHIPPING_ZONES_TAX_BASIS;

Note that I've also applied that integer "cast" to the tax-class-id, just in case!

Doomm:

I´m so sorry, I´m not following you (not really a coder, here) and I´m very grateful for your patience.

Could you please direct me where in this php file (zones.php), should I be looking for this empty string?
To address the specific warning message that was presented, the only thing necessary was to enter in a number into the handling fee area for each of the zones and not leave it blank. This entry is performed from admin->modules->shipping->zones.

It appears the code already contains a default value of '0' at least when first installing the additional zone(s).

mc12345678:

To address the specific warning message that was presented, the only thing necessary was to enter in a number into the handling fee area for each of the zones and not leave it blank. This entry is performed from admin->modules->shipping->zones.

It appears the code already contains a default value of '0' at least when first installing the additional zone(s).

Great, that´s what I did in the first place, but was not sure, if it´s enough.

Thank you very much for your help and understanding,

cheers