Official Sagepay Integration - PHP Warning: Illegal string offset 'id'

ZC version 1.54 PHP Version 5.6.31 Official Sagepay Integration - Version: 1.0

Logging the following PHP warning

[12-Aug-2017 06:37:20 Europe/London] PHP Warning: Illegal string offset 'id' in /var/www/vhosts/laptopstands.co.uk/heightadjustabledesks.solutions/includes/modules/payment/sagepay_zc/sagepay_zc_payment.php on line 85

Line 85 starts $sql =

Googling the warning infers it is something introduced in PHP 5.4 and to do with strings that should be arrays, don't really know myself, is there a solution to this please.

    public function update_status()
    {
        global $order, $db;
        if ($this->enabled == false || (int)$this->getModuleDefineValue('_ZONE') == 0) {
            return;
        }
        $check_flag = false;
        $sql = "SELECT zone_id FROM " . TABLE_ZONES_TO_GEO_ZONES . " WHERE geo_zone_id = '" . (int)$this->getModuleDefineValue('_ZONE') . "' AND zone_country_id = '" . (int)$order->billing['country']['id'] . "' ORDER BY zone_id";
        $checks = $db->Execute($sql);
        foreach ($checks as $check) {
            if ($check['zone_id'] < 1) {
                $check_flag = true;
                break;
            } elseif ($check['zone_id'] == $order->billing['zone_id']) {
                $check_flag = true;
                break;
            }
        }
        if ($check_flag == false) {
            $this->enabled = false;
        }
    }

Given the code you posted, an error like that should only occur if there's no "order", or the order has no "country" assigned to the "billing address".
But if you're in the middle of checkout, that shouldn't ever be the case.

When exactly is the error happening?
What plugins do you have installed to your site? (especially any that alter the default checkout flow)

Orders are fully processed without a problem, only have one zone, United Kingdom on freeshiper. Going through the process there is no warning until the order is viewed from the admin panel.

Freeshiper goes to an orange status if the United Kingdom is set up as the zone so its left as no zone. That may be the issue, I will have to have a look.

I think that the reason for this warning is that in the table zones to geo zones the zone id is null.

Can someone tell me please how this field should get populated with a zone id and if the field is not populated with a zone id would it be the reason for the warning.

mikemc24:

I think that the reason for this warning is that in the table zones to geo zones the zone id is null.

Can someone tell me please how this field should get populated with a zone id and if the field is not populated with a zone id would it be the reason for the warning.
No. As I look at it, there might be a bug in the module.

In your SagePay module settings, what's your Payment Zone set to? Have you left it at --none-- so that it applies to everyone? Or have you set it to something else, in order to restrict its use to people in certain countries only? I suspect you've changed it from "--none--" to something else. Does changing it to --none-- solve the problem?

Yes, changing the payment zone from United Kingdom to none resolves the issue of the PHP warning and as we only ship to UK there is no impact, thank you.

mikemc24:

Yes, changing the payment zone from United Kingdom to none resolves the issue of the PHP warning and as we only ship to UK there is no impact, thank you.
Thanks for reporting back.

We'll look into addressing what appears to be a bug that triggers the error you mentioned, only under the specific circumstance.