Forums / Bug Reports / Important Links (EZ Pages) in mobile view from hamburger menu

Important Links (EZ Pages) in mobile view from hamburger menu

Views: 4,839

Results 1 to 11 of 11
8 Jan 2018, 1:09 AM
#1
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,720
Plugin Contributions:
56

Important Links (EZ Pages) in mobile view from hamburger menu

includes/templates/responsive_classic/templates/tpl_modules_mobile_menu.php line 128 in 1.5.5e or 1.5.5f does

include(DIR_WS_MODULES . zen_get_module_directory('ezpages_bar_header.php'));

I believe this is an error and that the code should read

include(DIR_WS_MODULES . zen_get_module_directory('ezpages.php'));

That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.

8 Jan 2018, 1:32 AM
#2
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,970
Plugin Contributions:
8

Re: Important Links (EZ Pages) in mobile view from hamburger menu

@swguy...

i do not think so.... what makes you think that is wrong?

i'm running earlier versions of 1.5.5 and i see all code refer to what you think is wrong.

best.

author of square Webpay, now with Apple Pay and Google Pay.
mXworks
donations: venmo or paypal accepted.
premium consistent excellent support. available for hire.

8 Jan 2018, 1:41 AM
#3
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,720
Plugin Contributions:
56

Re: Important Links (EZ Pages) in mobile view from hamburger menu

You're replicating sidebox functionality here in a mobile environment. Why would you not use the code that builds the sidebox list of ezpages?

OTOH, who knows, maybe what you really want is a new module that selects for

select * from " . TABLE_EZPAGES . " where 
(status_sidebox = 1 and sidebox_sort_order > 0) OR 
(status_header = 1 and header_sort_order > 0) OR 
(status_footer = 1 and footer_sort_order > 0)

... but then the ordering would be complicated. Not sure what the best option is.

That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.

8 Jan 2018, 1:57 AM
#4
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,970
Plugin Contributions:
8

Re: Important Links (EZ Pages) in mobile view from hamburger menu

@swguy, i'm still not convinced....

the code is:

<?php
  include(DIR_WS_MODULES . zen_get_module_directory('ezpages_bar_header.php'));
  if (sizeof($var_linksList) >= 1) {
    for ($i=1, $n=sizeof($var_linksList); $i<=$n; $i++) {
      echo '<li><a href="' . $var_linksList[$i]['link'] . '">' . $var_linksList[$i]['name'] . '</a></li>' . "\n";
    }
  }
?>

the line that you think is wrong, just does an include of a script. that script is located here:

https://github.com/zencart/zencart/blob/v155/includes/modules/ezpages_bar_header.php

and it looks like the reason for the script is to create the variable:

$var_linksList

which is the subject of the next if statement listed above.

your line would do something completely different as it would include the sideboxes module. and i'm not sure that is what is intended.

i could be wrong....

author of square Webpay, now with Apple Pay and Google Pay.
mXworks
donations: venmo or paypal accepted.
premium consistent excellent support. available for hire.

18 Aug 2019, 6:40 PM
#5
stellarweb avatar

stellarweb

Zen Follower

Join Date:
May 2006
Location:
Montana
Posts:
293
Plugin Contributions:
8

Re: Important Links (EZ Pages) in mobile view from hamburger menu

I know this is an old thread but thought it might be helpful to others to know in case they find this thread like I did searching for a solution.

I noticed my EZ pages were not showing up in a 1.5.6C site I just upgraded, and once I applied the code Scott provided below, I was able to see them.

Hope this helps someone. Thanks Scott for the info! Worked great!

swguy:

includes/templates/responsive_classic/templates/tpl_modules_mobile_menu.php line 128 in 1.5.5e or 1.5.5f does

include(DIR_WS_MODULES . zen_get_module_directory('ezpages_bar_header.php'));

> 
> I believe this is an error and that the code should read 
> 
> ```
include(DIR_WS_MODULES . zen_get_module_directory('ezpages.php'));
30 Mar 2020, 1:07 AM
#6
jasonshanks avatar

jasonshanks

Zen Follower

Join Date:
Feb 2009
Location:
atlanta GA
Posts:
297
Plugin Contributions:
0

Re: Important Links (EZ Pages) in mobile view from hamburger menu

stellarweb:

I know this is an old thread but thought it might be helpful to others to know in case they find this thread like I did searching for a solution.

I noticed my EZ pages were not showing up in a 1.5.6C site I just upgraded, and once I applied the code Scott provided below, I was able to see them.

Hope this helps someone. Thanks Scott for the info! Worked great!

This is old and i know its probably common knowledge at this point. But i just upgraded my test site from 1.5.5f to 1.5.6c and was just about to sign off on the real upgrade when i noticed that those links where not showing on mobile as well. Thank you so much for this. I was going through and undoing any changes i made to try to remove the home footer button in hopes to fix anything i might have messed up. Your post saved me so much time !

Zencart 1.5.6c PHP 7.2 Order Replacement AC Adapters and Power Cords Online https://www.missingcord.com

30 Mar 2020, 2:39 AM
#7
jasonshanks avatar

jasonshanks

Zen Follower

Join Date:
Feb 2009
Location:
atlanta GA
Posts:
297
Plugin Contributions:
0

Re: Important Links (EZ Pages) in mobile view from hamburger menu

And celebrated to soon i guess. I get my links showing in mobile under important links. But now I am getting mydebug errors for the

PHP Warning: include(): Failed opening 'includes/modules/ezpages.php' for inclusion (include_path='.:') in /domain.com/includes/templates/responsive_classic_v1/templates/tpl_modules_mobile_menu.php on line 128.

Zencart 1.5.6c PHP 7.2 Order Replacement AC Adapters and Power Cords Online https://www.missingcord.com

30 Mar 2020, 4:39 AM
#8
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,720
Plugin Contributions:
56

Re: Important Links (EZ Pages) in mobile view from hamburger menu

If you compare includes/templates/responsive_classic/templates/tpl_modules_mobile_menu.php in 1.5.6c to 1.5.5f, you'll notice this change was not included. :)

Not sure what I was thinking. includes/modules/ezpages.php is not even a core file.

That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.

30 Mar 2020, 6:44 AM
#9
jasonshanks avatar

jasonshanks

Zen Follower

Join Date:
Feb 2009
Location:
atlanta GA
Posts:
297
Plugin Contributions:
0

Re: Important Links (EZ Pages) in mobile view from hamburger menu

Hey , i appreciate you trying to help us mere mortals here. I deleted the test site because i got discouraged. I think I might try again later tonight. In any event Thank you , thank you. If not for people like you , non coders like me would have given up a long time ago.

Zencart 1.5.6c PHP 7.2 Order Replacement AC Adapters and Power Cords Online https://www.missingcord.com

6 Apr 2020, 2:37 PM
#10
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,720
Plugin Contributions:
56

Re: Important Links (EZ Pages) in mobile view from hamburger menu

There's a new post on this topic where I showed an alternative solution:
https://www.zen-cart.com/showthread.php?226553-EZPages-not-showing-in-mobile-using-responsive-classic-template

That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.

6 Apr 2020, 2:43 PM
#11
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,720
Plugin Contributions:
56

Re: Important Links (EZ Pages) in mobile view from hamburger menu

I think a more general fix for this issue would be to modify ezpages_bar_header.php to select pages on all three (header, sidebox, footer) settings OR visible, and let people customize from there if they have a division between pages shown in these various places.

That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.