Ceon URI Mapping V5.0

I had hoped to offload/not gain more imagined responsibility....I'd prefer if PRs went to the jsweb repository unless that gathers dust.

You're right; updated.

https://github.com/JSWebSteve/Ceon-URI-Mapping-V5.1.0 is the new Github repo. Thanks to both of you for your hard work.

neekfenwick:

@strelitzia Hi, are you a Ceon support rep, and is this the official Ceon URI Mapping repo, and can we issue Pull Requests? Or if not there, then where? The repo doesn't seem to be forked from anywhere, but also the files don't have much history so it seems to have been borrowed rather than formally developed. It would be nice to be able to feed useful code fixes back to the addon.

No, I'm not affiliated with Ceon in any way. I'm a long time developer for, and now owner of JSWeb. We had a long history of working with Conor many years ago.
The github repo is simply the last working version that is being used on client websites with it being updated as and when issues were identified.

I sent several support requests to Ceon.net when they released version 5.0, but never got any response, so started to fix issues myself. It appears there are several different developers applying fixes to v5.x, namely myself, @swguy, and @torvista.

I'm not sure if the current repo contains all those edits after the last PR's were made.

strelitzia:

No, I'm not affiliated with Ceon in any way. I'm a long time developer for, and now owner of JSWeb. We had a long history of working with Conor many years ago.
The github repo is simply the last working version that is being used on client websites with it being updated as and when issues were identified.

I sent several support requests to Ceon.net when they released version 5.0, but never got any response, so started to fix issues myself. It appears there are several different developers applying fixes to v5.x, namely myself, @swguy, and @torvista.

I'm not sure if the current repo contains all those edits after the last PR's were made.

OK many thanks. I had a few messages back and forth with Connor, when he was about to go into hospital. It seems we've resolved the issue I raised by a core Zen Cart change (the handling of 'id' as an int for ezpages) so UriMappingHandler didn't need to be changed, but I'll try to bear this in mind if anything else comes up in future. I've also had to fork two other small repos in my move to PHP 8 as the original owners became unresponsive, c'est la vie.

I have noticed that with 1.5.7, the category URL rewrite fields (checkbox for auto create and new URL) don't seem to appear when editing a category. The file

admin/includes/javascript/ceon_uri_mapping_javascript.php

doesn't seem to be pulled in the way it is for products. Creating the file admin/includes/javascript/categories_CEONUriMapping.php won't work because then add the product edit fields will appear. So I hardcoded inclusion of includes/javascript/ceon_uri_mapping_javascript.php in admin/categories.php.

Any thoughts @strelitzia ?

I have
ceon_uri_mapping_javascript.php
with the code.

then
categories_CEONUriMapping.php
product_CEONUriMapping.php

which both contain

<?php
include ("ceon_uri_mapping_javascript.php");

which is working for me.

I could have sworn I tried that and got unwanted fields, but you're right - that works like a charm.

... but it's not in @strelitzia's copy of the code.

hmm...PR'ed.
https://github.com/JSWebSteve/Ceon-URI-Mapping-V5.1.0/pull/6

torvista:

hmm...PR'ed.
https://github.com/JSWebSteve/Ceon-URI-Mapping-V5.1.0/pull/6

I've just tested my latest 1.5.8 install and the URI mapping field displays on category and produc edits, sot sure why that was missing from the repo Steve, but PR now merged.

How do you go about updating a UMM copy of Ceon? It's not clear to me that ceon.net is still operating.

I usually get a reply when I query something.

OK I'll try again.

swguy:

OK I'll try again.

Did you get a reply? I've never once had a response from them, even when using a non work related email address.

I've experienced issues with URI Mapping on ZC 1.5.8

EZ-pages rewrites don't work correctly. Although the correct url is applied to the link in the header, when clicked it simply reloads the admin page.

Tried again using a fresh install of 1.5.8 and URI 5.1.0 to ensure it wasn't caused by some other edits, but the same issue.

Can anyone else confirm this?

@swguy Are you aware of any changes in 1.5.8 that would impact on URI Mapping functionality?

That'll teach me to not read the thread fully. I see it was reported by neekfenwick a while ago on https://github.com/zencart/zencart/issues/5366 and a solution was provided by lat9.

strelitzia:

Did you get a reply? I've never once had a response from them, even when using a non work related email address.

No sir. Not a peep.

There is an XSS vulnerability in this. Patch below.

manufacturers_id one is definitely exploitable, other ones I added to be safe, not sure if they are sanitized elsewhere.

+++ new/includes/classes/class.CeonURIMappingHandler.php     2023-05-25 12:26:02.822504000 -0700
@@ -408,7 +408,7 @@
                // A product review's page needs the ID included as part of the canonical URI
                if (defined('FILENAME_PRODUCT_REVIEWS_INFO') && $main_page == FILENAME_PRODUCT_REVIEWS_INFO &&
                                isset($_GET['reviews_id'])) {
-                       $ceon_uri_mapping_canonical_uri .= '?reviews_id=' . $_GET['reviews_id'];
+                       $ceon_uri_mapping_canonical_uri .= '?reviews_id=' . (int)$_GET['reviews_id'];
                }
                if (isset($GLOBALS['zco_notifier'])) {
                        $GLOBALS['zco_notifier']->notify('CEON_CLASS_HANDLER_HANDLE_STATIC_URI_END', compact('mapping_info', 'uri_to_match'));
@@ -689,11 +689,13 @@
                                global $ceon_uri_mapping_canonical_uri;

                                $ceon_uri_mapping_canonical_uri = HTTP_SERVER . DIR_WS_CATALOG .
-                                       'index.php?main_page=index&manufacturers_id=' . $_GET['manufacturers_id'];
+                                       'index.php?main_page=index&manufacturers_id=' . (int)$_GET['manufacturers_id'];

                        } else if (isset($_GET['typefilter']) && $_GET['typefilter'] != '' &&
                                        isset($_GET[$_GET['typefilter'] . '_id']) && $_GET[$_GET['typefilter'] . '_id'] != '') {
                                global $ceon_uri_mapping_canonical_uri;
+
+                               $_GET['typefilter'] = htmlspecialchars($_GET['typefilter']);

                                $ceon_uri_mapping_canonical_uri = HTTP_SERVER . DIR_WS_CATALOG . 'index.php?main_page=index' .
                                        '&typefilter=' . $_GET['typefilter'] . '&' . $_GET['typefilter'] . '_id=' .

Would someone please PR to https://github.com/JSWebSteve/Ceon-URI-Mapping-V5.1.0

ok, done