Zen Cart Logo
Forums / Support Site Issues & Questions / Github button does not appear

Github button does not appear

Views: 195

Results 1 to 20 of 21
7 May 2020, 3:37 PM
#1
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Github button does not appear

when submitting a plugin, there is a question as to whether it is 5.3 safe. which i think is seriously outdated at this point. perhaps we need to know if it is 7.x safe? or something of that nature.

in addition, there is a missing gif here:

https://www.zen-cart.com/images/misc/paperclip.gif

that is associated with the 5.3 safe when viewing plugins.

best.

8 May 2020, 2:11 PM
#2
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

swguy:

The Zen Cart plugins area now allows you to enter the Github repo for your contribution, if you are storing it in Github. Just enter

<your github username>/<your repo name>

in the Github Repository field. As an example, Better Together has "scottcwilson/zen_cart_better_together" in the Github Repository field.

You can see an example of the "Github Repository" button here:

https://www.zen-cart.com/downloads.php?do=file&id=126

If you want to add a Github repo to an existing contribution that you support, just send your humble moderator a PM. :)

i do not see the github button on the plugin; either for the ups xml module you linked or for your better together module. what am i missing?

in addition, can we make ANY effort to improve the search on the forum. going to the plugins page and search for "better together" comes up as 9 or 10 down the list. to say, use google, ok.... i get it use google... but i'm already on the zen-cart site; and i KNOW it is possible to make plugin searching better than it is.

i await a "humble" response.

8 May 2020, 2:17 PM
#3
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,682
Plugin Contributions:
56

Re: Github button does not appear

The image below shows the Github button for the UPS contribution.

8 May 2020, 3:17 PM
#4
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

well, wonder how i missed that?? :huh:

i primarily use chrome. does not appear in chrome or firefox.

appears in both when go incognito/private browser.

some extension or plugin is blocking it from appearing. still trying to figure out what.

8 May 2020, 4:14 PM
#5
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

its a cookie from this forum. not sure which one. if i am logged in, i do not see the github button. if i logout, i see it.

not sure which cookie at this point.

does not look to be anything related to extensions or plugins as far as i can tell.

8 May 2020, 7:04 PM
#6
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

am i the only one where this is happening?

logged in; no github button; logged out github button appears.

thanks.

8 May 2020, 7:20 PM
#7
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,682
Plugin Contributions:
56

Re: Github button does not appear

I thought this might be your issue so I tested it before I responded. It works fine when you are not logged in.

8 May 2020, 7:25 PM
#8
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

my question is whether the button shows when you are logged in. it does not show for me when i am logged in.

when i am logged out, the button shows.

i have a feeling this is a server side issue, and not my issue. i would like to confirm or deny that before i dig deeper.

makes no sense to me that something on my browser side is stripping part of the DOM.

when i go incognito; i am logged out. button shows. when i login on my incognito window, the button disappears.

says to me server side issue.

8 May 2020, 7:43 PM
#9
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,682
Plugin Contributions:
56

Re: Github button does not appear

It shows for me whether I am logged in or not.

8 May 2020, 8:20 PM
#10
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

swguy:

It shows for me whether I am logged in or not.

how many different browsers have you tried?

i will boot up my apple and see what happens in safari. i have screwed around with the cookies to no avail.

perhaps i am the only person running linux on his desktop utilizing chrome or firefox where this behavior manifests itself. but i have a feeling this behavior is not limited to my environment. and i have a distinct feeling this is something on the vBulletin config as opposed to my browser. i could be wrong. i think others might report on it if they knew there was a github link there. but people have to know to look for it to report it not working. which is not the case in this situation unless people are actually looking at this thread.

8 May 2020, 9:08 PM
#11
barco57 avatar

barco57

Totally Zenned

Join Date:
Apr 2006
Location:
West Salem, IL
Posts:
2,841
Plugin Contributions:
0

Re: Github button does not appear

win 10/chrome/firefox I see the github repository button whether or not I am logged in

8 May 2020, 9:24 PM
#12
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

barco57:

win 10/chrome/firefox I see the github repository button whether or not I am logged in

thank you. i appreciate you looking.

the problem is with my settings. apparently in order to see the github button, one must use the Zen Cart skin with the vBulletin software. if one goes into their settings and selects the vB4 Default style, the button disappears.

Attachment 18979

vBulletin config. not sure why i am forced to use the zen cart skin.

8 May 2020, 11:04 PM
#13
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,682
Plugin Contributions:
56

Re: Github button does not appear

carlwhat:

in addition, can we make ANY effort to improve the search on the forum. going to the plugins page and search for "better together" comes up as 9 or 10 down the list. to say, use google, ok.... i get it use google... but i'm already on the zen-cart site; and i KNOW it is possible to make plugin searching better than it is.

It's best to stick to a single topic in a thread.

Please open a new thread in the Support Site forum on this question.

8 May 2020, 11:55 PM
#14
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: Github button does not appear

I'm using the 2017 template and able to see the button while logged in or not. Google Chrome 81.0.xxx, don't really want to try firefox these days because it seems to use a lot of resources.

9 May 2020, 12:33 AM
#15
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

mc12345678:

I'm using the 2017 template and able to see the button while logged in or not. Google Chrome 81.0.xxx, don't really want to try firefox these days because it seems to use a lot of resources.

the problem has been isolated to the selected skin being used by the user on this forum. it is NOT browser dependent, nor dependent on the user being logged in.

if the user uses the zen cart 2017 skin, there is no problem. if one chooses to use vB4 default style, the github button disappears.

this is clearly a problem with the configuration on the vBulletin software, forcing one to use the zen cart skin to see all of the functionality.

as to whether the admins of this forum choose to address this issue, i have not heard.

9 May 2020, 1:08 AM
#16
barco57 avatar

barco57

Totally Zenned

Join Date:
Apr 2006
Location:
West Salem, IL
Posts:
2,841
Plugin Contributions:
0

Re: Github button does not appear

you should probably point out that you are using the -vB default style when going to the add plugin page, the Zen Cart 2017 template doesn't ask that question anymore. Personally, it it were me I would turn off the "quick style chooser" and force the Zen Cart 2017 template, so they don't have to maintain two version of the zen cart sites template.

9 May 2020, 1:18 AM
#17
carlwhat avatar

carlwhat

zennedOut

Join Date:
Nov 2005
Location:
los angeles
Posts:
2,953
Plugin Contributions:
8

Re: Github button does not appear

barco57:

you should probably point out that you are using the -vB default style when going to the add plugin page, the Zen Cart 2017 template doesn't ask that question anymore. Personally, it it were me I would turn off the "quick style chooser" and force the Zen Cart 2017 template, so they don't have to maintain two version of the zen cart sites template.

great catch on that!

thanks.

9 May 2020, 4:42 PM
#18
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
177

Re: Github button does not appear

Why are you not using the Zen Cart skin?

9 May 2020, 6:17 PM
#19
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,682
Plugin Contributions:
56

Re: Github button does not appear

@barco57's suggestion is excellent - an easy path forward.

10 May 2020, 1:21 PM
#20
mc12345678 avatar

mc12345678

Totally Zenned

Join Date:
Jul 2012
Posts:
16,908
Plugin Contributions:
2

Re: Github button does not appear

swguy:

@barco57's suggestion is excellent - an easy path forward.
If so, please incorporate the contact us option that is in the default vb default template that is not in the 2017 template... don't know what "filtering" is on the back side, but when I have wanted to provide some sort of report to whatever distribution list is generated there, I've swapped over to that template to provide such reporting. Also, there are times when the template's css doesn't load and resetting the browser to force loading the updated files can be a pain. Result is that either I use the alternate template for a period of time or live without being able to readily see the content in a easy method.

Also, what would happen with the mobile template if the selection is removed? I mean, I don't like it much because it has so little information in it and things are arranged (as is becoming usual for mobile templates) to be either hard to get to, or limited in display. But I assume it is still being used and further I've seen it as a default on a mobile device where no previous selection has been made...