Zen Cart Logo
Forums / Bug Reports / OT coupon code tax error of excluded products

OT coupon code tax error of excluded products

Views: 1,755

Results 1 to 3 of 3
17 Jun 2020, 19:56
#1
calljj avatar

calljj

Zen Follower

Join Date:
Mar 2007
Posts:
253
Plugin Contributions:
2

OT coupon code tax error of excluded products

in the includes/modules/order_total/ot_coupon.php the tax amount of an excluded product is removed twice from the total price resulting in unexpected amount showing as part of the order total.

approx line 620 gives:

        if ($this->include_tax == 'true') {
         $orderTotal -= $productsTaxAmount;
        }
        if (DISPLAY_PRICE_WITH_TAX == 'true')
        {
          $orderTotal -= $productsTaxAmount;
        }

resolution appears to be chnging if to include 'or' or simply removing second 'if' statement

17 Jun 2020, 21:42
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
177

Re: OT coupon code tax error of excluded products

Yes an "or" probably makes sense.

30 Jun 2023, 09:58
#3
swguy avatar

swguy

Administrator

Join Date:
Feb 2006
Location:
Tampa Bay, Florida
Posts:
10,682
Plugin Contributions:
56

Re: OT coupon code tax error of excluded products

If anyone would like to build a PR, that would be great.

https://github.com/zencart/zencart/issues/3612