OSH_EMAIL_TEXT_COMMENTS_UPDATE error/warning message

just upgraded to 1.5.7d php 7.4.30 - may be changing that to 8 if client chooses to install square.

09-Jul-2022 00:04:15 UTC] Request URI: /index.php?main_page=checkout_process, IP address: 99.96.214.168
#1 zen_update_orders_history() called at [/includes/modules/payment/paypalwpp.php:501]
#2 paypalwpp->after_process() called at [/includes/classes/payment.php:261]
#3 payment->after_process() called at [/includes/modules/pages/checkout_process/header_php.php:17]
#4 require(/includes/modules/pages/checkout_process/header_php.php) called at [/index.php:35]
--> PHP Warning: Use of undefined constant OSH_EMAIL_TEXT_COMMENTS_UPDATE - assumed 'OSH_EMAIL_TEXT_COMMENTS_UPDATE' (this will throw an Error in a future version of PHP) in /includes/functions/functions_osh_update.php on line 79.

Since these are default files for 1.5.7d (I eyeballed all referred above to make sure), why is this happening? I don't see how something like this could have been missed.

In a fresh 1.5.7d, that should be defined in includes/languages/english/extra_definitions/orders_status_updates.php and YOUR_ADMIN/includes/languages/english/extra_definitions/orders_status_updates.php

FYI Square WebPay works fine 1.5.6 thru 1..5.7d with PHP 7.4

okay but that file is also 1.5.7d. but the error log talks about checkout - not admin.

And the new square module to combat square changes this month I heard did require php 8. Since I don't see a new version in plugins, I can't prove that but the old one is supposed to stop working this month.

Since I don't see a new version in plugins ...

https://www.zen-cart.com/downloads.php?do=file&id=2345

https://docs.zen-cart.com/user/payment/square/

delia:

okay but that file is also 1.5.7d. but the error log talks about checkout - not admin.

And the new square module to combat square changes this month I heard did require php 8. Since I don't see a new version in plugins, I can't prove that but the old one is supposed to stop working this month.did I read your post incorrectly that you had just upgraded to 1.5.7d?

And, there are two links there.

And, I was one of the testers for Square WebPay and it worked on 1.5.6 and up with PHP 7.4 from the start. Even 7.3.3

Thanks, Scott. I searched for just square and only the old one showed up. That’s good news!

But the original problem still stands and that error message hints that it happens during checkout.

and you haven't said if the file exists and matches the default:P

Not knowing anything other than 1.5.7d and 7.4 leaves an awful lot of reasons for things to go bump in the night.:smile:

delia:

just upgraded to 1.5.7d php 7.4.30 - may be changing that to 8 if client chooses to install square.

09-Jul-2022 00:04:15 UTC] Request URI: /index.php?main_page=checkout_process, IP address: 99.96.214.168
#1 zen_update_orders_history() called at [/includes/modules/payment/paypalwpp.php:501]
#2 paypalwpp->after_process() called at [/includes/classes/payment.php:261]
#3 payment->after_process() called at [/includes/modules/pages/checkout_process/header_php.php:17]
#4 require(/includes/modules/pages/checkout_process/header_php.php) called at [/index.php:35]
--> PHP Warning: Use of undefined constant OSH_EMAIL_TEXT_COMMENTS_UPDATE - assumed 'OSH_EMAIL_TEXT_COMMENTS_UPDATE' (this will throw an Error in a future version of PHP) in /includes/functions/functions_osh_update.php on line 79.

Since these are default files for 1.5.7d (I eyeballed all referred above to make sure), why is this happening? I don't see how something like this could have been missed.

dbltoe:

In a fresh 1.5.7d, that should be defined in includes/languages/english/extra_definitions/orders_status_updates.php and YOUR_ADMIN/includes/languages/english/extra_definitions/orders_status_updates.php

FYI Square WebPay works fine 1.5.6 thru 1..5.7d with PHP 7.4
@delia, you should check the site's two /extra_definitions (storefront and admin) language sub-directories, as @dbltoe suggested. It sounds like you're missing those two files.
delia:

okay but that file is also 1.5.7d. but the error log talks about checkout - not admin.

And the new square module to combat square changes this month I heard did require php 8. Since I don't see a new version in plugins, I can't prove that but the old one is supposed to stop working this month.

ah, there it is - missing in action on the catalog side! I think I do know how that happened! Thanks so much.

:hug:

Glad you got it working.