TaxJar Issue - Composer Related?

:thumbsup:

@chuckPhillips, i would suggest updating the plugin if you are still maintaining it. i believe those countable warnings in php 7.x turn into fatal errors in php 8.x.

best.

I'm seeing transaction in taxjar interface, so I guess everything going ok.

Didn't realize transactions wouldn't populate there until marked as shipped.

No php warnings since changes.

ATM the only thing I'm not understanding is how to remove transactions from taxjar (test transactions).

I marked transaction as pending in zen.

Then I clicked the Delete From Taxjar button, which sends me to the admin home screen.

Transaction still in taxjar. Based on what I'm reading on their site, I may have to submit a request to have those records removed.

This plugin is nice.

The orders are submitted to TaxJar at completion of checkout. They take a while to appear in the Taxjar interface. Its independent of order status.

You can remove a transaction from the TaxJar admin. No need for support. I don't remember how to do it, since I don't manage that.

If the "delete from taxjar' button in the admin is taking you back to the home page, then its broken, it should re-load the same page. Double check the install, check error logs.

Update, looks like Taxjar has changed this a bit, you do need to contact them to remove a transaction if the transaction was produced by the API. API transactions can only be removed by the API.

So, best to figure out why your delete button isn't working.

Double checked the single taxjar file that is located in the admin directory.

Just copied the link address on the delete from taxjar button and compared it to current page url:

/admin/index.php?page=1&oID=99999&action=edit&tj=2 (taxjar)

/admin/index.php?/index.php?cmd=orders&status=1&page=1&oID=99999&action=edit (current)

If I remove the cmd parameter from the current url, I also redirect to the admin home page.

I could be wrong (I probably am)

Don't need it fixed/resolved.

I can delete direct from taxjar.

Not trying to make work for u.

Plugin looks a lot more reasonable than the taxcloud plugin I'm using on another site

think I figured out what was happening re: optional taxjar buttons to add/delete taxjar

I changed 2 lines of code from the readme.txt file (OPTIONAL - Admin section) - that add the buttons to the admin/orders.php file

Changed:

<a type="submit" class="btn btn-sm bg-success" href="<?php echo $_SERVER['PHP_SELF']."?page=1&oID=".$oID."&action=edit&tj=1";?>">Add to Taxjar</a>

<a type="submit" class="btn btn-sm bg-danger" href="<?php echo $_SERVER['PHP_SELF']."?page=1&oID=".$oID."&action=edit&tj=2";?>">Delete from TaxJar</a>

TO:

<a type="submit" class="btn btn-sm bg-success" href="<?php echo $_SERVER['PHP_SELF']."?cmd=orders&page=1&oID=".$oID."&action=edit&tj=1";?>">Add to Taxjar</a>

<a type="submit" class="btn btn-sm bg-danger" href="<?php echo $_SERVER['PHP_SELF']."?cmd=orders&page=1&oID=".$oID."&action=edit&tj=2";?>">Delete from TaxJar</a>

I just hard coded what I believe if known as the basename??? into the url so that it would return to the same page.

I tested the Delete button only. Got the message indicating transaction was removed under the buttons and verified records was deleted in taxjar.

I have submitted an updated plugin to address the above issues. Also added to the readme.txt for more clarity and details, particularly for using Composer.

The addition of

define('MODULE_ORDER_TOTAL_TAXJAR_SORT_ORDER', 'TaxJar Sort Order');

in the file
./includes/languages/english/modules/order_total/ot_taxjar.php:

looks wrong to me. It's not a text string to be used as a label, it's a database config parameter (a number like 400), which is created when you install the module.

Thanks, please comment that out or I can send an update.

Please send an update, that way your repo is up to date with what's been submitted.