Totally Zenned
- Join Date:
- Oct 2008
- Location:
- Croatia
- Posts:
- 1,778
- Plugin Contributions:
- 21
Large images displays incorrect size
chadlly2003:
balihris I was just doing what he asked for. But i dont disagree with you.
I know you meant well and wanted to help, but with you being a template author, you need to think about multiple possibilities and scenarios and different devices to achieve a truly responsive layout, and not just drop the first solution because it works in one case (your screen).
What I've learnt over years is that most people ask for one thing, but actually want another and then, with a lot of discussion, we end up doing something completely different because the original idea wasn't the best. Also, sometimes just giving the solution without questioning isn't good at all: imagine if your friend came asking for a good quality suicide rope - would you just point them to the best rope in the store because they asked for it or would you discuss it and try to find a better solution?
So here the solution to
keep the product images and secondary image displayed in the viewportincludes/templates/usc_bs4/css/stylesheet.css
put at the very bottom
.modal-body .container {
max-width:600px
}
>
>
>
Close, but still... Look at the empty space in the bottom which could've been used to display a larger image... You're probably on a slightly smaller screen than me so it looks good, but you haven't considered different scenarios and different devices.
Also, what happens if an image is vertical and not square?
And just FYI, the gazillion scenarios is the primary reason why I'm reluctant to publish any templates... :wink: