VAT-mod for European companies

azrahn:

Hi,

Is this module also for zencart 1.3.5 or only for previous versions?

Ronald.

The latest version 1.2 is for 1.3.5 but it should work on 1.3.x as well... Haven't done much testing on that...

If you don't have 1.3.5, I would recommend to update...

djimmy:

I've installed the brand new version (1.2).
Beez:

Have you done a fresh install of 1.2?

I must have been hungry or tired... or both... Of course you mean VAT-mod version 1.2 :D We will look in to it! see what might have gone wrong... We'll get back...

Beez:

I must have been hungry or tired... or both... Of course you mean VAT-mod version 1.2 :D We will look in to it! see what might have gone wrong... We'll get back...

I think I found the bug, the fix was really simple:

--- includes/modules/order_total/ot_shipping.php.sav 2006-09-22 03:18:27.015818936 +0200
+++ includes/modules/order_total/ot_shipping.php 2006-09-22 03:26:02.403589472 +0200
@@ -94,7 +94,7 @@
}
}
$calculated_tax = zen_calculate_tax($order->info['shipping_cost'], $shipping_tax);

•    if(!$tva_tax){
  

•    if($tva_tax){
       $order->info['tax'] += $calculated_tax;
       $order->info['tax_groups']["$shipping_tax_description"] += $calculated_tax;
       $order->info['total'] += $calculated_tax;
  

(aka: remove the "not" from the second 'if(!$tva_tax){' in the file includes/modules/order_total/ot_shipping.php)

With this change the calculations look correct to me.

Have fun,

• Haegar

That's fine !!

Thanks.

Hello Beez,

thanks for the update.
I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"

Also, the error "your VAT ID does not match the Country" is not showing up as well

Dimi

Hi developer,

I think I found a bug. After rechecking the mod 3 times I do not think it is a copy/paste error.
Into the adminsection the admin is able to change customer details.
When the customer details contains a VAT number, then with the update action the screen becomes blank. This is ONLY when VAT check is on in the parametersettings of this mod.
However the customer can change his details from the frontend without problem.

I have searched for a solution in the code but was not able to determine where the problem is.
I gues it should be in /admin/customers.php there where a check is done if the check should be done or not, arround line 116

		if ( ENTRY_TVA_INTRACOM_CHECK == 'true') {					
			if (strlen($entry_tva_intracom) != 0) {
				if ($entry_country_id != false) {
					$countries_array = $db->Execute("select countries_iso_code_2 from " . TABLE_COUNTRIES . " where countries_id = '" . (int)$entry_country_id . "'");
					if ( (array_search($countries_array->fields['countries_iso_code_2'], array_keys(zen_get_tva_intracom_array())) === false) || (array_search(substr(strtoupper(trim($entry_tva_intracom)),0,2), zen_get_tva_intracom_array()) === false) ) {
						$error = true;									
						$entry_tva_intracom_error = 'true';

haegar:

I think I found the bug, the fix was really simple:

Thanx haegar!
I'll try it too and add it to the next version.

Janneman:

I think I found a bug. After rechecking the mod 3 times I do not think it is a copy/paste error.
Into the adminsection the admin is able to change customer details.
When the customer details contains a VAT number, then with the update action the screen becomes blank. This is ONLY when VAT check is on in the parametersettings of this mod.
That is correct, it doesn't work! And it's not a copy/paste error, at least not from you :)

To fix this copy the file: /includes/functions/extra_functions/functions_vatmod.php
To: /admin/includes/functions/extra_functions/functions_vatmod.php

That should do it, we just forgot that file :smile:

pivey:

I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"
What the f***! :shocking: this is strange! We'll look in to it as soon as we can!

Anybody els having this problem with the latest version (1.2)?

Cheers Mates!

pivey:

I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"

Also, the error "your VAT ID does not match the Country" is not showing up as well
You are right, it still doesn't work! I'll try to fix this upcoming week, when vike gets back...

pivey:

I just made a new install of the newest version, but i was still able to sign for an account using German VAT ID with Country "France"

Ok, I've fixed it... Stupid me, when I "fixed" it last time I only fixed it in the address book, under My Account... :eek:

The Fix: In the file /includes/modules/create_account.php on line 125-126 change:

$country_code = zen_get_countries_with_iso_codes($country);
if ( (array_search($country_code['countries_iso_code_2'], array_keys(zen_get_tva_intracom_array())) === false) || (array_search(substr(strtoupper(trim($tva_intracom)),0,2), zen_get_tva_intracom_array()) === false) ) {

To:

$country_code =zen_get_countries_with_iso_codes($country); $intracom_array=zen_get_tva_intracom_array();
if(substr(strtoupper(trim($tva_intracom)),0,2) != $intracom_array[$country_code['countries_iso_code_2']]){

At least that works for me :smile: Could you please try it out before I upload it to the download section...

Janneman:

I think I found a bug.
There are some other things that have been moved from admin/includes/functions/general.php to the new file admin/includes/functions/functions_vatmod.php

And in the latest install-file the changes for admin/includes/functions/general.php were missing. But I think the files were correct.

Please download the latest version of the VAT-mod (1.2.1) from here

NOTE: This is just a temporary package, the real one will be uploaded shortly to the download section. This package contains all fixes mentioned in this thread so far. But I haven't haegar's fix yet, though it's in the package. Just so you know...

Beez:

Please download the latest version of the VAT-mod (1.2.1)

NOTE: This is just a temporary package, the real one will be uploaded shortly to the download section. This package contains all fixes mentioned in this thread so far. But I haven't haegar's fix yet, though it's in the package. Just so you know...

I have merged your changes in my testenvironment and it works great now :-) Thanks Beez

Hello Beez,

works now as it should.
Thanks for supperb support. You finally focus :laugh:

Dimi

to Beez & Vike

Thanks for the great mod
I've downloaded ver 1.2.1, which is the latest I think.
If it is then I've got a little suggestion

When viewing the login page, the textbox for the VAT entry is located next to the ENTRY_COMPANY_TEXT (defined in main language-file)

You should add the following to:
includes\templates\YOUR_TEMPLATE\templates\tpl_modules_create_account.php

just before: <!-- TVA_INTRACOM BEGIN //-->

add: <br class="clearBoth" />

Also in the zip I've downloaded the path to this file is
includes\templates\YOUR_TEMPLATE\template
which should be
includes\templates\YOUR_TEMPLATE\templates
(a least for ZC 1.3.5)

Hope this is helpful...
...if I'm right at all

Thank you ALHO!
Helpful indeed!

Haven't had the Company field enabled when were doing this mod :-)
Changed that!

You're right in should be templates - typo... Changed that!

I'm posting version 1.2.2 to the downoading section now, will be up soon.

Good luck with your site!

hi

I'm trying to use VAT-mod with Admin-Profiles . When I activate Admin-Profiles the VAT-mod boxes in the admin section don't show anymore. Admin-Profiles suggested modifying extra_boxes files for 3rd party mods but VAT-mod doesn't seem to use these.

Any ideas how to do this?

thanks

mark

creativetags:

I'm trying to use VAT-mod with Admin-Profiles . When I activate Admin-Profiles the VAT-mod boxes in the admin section don't show anymore. Admin-Profiles suggested modifying extra_boxes files for 3rd party mods but VAT-mod doesn't seem to use these.

Actually I think I've just solved it - there's a setting at the bottom of the Admin Settings page -> Permissions for 3rd party mods and it was off on both my users accounts. Sorry for any wasted time

thanks

mark

No problem, glad it worked out!

Good luck with your site!

Hi,
I do not know if you can help me out. I have installed the VAT-mod for European companies version 1.2.2. I am based in the UK and when a customer from the UK purchases from me then there should be tax on both the product and the shipping. However, there is no VAT being added to the shipping costs. All my settings are correct and I installed following all the instructions given. Is the mistake on me making an error during the installation or could it be a bug.

The page which is causing the problem is
catalog/includes/modules/order_total/ot_shipping.php because when I revert back to the original zen cart script the VAT comes back on the shipping as it should be.

Can anyone please help

thanks

ml

Thanx for your intrest in our mod! Myself or vike will look in to it!

I'm bit busy at the moment, but if you give me a couple of days I'm sure we can fix it. It can most certainly be a bug, but if it is we'll squeeze it :smile:

No problems, I have solved it. You have placed a bug fix on page 6 of this thread for it.

thanks

ml