Tabbed Products ''LITE'' version - Delimiter based

qhome:

I also got the add to cart stuff fixed up. cleaned up a little.. but still needs a final cleaning.
Hey Q-

Can you detail what has been fixed and which are outstanding issues and/or on the latest to do list? Unless the issue of the add to cart box not showing up within an assigned tab is really repaired I wiill hold off installing the new beta as I have done extensive changes to the template file and merging can be a very time consuming ordeal.

With the new version is it also possible to render the Add to Cart box ABOVE the tabs? I think this is where I need it to go for some products. So I actually need the option of putting it on a tab or above the tabs).

qhome:

Woody, I have been workin on your "Global Products Description Tab" for a few hours now and I'm really close but it's a real sunavagun. I will try to release it with the next beta

Can you explain exactly what you plan for that tab. That is, how does the logic work?

The ovearll tabs logic is getting advanced with all the nested if else logic it is difficult to test all the possible permutations. That is understanding what happens if the tab is a integrated into the system (core), or it is set by hardcoding a tag, and at the same time what happens if global is set for the core tabs. Observing some unexpected results on v.3.1b.

qhome:

For style data, I will try to help you re-position that qty box as I dont have that on my site so im not sure what it looks like by default.

So the quantity box is not included in the "Add To Cart box"? (the add to cart button and the qty box makes up the Add To Cart box). The Qty box is really a must have.

If you happen to get it figured out and put up a demo with the Qty box included please let me know the URL.

Woody

ghome,

I still get the same errors in IE even with the new jscript. The error in product page disappeared after i uploaded the new tpl_product_info. The error in the index page is still there even will all the new files.

OK I see readme history shows:

07/17/2006 - v3.1(beta 2) - qhome

• fixed javascript null errors.
• fixed and merged Add to cart, Attribute Options, Product details (Stock, Model, etc), and Qty Discounts. Now all on same tab.

With this known I will redefine my question a bit.

I don't use the product details or qty discounts. And only my softgoods (downloadable products) have attributes (and just a single attribute).

So if I understand the updated readme correctly, in my case, the Add To Cart button would display all alone by itself on one tab? (I think you recently stated the quantity box does not show up correctly yet with the Add to Cart button, in the new beta anyway).

Or can the Add To Cart box (with quantity edit field) be placed on the first tab along with some product description text?

And/or can the Add To Cart box be placed above the tabs?

Need to know above before I decide or not to install/merge new beta version template file.

Did you receive the PM with code and javascript to insert into /admin/product.php file?

Woody

LOL .. i see i've thoroughly confused you all! And in my haste to get this out before noon (I had a half day at work and wanted to get this out) I seem to have forgotten to upload the new javascript file. So lets see if we can straighten this mess out.....

Woodymon:

Can you detail what has been fixed and which are outstanding issues and/or on the latest to do list? Unless the issue of the add to cart box not showing up within an assigned tab is really repaired I wiill hold off installing the new beta as I have done extensive changes to the template file and merging can be a very time consuming ordeal.

The add to cart stuff is totally fixed. THe "cleaning up" was in reference to general tabbing and commenting, but for the most part that is also pretty good. Keep in mind tho that these are betas and you shouldn't be doing too much to merge them around or use them on live store. I am first trying to get a feel for what the majority wants in terms of features and straighten them all out first.

Woodymon:

With the new version is it also possible to render the Add to Cart box ABOVE the tabs? I think this is where I need it to go for some products. So I actually need the option of putting it on a tab or above the tabs).

As you mentioned above, the Zen-cart team commented their code pretty good and I've left their comments in. So its really more of a personal customization, not related to the tabs. If you want to move the <!--bof Add to Cart box--> contents around then feel free to do so. Simply disable it from being on the tabs and it will spawn in its normal core spot. Then move that code to the top by the main image and it will be up there. If you need help with that, I can show you, and I've done it myself to test it.

Woodymon:

Can you explain exactly what you plan for that tab. That is, how does the logic work?
Based on what you mentioned previously, I set it so that if you set the Global Products Description variable to TRUE, then it autocreates a Product Description tab and puts the product description in that tab. I have it working fine, its just the combination of that and image inside the tabs and add to cart in the tabs that needs to be tweaked.

Woodymon:

The ovearll tabs logic is getting advanced with all the nested if else logic it is difficult to test all the possible permutations. That is understanding what happens if the tab is a integrated into the system (core), or it is set by hardcoding a tag, and at the same time what happens if global is set for the core tabs. Observing some unexpected results on v.3.1b.

Not sure what you are seeing on your site. But the only "odd feature" was this:
If there IS at least one custom tab, and the Add to Cart variable is true, then it will add that add to cart button to the first tab automatically. If there is NOT at least one custom tab, then the Add to cart stuff will autocreate its own tab, and it will always be the first tab, since the main product description will not be in a tab and will be above the tabs. By custom tabs i mean you actually put <!--%Tabname%--> into the actual product description in the admin area. This was done so that no matter what, customers could see your add to cart button without having to navigate around.

Woodymon:

So the quantity box is not included in the "Add To Cart box"? (the add to cart button and the qty box makes up the Add To Cart box). The Qty box is really a must have.

I really confused you here.. the "Quantity Discount" box is what styledata is talking about. See his site has a table that shows if you buy larger quantities, you get more of a discount on price. so 1-5 for $5 each, 6-10 for $4 each, 11+ for $3.50 each. he wants that table to be at the top so I told him I'd help him put it there as a side item, but the actual TabbedLite contrib would keep all "Add to Cart" functionality as a whole including the Add to cart button, the Product details (model #, stock, etc), the Attribute options, and the Quantity Discount table just as they are laid out in the core Zen-Cart.

Woodymon:

I don't use the product details or qty discounts. And only my softgoods (downloadable products) have attributes (and just a single attribute).

So if I understand the updated readme correctly, in my case, the Add To Cart button would display all alone by itself on one tab?

Yes.. its the exact layout that Zen-Cart core uses. So if you ahve them disabled in the normal admin area, then they will be disabled here as well.

You can see it at my demo site.

I've attached the updated javascript changes to fix the errors in IE.

Forgot one...

Woodymon:

Or can the Add To Cart box (with quantity edit field) be placed on the first tab along with some product description text?

Yes this has been possible since verstion 2.0.. read up above where i mention the "odd feature" to see how it behaves.

ghome,

Thanks for the new jscript. The error in the index page is no longer there, but in the product page it still show up when the header is FALSE. If you turn this header to TRUE, it disappear. I don't know why it errors when false but i would prefer to hide this header (extra image to load). Can this be deleted in the jsript or css?

Berserker:

ghome,

Thanks for the new jscript. The error in the index page is no longer there, but in the product page it still show up when the header is FALSE. If you turn this header to TRUE, it disappear. I don't know why it errors when false but i would prefer to hide this header (extra image to load). Can this be deleted in the jsript or css?

Its just a logic check to see "if exists.. then do it".. Currently it doesnt check if it exists first and it just tries to do it. I will add some logic to check on all jscript parts to verify they are there first in the next release.

here is a fix if u dont want to wait.

find:

if ($bShowHeaders != true) {
 				  // Hide tab header if JavaScript is available/active but they are set to false
 				  echo ("<script type=\"text/javascript\">
  				  <!--
  				    document.getElementById('ProductDescriptionHeader').style.display = \"none\";
  				    document.getElementById('DetailedSpecsHeader').style.display = \"none\";
  				    document.getElementById('AddToCartHeader').style.display = \"none\";
  				    document.getElementById('AdditionalImagesHeader').style.display = \"none\";
  				    document.getElementById('ProductDetailsHeader').style.display = \"none\";
  				  -->
 				  </script>");
         }

Replace with:

if ($bShowHeaders != true) {
 				  // Hide tab header if JavaScript is available/active but they are set to false
 				  echo ("<script type=\"text/javascript\">
  				  <!--
  				  if (document.getElementById('ProductDescriptionHeader') != null) {
  				    document.getElementById('ProductDescriptionHeader').style.display = \"none\";
  				  }
  				  if (document.getElementById('DetailedSpecsHeader') != null) {
  				    document.getElementById('DetailedSpecsHeader').style.display = \"none\";
  				  }
  				  if (document.getElementById('AddToCartHeader') != null) {
  				    document.getElementById('AddToCartHeader').style.display = \"none\";
  				  } 
  				  if (document.getElementById('AdditionalImagesHeader') != null) {
  				    document.getElementById('AdditionalImagesHeader').style.display = \"none\";
  				  }
  				  if (document.getElementById('ProductDetailsHeader') != null) {
  				    document.getElementById('ProductDetailsHeader').style.display = \"none\";
  				  }
  				  -->
 				  </script>");
         }

ghome,

The errors all gone now :) Thanks a lot!!!!!!!!

Hi got a strange problem and not sure if it is this or the css flyout addon.

With the css flyout menu it places the submenu links under the window of the tabs(floats under). If no tabs are used the flyout menu is fine. So it is as if the tabs have priority of display (on top) and the rest renders under.

Any ideas ?

IntelCos:

Hi got a strange problem and not sure if it is this or the css flyout addon.

With the css flyout menu it places the submenu links under the window of the tabs(floats under). If no tabs are used the flyout menu is fine. So it is as if the tabs have priority of display (on top) and the rest renders under.

Any ideas ?

Perhaps a Z-order thing with the flyout is needed. I dont think they were designed to flyout over an image.. but Im not sure how all that works.. does it happen the same on ALL browsers ?

qhome:

Perhaps a Z-order thing with the flyout is needed. I dont think they were designed to flyout over an image.. but Im not sure how all that works.. does it happen the same on ALL browsers ?

Yep, all browsers (fox and ie)

got a link? I could play with some settings to see if i can see in the source where the problem is.

For products without attributes the Add to Cart box still does not display in the tab container in Firefox.

I'm parsing thru the logic right now to see what's up.

Woodymon:

For products without attributes the Add to Cart box still does not display in the tab container in Firefox.

I'm parsing thru the logic right now to see what's up.

GRR.. That add to cart box is a real bastard. If I put that add to cart at the bottom of the of the order it also shows up off the tab.. even tho it is actually associated with the tab, (i.e. if you click a new tab, it will hide the add to cart box. For some reason, because of the way it floats, I think it runs out of room on the screen or something and floats below the line. Not sure why it didn't do that do that on the old tablite version.

I know if the older version there was more div nesting, I wonder if that did it, or if maybe there was some CSS in one of the outer divs that prevented things from floating outside of it. I will look into it more. Maybe if the addto cart box isn't set to float but I really want to avoid having to make core css changes.

Should we be moving over to that new V3 Javascript file?

if so, do we just replace the current one, or is there more too it?

any help would be great.
thanks
Benjamin

wickedklown:

Should we be moving over to that new V3 Javascript file?

if so, do we just replace the current one, or is there more too it?

any help would be great.
thanks
Benjamin

use the v3 file with the v3.1b versions. You can delete the v2 version or you can leave it. they wont conflict eachother, but I wont support th v2 anymore as the code was too bloated for simple tabs.

and UPDATE about that damn add to cart button. It seems the diagnoses is known as a "FloatDrop"

see here: http://nemesis1.f2o.org/aarchive?id=11

Its seems floats do not have definite mass and simply "float" over things, which makes sense. It appears the best fix is to surround the float by a table which has a definite mass to it. If you remember I added a table and td tags to the last version for something else and I guess that indirectly fixed this problem too so thats why you didnt see it then.

So I tried it out and I got it working. its a minor fix and it seems to work on all 3 main browsers (Opera, IE, FF) But i'd have to add table tags around the add to cart stuff.

Alright. it seems to work pretty good actually.

its a simple table putting the product details, attrib options, and Qty Discount table on one side, and the add to cart button on the other side. In fact, this is what the core zc template SHOULD have looked like even without tabs.

see all 3 demo products at the demo link in my signature.

qhome:

Alright. it seems to work pretty good actually.

its a simple table putting the product details, attrib options, and Qty Discount table on one side, and the add to cart button on the other side. In fact, this is what the core zc template SHOULD have looked like even without tabs.

see all 3 demo products at the demo link in my signature.

Very good! Has the download been updated with the fix?

3.1 Release Candidate 1!

Here you go. Give it a whirl.

• Fixed more javascript errors. That should be all of them now
• added ability to hide headers when javascript is on OR off
• Merged the Cross Sell version with the main version to make it easier to maintain. Now you can set a flag if you have CrossSell installed. Don't enable it if you don't have it installed or you will get errors.
• Made the whole Add to cart, Attribute Options, Product details (Stock, Model, etc), and Qty Discounts in a table now to fix the floating problem. Looks and works 10 times better now :)
• Enabled Additional Images, Customers Also Purchased, and Cross Sell to check if there is any content for them. If not, then don't load the tabs for that product even if the global is set to true.
• If there are no tabs at all I hide the entire tab container to prevent extra border lines from the empty shell.