Totally Zenned
- Join Date:
- Sep 2004
- Posts:
- 2,309
- Plugin Contributions:
- 1
Tabbed Products ''LITE'' version - Delimiter based
But now I also see in readme:
"Database Modifications: NONE!"
Yep... Me all confused now. ;-)
Woody
Views: 234,225
Totally Zenned
But now I also see in readme:
"Database Modifications: NONE!"
Yep... Me all confused now. ;-)
Woody
Totally Zenned
LOL this is what happens when you re-use the readme from the original TabbedProducts contrib I made. :) Please ignore the line about database modifications.. there are none.. i just overlooked that line.
As far as the file modifications. Yea I thought about that too. I guess I was thinking more about core file overwriting. But you are right, this does overwrite that one file.
If only we could get the forum admins to understand why we need never-ending post editing, this could be easily fixed... but.. the 5 min limit has passed.
Totally Zenned
hey Q-
I concluded no db patch is required. (as stated early in this thread).
I discovered that any product description text (e.g. subhead text) positioned above <!--%Product Description%--> is not displayed. :(
Can this mod be modfied to allow subhead formatted text at the very beginning of the product description to display adjacent to the product image (not in a tab), and then display the remainder of product description text in the tabs. Right now it appears to be an all or nothing proposition.
On the default 1.3.0.1 product page layout, the tabs are clustered together floating by themsleves, just to the right of the product image, far above the product decription text box as should be expected. Not how they appear on the demo website.
Also the mod auto generates three tabs "product details, "customers also purchased", and "additional images". You mentione this in the thread but I'm am not aware of the correct method to disable these tabs?
I am sure this will be cool mod when all the kinks are worked out. Let me know if you release another beta as I would like to assist testing. In the meantime I will need to remove so I can put the updated shoppe into production.
Thanks, Woody
Totally Zenned
Woodymon:
hey Q-
- I discovered that any product description text (e.g. subhead text) positioned above <!--%Product Description%--> is not displayed. :(
Can this mod be modfied to allow subhead formatted text at the very beginning of the product description to display adjacent to the product image (not in a tab), and then display the remainder of product description text in the tabs. Right now it appears to be an all or nothing proposition.
Never thought about putting text before the tabs. I will look into getting that to work.
Woodymon:
On the default 1.3.0.1 product page layout, the tabs are clustered together floating by themsleves, just to the right of the product image, far above the product decription text box as should be expected. Not how they appear on the demo website. Hmm. the file itself controls the layout, Im not sure how you have tabs on the default 1.3 product page layout. Or are you trying to merge the changes into your custom tpl file? There are quite a few changes to that file and I haven't yet worked on steps to merge. I will try to get that going for the next version.
Woodymon:Also the mod auto generates three tabs "product details, "customers also purchased", and "additional images". You mentione this in the thread but I'm am not aware of the correct method to disable these tabs? I think i put in the readme that you can edit the tpl file and at the top you change the 'true' to 'false'. Maybe in my haste I omitted that from the readme.
Totally Zenned
Will your contribution work with the tpl_product_music_info_display.php template or you're only supporting the generate template. The reason I asked is I am actually interested in using this mod to control my music product type. For example on this product page: http://www.clevershoppers.com/reach-audio-cd-warren-barfield-pmi-455.html I can see leaving the descriptions in one tab and the track listing with music sample in another tab. Thoughts?
Thanks!
Inactive
Thanx ghome
Totally Zenned
I merged my changes into your provided template file. It was a very straight forward process as you have documented everything very well!
Off the top of my head the mods I am using which affect the product_info_display page are IH2, Cross Sell and Ask A Question.
It appears that the size of product image I am displaying is pushing the tab text content area down, but the tabs themselves remain floating above.
That is it appears the vertical positioning of the tabs is not 'liquid' depending on the size of the product image. But the area where the product description content is displayed is indeed liquid and displays below the product image.
Increase the size of the CD product image on your demo site to understand what I am stating. I
Yes allowing the subhead text (top portion of the product description text) to display above of the tabs is a MUST have feature ;-)
And oops... I did miss the part in the readme where you explained to set the three tab variables to true/false. I see it clearly now. Thanks for the follow-up. Look forward to the next update.
Woody
Totally Zenned
GREAT NEWS!! I FINALLY figured out why everything was displaying on the main tab.. Took me 3 hours to dissect the entire code change and find it was one display property that I didnt adjust for in the FOR loop smacks head. But that part is working perfectly now.
BlessIsaacola:
Will your contribution work with the tpl_product_music_info_display.php template or you're only supporting the generate template. The reason I asked is I am actually interested in using this mod to control my music product type. For example on this product page: http://www.clevershoppers.com/reach-audio-cd-warren-barfield-pmi-455.html I can see leaving the descriptions in one tab and the track listing with music sample in another tab. Thoughts?
Thanks!
Currently its only for the normal "general" product. I suppose I could make one for each of the default product types. I'm trying to see how much effort it would be to make it a mergeable thing so it can easily be put into other product types. ideas are welcome.
Woodymon:
- Off the top of my head the mods I am using which affect the product_info_display page are IH2, Cross Sell and Ask A Question. Hmm yea i dont have those on my site so i hadn't tested with them. I think they can still be merged tho to show up in their normal places, just not as a tab unless I can make the code a little easier to modify and add to.
Woodymon:It appears that the size of product image I am displaying is pushing the tab text content area down, but the tabs themselves remain floating above.
That is it appears the vertical positioning of the tabs is not 'liquid' depending on the size of the product image. But the area where the product description content is displayed is indeed liquid and displays below the product image.
Increase the size of the CD product image on your demo site to understand what I am stating.
Yea i see this too. There is actually a series of <br /><br /><br /><br /> that I added to the code to force it to move down farther, but its a hack and it varies with certain images.. some appear too far down, and some do what you are describing. For my next version I am actually going create a few different layouts, one idea is to put the picture inside the tabs and have it display on the First tab only. Similar to this: http://www.winfieldwoodworks.com/catalog/Cutting_Board_12.html
But some of the layouts may get pretty wild and may end up being hard to merge for novices. But I do intend to stick with the <div> block method the best I can and hope to make easy to read blocks that you can move around and add other contribs to.
Would be nice to figure out a way to make a form in the admin panel do this all for me.. and add tabs via a gui or something. I'm not that advanced in my php coding for that tho. But I will try to work on this and make it as useful as possible and listen to your ideas.
Totally Zenned
Also.. im running IH2.. on my other site (without the contrib yet).. but i dont remember any changes to the product info template file that would be affected by the tabs.
Totally Zenned
ok version 3 beta is on the demo site (check my signature).. note the image is inside the tab and the first tab is fixed. I'd like to also put the options and add to cart button inside too but I'd like to make them fit a little tighter as well..... but i'd like some feed back about it having the image inside.
I am still looking into having text before the tabs as well.. it doesn't seem too hard. but I want to make sure it parses properly. Also, Im just waiting for someone to ask about having text after the tabs which could be a bit harder... or would at least require a new tag to let the code differentiate.
Also going to work on adding <noscript> tags so it just shows the normal way if jscript is disabled.
Totally Zenned
Ok Wood
I got your text above the tabs.. it was ridiculously simple after I had a good lunch lol.
I am adding <noscript> stuff now.
Does anyone know of a good way to check if things like additional images exist so I can hide those tabs if there are no additional images? It is a "requires" call so it calls a completely different file. same with Customers also Purchased.
I can finagle it for the details like model/qty/stock .. but thats about it.
Also I was gonna try adding the review editor on a tab as an option by including the review editor php file and see how that works.
Which do we like better.. image inside the tabs or outside the tabs? It will no doubt come to a vote that i should add the ability to do both :)
Totally Zenned
Along the same lines as additional pictures, you can make it look to see if there are cross sell items assigned to it. If not, make that tab disappear (sorry, not trying to be picky, it was just a thought).
Totally Zenned
yea.. support for other contribs like that will be next if i can figure a way to do it from within this one file.
Totally Zenned
qhome:
I got your text above the tabs.. it was ridiculously simple after I had a good lunch lol.
Q- Cool! Can you post the code change. That in itself is the major immediate need I have for your mod.
Below is the default order of the product page layout in Zen Cart 1.3x
Main Product Image*
Product Name*
Product Price (block)*
Free Ship icon*
Product Description
Add to Cart box*
Product Details list:*
[Also the category icon and the "above" and "below" Prev/Next buttons/positions which should remain outside of the tab scheme, as you have them now.]
I prefer the items marked with an asterisk (everything except the Product description text) to display outside of the tabs layout, if store owner desires.
Myself I will likely always want to display the main product image free-standing by itself, ABOVE the tabs. And the same with the various buttons (add to cart, Reviews, ask-a-question, tell-a-friend, etc). And thinking I will want to display the cross sell images below the product description text/tabs.
And abilty to display product description text both above and below tabs is very desirable.
Ability to support product page layout flexibility is key as I'm sure others will have different combinations of layout needs.
Looks like you have additional visions for your mod, e.g. being able to support other mods and configure tabs within admin, which is great.
Once you have integrated the ability to display various data objects in your tab scheme storeowners should be able to easily figure out how to integrate other product related data into your tabs layout, if needed.
Down the road I invision the Zen Cart dev team supporting repositioning/sorting, from a single Zen Cart admin page, every single display/data object on the product page (currently ZC 1.3x allows you to enable/disable the display of most product page objects via Config > Product info and various other admin menus). Mod developers would need to know how to integrate their customizations into such a scheme.
You are making quick strides. Keep up the good work.
Woody
Zen Follower
This is looking really great Qhome, very well done. You know what would polish this up though? Rollover tabs ... either make other gfx and have them change completely, or have the text inside the tabs change colour on mouseover, what do you think?
Totally Zenned
Pauls:
This is looking really great Qhome, very well done. You know what would polish this up though? Rollover tabs ... either make other gfx and have them change completely, or have the text inside the tabs change colour on mouseover, what do you think?
Yea i had that for the original tabs version 1 before i changed to this style.. this one looks better at default.. but that should be easy to do in the CSS as well.. i'll look into some color ideas and you guys can customize it as you like :)
@Wood I will try to post it tonight. I want to make sure the read me and everything is correct. At the moment because I'm doing so much on and off stuff, its hard to keep the code clean so im trying to do what I can with it to make it easy to use and merge.
Totally Zenned
OK! Its time for the latest beta!
Totally Zenned
Q-
You are quick with the updates!
I. The new filename is:
TabbedLite-v2.5-beta.zip
But the new readme says
Contribution: Tabbed Products "LITE"
Version: v3.0 beta
II. The readme states:
Also, inside the
/catalog/includes/templates/YOUR_TEMPLATE/templates/tpl_product_tabbed_info_display.php file, there are configurations at the top for additional tabs you can show.
I think you meant inside either t1l_product_info_display.php OR t2l_product_info_display.php...
Just trying to keep you honest ;)
Woody
Totally Zenned
LOL damn this 4 hours of sleep! it was gonna be named 3.0 but i didnt feel it was worth a whole number lol.. and i had that multiple layouts thing at the last second. Ah well... so far the best beta test has been on the readme lol :)
Anyways.. lemme know how u like the tabs so far.
Totally Zenned
qhome:
LOL damn this 4 hours of sleep! it was gonna be named 3.0 but i didnt feel it was worth a whole number lol.. and i had that multiple layouts thing at the last second. Ah well... so far the best beta test has been on the readme lol :)
Anyways.. lemme know how u like the tabs so far.
I knew that would make you laugh :)
Yes since it is in beta none of those readme issues matter. Just wanted to ensure I wasn't missing out on testing a newer version ;-)
Regardiing beta versioning... generally when I release something to beta I release as 0.5beta, then next minor update as 0.5.0.1beta, etc (or if major beta update then increment to 0.6beta). When really ready for prime time and out-of-beta I release as 1.0, then later minor updates as 1.0.1, 1.0.2, etc. And larger updates as 1.2, or 1.5 and the next really big update as 2.0 (you get the picture).
Back to the topic of discusssion... I just installed your 2.5beta and it works VERY NICELY. All my previous reported issues are fixed.
Now I look forward to the ability to display product description text below the tabs ;-)
Time to take the beta label off. I'm betting this will become a very popular mod in short notice. And something the Dev team will consider including as core. Great work!
Woody
Tell staff why this post should be reviewed.