Froogle Merchant Center merged into GoogleBase

a_berezin:

It not a problem! I know about that.

Download last version from my site.

Are you sure the version from your site is updated? It doesn't work. I am back to where we started using the version from your site.

Thanks!

Last version is v 1.3.0 28.11.2006 2:23. Try once more. And check the version.

It is the same as http://www.zen-cart.com/forum/showpost.php?p=296514&postcount=243
I add only one "\n" to the end of output row.

What do you mean when you say "It doesn't work"? How "It doesn't work"?

a_berezin:

Last version is v 1.3.0 28.11.2006 2:23. Try once more. And check the version.

It is the same as http://www.zen-cart.com/forum/showpost.php?p=296514&postcount=243
I add only one "\n" to the end of output row.

What do you mean when you say "It doesn't work"? How "It doesn't work"?

Thank you so much! This one work flawlessly, the file is generated and everything looks good. I submitted it to google and now I just need to figure out why I am getting so many errors with Too Few Tabs. I did not have these errors before on the products that Google is rejecting.

The is now finishing the process and generating a google base file so I am happy with that.

Could it be that I am getting these Too Few Tabs error because I am using model instead of product id for my offer_id?

Thanks!

Please download and test once more.
I cann't repeat that error :-( But on any case has cleaned a some code.
Please, e-mail me about results of your testing.

Andrew,

Thank you for the continued development work on this module :smile:

This may not be related to the problem BessIsaacola has reported, but isn't there still an unnecessary '\t' on the end of the feed?

For example:

$output = "title \t" .
						"description \t" .
						"link \t" .
						"price \t" .
						"image_link \t" .
						"expiration_date \t" .
						"label \t" .
						"id \t" .
						(GOOGLE_FROOGLE_IN_STOCK == 'true' ? "quantity \t" : '') .
						(GOOGLE_FROOGLE_SHIPPING != '' ? "shipping \t" : '') .
						(GOOGLE_FROOGLE_MANUFACTURER == 'true' ? "brand \t" : '') .
						(GOOGLE_FROOGLE_PRODUCT_TYPE_SHOW == 'true' ? "product_type \t" : '') .
						(GOOGLE_FROOGLE_LANGUAGE_DISPLAY == 'true' ? "language \t" : '') .
						(GOOGLE_FROOGLE_CURRENCY_DISPLAY == 'true' ? "currency \t" : '');

Each line has a '\t' on the end - which means there will always be an extra (unnecessary) tab on the end of the feed, no matter which options are set in admin.

Shouldn't the "id \t" be simply "id", and the following '\t's be moved to the beginning of the optional feed lines, eg:

$output = "title \t" .
                        "description \t" .
                        "link \t" .
                        "price \t" .
                        "image_link \t" .
                        "expiration_date \t" .
                        "label \t" .
                        "id" .
                        (GOOGLE_FROOGLE_IN_STOCK == 'true' ? "\t quantity " : '') .
                        (GOOGLE_FROOGLE_SHIPPING != '' ? "\t shipping" : '') .
                        (GOOGLE_FROOGLE_MANUFACTURER == 'true' ? "\t brand " : '') .
                        (GOOGLE_FROOGLE_PRODUCT_TYPE_SHOW == 'true' ? "\t product_type" : '') .
                        (GOOGLE_FROOGLE_LANGUAGE_DISPLAY == 'true' ? "\t language" : '') .
                        (GOOGLE_FROOGLE_CURRENCY_DISPLAY == 'true' ? "\t currency" : '');  

(And the same for the block of code from line 146 to line 159)

Has anyone successfully used this with SEFU? Although I am able to view a particular page based on the url output of this contrib, it's not the same url that I see for a product when I manually browse to the page on my site. I would prefer not to have too many urls different urls leading to the same page on my site, lest I'm punished for duplicate content.

Phid!
You are the first, who told me, that this GoogleFroogle not work with SEFU.
What SEFU you use?

phid, this mod works fine with Ultimate SEO v.2.103 i believe it is (latest version of Ultimate SEO at this time). There is another SEFU mod out there, and I'm not sure of compatibility of that.. maybe thats the one you're using?

Hello all,

I use the ex-Tim Kroger Breakmyzencart SEFU urls that have been updated by JeffD to be compatible with 1.3.6. I'm not saying that it won't work with it, just that I'd run the risk of having Google think I'm spamming with duplicate urls.

In the config area, when I set the "Show feed language = true", I get something like:

://www.mysite.com/pages-productinfo/product-204/language-en/my-product.html

in my url. While the link does lead to the product page, it's not the same url that appears when I just naturally browse to the page (like a search engine would normally). Here is how my url looks when I browse to the page manually:

://www.mysite.com/pages-productinfo/Mymerchandise-66_69/product-204/my-product.html

Now I can remove the language-en text by putting "Show feed language = false", but then I'll still be missing the "Mymerchandise-66_69". This text is from my sefu_defines.php file:

define('SEFU_CATEGORY_NAME', 'Mymerchandise');

Here are the settings I had for the GoogleFroogle generated feed:

Show Default Currency false
Default Currency USD
Show Offer ID model
Display quantity false
The shipping options available for an item
Show Manufacturer true
Show Product Type true
Product Type other
Show Feed Lanugage true
Feed Language English
Output File Name froogle.txt
Compress Feed File false

Ok! Don't use this module with "ex-Tim Kroger Breakmyzencart SEFU urls that have been updated by JeffD to be compatible with 1.3.6". I don't know how it works.

Well, let me know if you figure out a way to add a "Show Categories = true/false" option in the configuration area....that seems like something I could use.

When I start developing this mod, I use cPath in url, but later I have removed it at the request of the users.
No problem to add a "Show Categories = true/false" option.

Is the google/froogle mod compatible with Image Handler?
The feed I created is declined because the image links are wrong.

I'm using v 1.2.10 13.10.2006 0:18 on ZC136

Please help.

gonewild:

Is the google/froogle mod compatible with Image Handler?
The feed I created is declined because the image links are wrong.

I'm using v 1.2.10 13.10.2006 0:18 on ZC136

Please help.

OK, I found post #186 and made that change. I assumed that had been put into the mod but now see it is a necessary custom change for Image Handler use.

a_berezin:

Please download and test once more.
I cann't repeat that error :-( But on any case has cleaned a some code.
Please, e-mail me about results of your testing.

I was finally ready to test the updated file but I got an error File "zc-contribution/GoogleFroogle.zip" not found in download directory...

I am not ready

BlessIsaacola!
Sorry for delay. Test this one.

Andrew,

I would like to firstly thank you for all your hard work on this and your other contributions - it really is appreciated.

I have tried to install your contribution and firstly got an error in the SQL. Just for information, the error was a bracket at the beginning of the last line of the patch:

NULL, 'Use cPath in url', 'GOOGLE_FROOGLE_USE_CPATH', 'false', 'Use cPath in product info url', @t4, 20, NULL, NOW(), NULL, 'zen_cfg_select_option(array('true', 'false'),');

I simply added the braket at the beginning of the line and the statement was successfully processed.

(NULL, 'Use cPath in url', 'GOOGLE_FROOGLE_USE_CPATH', 'false', 'Use cPath in product info url', @t4, 20, NULL, NOW(), NULL, 'zen_cfg_select_option(array('true', 'false'),');

I then tried to set the perameters in admin and got the following errors when I clicked on both the change currency option:

Fatal error: Call to undefined function: zen_cfg_pull_down_currencies() in /htdocs/admin/configuration.php(192) : eval()'d code on line 1

and the feed language option:

Fatal error: Call to undefined function: zen_cfg_pull_down_languages_list() in /htdocs/admin/configuration.php(192) : eval()'d code on line 1

Have I done something wrong and will it effect the operation of the mod?

Many thanks again.

H

Hi BigMacYin,

BigMacYin:

Just for information, the error was a bracket at the beginning of the last line of the patchThank you. Fixed.
BigMacYin:

I then tried to set the perameters in admin and got the following errors when I clicked on both the change currency option:

Fatal error: Call to undefined function: zen_cfg_pull_down_currencies() in /htdocs/admin/configuration.php(192) : eval()'d code on line 1

and the feed language option:

Fatal error: Call to undefined function: zen_cfg_pull_down_languages_list() in /htdocs/admin/configuration.php(192) : eval()'d code on line 1Check admin/includes/functions/extra_functions/googlefroogle.php

Thanks Andrew, that did the trick and all is working now. I have now changed my FTP software!!

Kindest regards,

H