COD not showing as Payment Option

I have an issue with zencart 1.3.0 where the "Cash on Delivery" Option does not show if a Customer has a "Gift Vouchure" (which is virtual) in their shopping Basket combined with "Non Virtual" items.

If I delete the "Gift Vouchure" from the Shopping Basket and goto Checket all is OK and the "Cash on Delivery" option is there.

"Gift Vouchures" are the Only Virtual Items I have on my site. All other Items are physical items and need to be delivered. But if a customer adds a Gift Vouchure in the same Order as other items the COD payment option wont show up..

You cannot buy a Gift Certificate with COD as COD goes to the customer's door to ring the door bell and the Gift Certificate arrives in the email ... :smile:

This is built into Zen Cart ...

yes there seems to be a fair bit of fault built into the cod module, the design is the flaw, it wasn't thought about enough in the first place

drakky:

yes there seems to be a fair bit of fault built into the cod module, the design is the flaw, it wasn't thought about enough in the first place
Care to offer some more detail on this thought?

sure, an example is Robwat's post , you should be able to have mixed physical and virtual items in your cart , the cod settings should only be applied to the physical items though , not just automatically completely disable the COD module if a virtual product is in the cart.
Perhaps Virtual and Physical products could be split on the checkout confirmation page and separate shipping listed? only 1 total at the bottom would be needed.

The cod fee message on the checkout payment page could be a custom message set in Order Totals Page in admin (note if a no is selected in the Admin/Order Totals for the selected shipping method , then the COD option is not displayed on the checkout payment page at all)

I also think that instead of having all those things in Order Total Modules the cod module could read the installed shipping modules from the database and allow you to change settings for them , making it easy to disable COD on the payment page for shipping methods that cannot use it, so that the customer is not given the option of Cod for any particular shipping method if it's not set in the admin panel.
This to me is a more universal approach and saves people having to find or make edits to cod.php or their shipping modules if they are ones that aren't in the standard installation package.
I'm not sure if I've explained it properly so perhaps something like this (the pic is hopefully easier to understand )

 
// disable the module if the order only contains virtual products
      if ($this->enabled == true) {
        if ($order->content_type != 'physical') {
          $this->enabled = false;
        }
      }
 

somewhere is /includes/modules/payment/cod.php

change
$this->enabled = false;
to
$this->enabled = true;

Be aware that if you have Gift Certificates ... those are Virtual Products ...