Forums / Bug Reports / Metatags on manufacturers pages? Bug, or am I misunderstanding?

Metatags on manufacturers pages? Bug, or am I misunderstanding?

Locked

Started by jettrue on 31 Jul 2006, 4:49 AM · Views: 1,909

Results 1 to 5 of 5
This thread is locked. New replies are disabled.
31 Jul 2006, 4:49 AM
#1
jettrue avatar

jettrue

Totally Zenned

Join Date:
Jan 2005
Location:
USA, St. Louis
Posts:
3,651
Plugin Contributions:
5

Metatags on manufacturers pages? Bug, or am I misunderstanding?

It seems like, from the modules/meta_tags.php file that there is supposed to be custom metatags using the manufacturers name, yet its just using the basic metatags for the site. If you go to any person's zen cart that is using the manufacturers sidebox you'll see what I mean.

This is the section of code that leads me to believe that zen cart is supposed to do this (around line 97):

    } elseif ($category_depth == 'products') {
	    if (isset($_GET['manufacturers_id'])) {
        $sql = "select manufacturers_name from " . TABLE_MANUFACTURERS . " where manufacturers_id = '" . (int)$_GET['manufacturers_id'] . "'";
        $manufacturer_metatags = $db->Execute($sql);
        if ($manufacturer_metatags->EOF) {
          $meta_tags_over_ride = true;
        } else {
          define('META_TAG_TITLE', $manufacturer_metatags->fields['manufacturers_name'] . PRIMARY_SECTION . TITLE . TAGLINE);
          define('META_TAG_DESCRIPTION', TITLE . PRIMARY_SECTION . $manufacturer_metatags->fields['manufacturers_name'] . SECONDARY_SECTION . KEYWORDS);
          define('META_TAG_KEYWORDS', KEYWORDS . ' ' . $manufacturer_metatags->fields['manufacturers_name']);
        } // EOF

I'd like the manufacturers pages to have the manufacturers name in the title. Anyone know how I can make this happen?

Thanks!

6 Aug 2006, 7:05 PM
#2
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

well heck ... click the manufacturers' sidebox ... nope ... click the manufactuers' dropdown ... nope ... :cry:

Betcha you want me to tidy all that code up eh? How hard can it be? :unsure:

Thanks for the update ...

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

7 Aug 2006, 4:21 AM
#3
jettrue avatar

jettrue

Totally Zenned

Join Date:
Jan 2005
Location:
USA, St. Louis
Posts:
3,651
Plugin Contributions:
5

Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

Ajeh:

well heck ... click the manufacturers' sidebox ... nope ... click the manufactuers' dropdown ... nope ... :cry:

Betcha you want me to tidy all that code up eh? How hard can it be? :unsure:

Thanks for the update ...

Thanks for the reply Ajeh...

But do you mean you plan on fixing that bit of code, or just clean it out, as a non-viable option?

I'm just curious if there is some typo or small change that could make it work... I'd really appreciate that feature.

Thanks! :P

7 Aug 2006, 4:28 AM
#4
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

Actually it will be best to wait until the next upcoming bug fix ...

It took quite a few extra little tweaks and twists as the manufacturers_id is defined by 2 values depending on how you display the products_listing ... and at what level in the Cats etc.

It was lots of fun ... :no:

But ... it appears to work much better now ...

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

12 Aug 2006, 1:51 PM
#5
jettrue avatar

jettrue

Totally Zenned

Join Date:
Jan 2005
Location:
USA, St. Louis
Posts:
3,651
Plugin Contributions:
5

Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

Ajeh:

Actually it will be best to wait until the next upcoming bug fix ...

It took quite a few extra little tweaks and twists as the manufacturers_id is defined by 2 values depending on how you display the products_listing ... and at what level in the Cats etc.

It was lots of fun ... :no:

But ... it appears to work much better now ...

Wait? You want me to wait?

Oh, OK :lol:

Patience was never a virtue of mine. :cool: