[Done 1.3.5] No Tax Basis calc using Zones shipping module

12 Aug 2006, 11:35 PM

Totally Zenned

Join Date:: Oct 2004
Location:: Southport, UK
Posts:: 3,644
Plugin Contributions:: 6

[Done 1.3.5] No Tax Basis calc using Zones shipping module

Looking at includes/modules/shipping/zones.php...Line 112->

function zones() {
      $this->code = 'zones';
      $this->title = MODULE_SHIPPING_ZONES_TEXT_TITLE;
      $this->description = MODULE_SHIPPING_ZONES_TEXT_DESCRIPTION;
      $this->sort_order = MODULE_SHIPPING_ZONES_SORT_ORDER;
      $this->icon = '';
      $this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;
      $this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;

Is that correct that the last 2 lines are identical?

Development Manager @ JSWeb Ltd - suppliers of Applepay/Googlepay for Zencart
20 years with Zencart !

13 Aug 2006, 2:35 AM

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,511
Plugin Contributions:: 176

Re: [Done 1.3.5] No Tax Basis calc using Zones shipping module

Good catch.

Should be:```php
$this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;
$this->tax_basis = MODULE_SHIPPING_ZONES_TAX_BASIS;

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

13 Aug 2006, 10:46 AM

ryk

Totally Zenned

Join Date:: Oct 2004
Location:: Southport, UK
Posts:: 3,644
Plugin Contributions:: 6

Re: [Done 1.3.5] No Tax Basis calc using Zones shipping module

This is not exclusive to 1.3 by the way - that exists at least as far back as 1.2.6

Development Manager @ JSWeb Ltd - suppliers of Applepay/Googlepay for Zencart
20 years with Zencart !