Text Box Dissapears

Just discovered something rather worrying with regard to all the text box attributes on my site which have "Attribute Required for Text"

Basically when the product page is first opened the text box appears however if it is left blank and the item is added to the cart the order goes through without coming up with the standard alert.

If there are two attributes on a page say a drop down which is required as well the error comes up for that however this also causes the test box to dissapear.

Any ideas?

Url: http://www.celtmyth.co.uk/pages-productinfo/category-63/product-956/personalised-mugs-angled-name-full-colour-wrap.html

Cheers
Brinley

There is a setting on the Attributes specifically for Text Attributes to make them required ...

Attribute Required for Text:
No Yes

Hi Linda - thanks for responding

I have the Attribute required for text set to yes - see screenshot

Any advice would be appreciated

Cheers
Brinley

We fondly call this feature a bug ... :smartass:

Edit the /includes/functions/functions_lookup.php and around line 419 change the code to read:

// text required validation
    if (ereg('^txt_', $option)) {
//      $check_attributes = $db->Execute("select attributes_display_only, attributes_required from " . TABLE_PRODUCTS_ATTRIBUTES . " where products_id='" . (int)$product_id . "' and options_id='" . ereg_replace('txt_', '', (int)$option) . "' and options_values_id='0'");
      $check_attributes = $db->Execute("select attributes_display_only, attributes_required from " . TABLE_PRODUCTS_ATTRIBUTES . " where products_id='" . (int)$product_id . "' and options_id='" . ereg_replace('txt_', '', $option) . "' and options_values_id='0'");
// text cannot be blank
      if ($check_attributes->fields['attributes_required'] == '1' and empty($value)) {
        $check_valid = false;
      }
    }

See if that works for you ...

Hi Linda

Thanks for having a pop at a solution.

I made the amendments you suggested but still no change unfortunately - the text fields still dissapear if alongside dropdowns and also the text fields dont cause an alert if left blank.

odd ... I have it working in my version that is about to be released ...

I will have to see if there is more changes that might effect this ...

Meanwhile ... switch to Classic ... does it work then?

I'm still on version 1.2.6 on all my sites - I assume u are running the latest version.

I am still building up the courage to upgrade all the sites - do you know if this is a bug in the latest version as well?

Actually ... this bug is not really in my v1.3.0.2 ... I know I just fixed it for the next release but we are cleaning code for other things and could of caused it ourselves and it has now been caught for the next release ...

I have not had time to reinstall v1.3.0.2 to see if there are or are not issues ...

It may have been a bug in that oldm old v1.2.6 that you are using that was fixed in v1.2.7 ...

I have had no complaints until now about it that I can recall ... but your report of an issue did help me to locate it in the upcoming release to get it fixed before it gets released ... :cool:

You might consider trying a test install of v1.2.7 into a test database with the demo products and see if you can break it again ...

If not, then upgrading to at least v1.2.7 might be an option while you are working on an upgrade to v1.3.0.2 ...

I think what i will do is just disable all text required attribs in my existing carts - that way they are still usuable - and then upgrade them all to the latest version in the next couple of weeks.

Once again thanks for the brill help - u truly are a blessing for sorting out problems and giving (good) advice

Cheers
Brinley

Im actually having this same problem (not sure about them disappearing but it will still let me check out with no text entered)

Is there a solution for this yet? or is it on my end? Its a fresh copy of 1.3.5 so I wouldnt think it would be on my end.

Thanks!

Did you mark the Attributes that are for the text as TEXT Required?

Yep I sure did. This has totally stumped me haha

Have you an URL to a Product using the text attributes?

Sure

http://crystalclearwatercompany.com/shop/index.php?main_page=product_info&cPath=5&products_id=4

Thanks for the quick replys

What version Zen Cart are you running?

Clean install or an upgrade?

If an upgrade, from what version and how?

What happens if you switch to Classic?

Its a clean install Version 1.3.5 (latest one)

Same thing happens if i switch over to classic.

Do you have add-ons or anything added?

Have you only used the templates and overrides directories for all customizations?

I do have the Ty's Package Tracker installed, but thats it.

Yes I only use the overrides.

If you like ... you may PM me an URL to your Admin and a login/password so I can see what might be wrong here ...

Hey, I know i said not to worry about it but I was just informed that I need to have the text attributes required. I can probably figure it out but i was wondering if you could help in which file(s) I should be looking in. Like what file tells the script to give an error when no text is entered.

Thanks!