If this is your first visit, check our documentation. To post, register or login.
Forums / Addon Sideboxes / Links Manager 1.5 Makes XHTML Not Pass

Links Manager 1.5 Makes XHTML Not Pass

Locked

Started by bettysue on 23 Aug 2006, 9:22 PM · Views: 2,425

Results 1 to 8 of 8
This thread is locked. New replies are disabled.
23 Aug 2006, 9:22 PM
#1
bettysue avatar

bettysue

Inactive

Join Date:
May 2004
Posts:
747
Plugin Contributions:
0

Links Manager 1.5 Makes XHTML Not Pass

Hi,

I installed Links Manager 1.5 on a Zencart v 1.302 store and as far as working right, I have no issues (mod is listed as 1.3 compatible).

What I am having a problem with is passing the w3.org xhtml validation. The site validated and passed prior to this mod. Now it is showing 5 errors.

The errors are mainly from the image widths, heights and border tags not being encased by quotation marks. There is another saying that an end bracket is missing or something similar.

I looked through all the template files and module files and came to the realization that I am clueless as to how to fix the issues.

When initially doing the validation yesterday I was able to fix about 30 validation errors, however none of them went into the module level and it was before adding the links manager.

I would appreciate any advice.

The validation results can be seen here

Thank You,

betty

23 Aug 2006, 10:17 PM
#2
Kim avatar

Kim

Obaa-san

Join Date:
Jun 2003
Location:
West Coast, North America
Posts:
26,747
Plugin Contributions:
0

Re: Links Manager 1.5 Makes XHTML Not Pass

    <td colspan="3" class="rightboxcontent" id="bannerbox2-content">
<div id="bannerbox2Content" class="sideBoxContent centeredContent"><a href="http://jacksbargainbin.mydollarshop.com/makemoney"><img src="http://jacksbargainbin.mydollarshop.com/creative/1/120x60.gif" width=120 height=60 border=0></a></div>    </td>

For XHTML compliance, images need to have a self-close. instead of >, it needs to be /> It should take care of the problems.

Please do not PM for support issues: a private solution doesn't benefit the community.

Be careful with unsolicited advice via email or PM - Make sure the person you are talking to is a reliable source.

23 Aug 2006, 11:10 PM
#3
bettysue avatar

bettysue

Inactive

Join Date:
May 2004
Posts:
747
Plugin Contributions:
0

Re: Links Manager 1.5 Makes XHTML Not Pass

Thank you for the info Kim,

  1. At least you just help me realize that the 5 errors aren't being caused by the template, but instead the **right side banner_box2 ** :blush: that the site owner apparently turned on last night. Where would I change the end tag for the image to be xhtml compliant?

A warning it had given initially that was due to the mod which I removed the tags all together to fix, but really would like to put back in only the right way.
It rejected where the <b> (bold tags) began in the sidebox template by the BOX_INFORMATION_VIEW et al. (I put them back where they were to show up here)

 $content = "";
   for ($i=0, $n=sizeof($links_array); $i<$n; $i++) {
    $content .= '<a href="' . zen_href_link(FILENAME_LINKS, '', 'NONSSL') . '&lPath';
    $content .= '=' . zen_output_string($links_array[$i]['id']) . '"';
    $content .= '>' . zen_output_string($links_array[$i]['text'], array('"' => '"', '\'' => ''', '<' => '<', '>' => '>')) . '</a><br/>';
  }
  if (BOX_DISPLAY_VIEW_ALL_LINKS == 'true') {
  $content .= '<br/><b><a href="' . zen_href_link(FILENAME_LINKS, '', 'NONSSL') . '">' . BOX_INFORMATION_VIEW_ALL_LINKS . '</b></a>';
}
   if (BOX_DISPLAY_SUBMIT_LINK == 'true') {
  $content .= '<br/><b><a href="' . zen_href_link(FILENAME_LINKS_SUBMIT, '', 'NONSSL') . '">' . BOX_INFORMATION_LINKS_SUBMIT . '</b></a>';
}
?>

So as of right now, the checker is giving 9 error messages instead of the 5 it had before I put the bold tags back in.

Thank you!

betty

23 Aug 2006, 11:55 PM
#4
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,512
Plugin Contributions:
176

Re: Links Manager 1.5 Makes XHTML Not Pass

if (BOX_DISPLAY_VIEW_ALL_LINKS == 'true') {
$content .= '<br/><b><a href="' . zen_href_link(FILENAME_LINKS, '', 'NONSSL') . '">' . BOX_INFORMATION_VIEW_ALL_LINKS . '</b></a>';
}
if (BOX_DISPLAY_SUBMIT_LINK == 'true') {
$content .= '<br/><b><a href="' . zen_href_link(FILENAME_LINKS_SUBMIT, '', 'NONSSL') . '">' . BOX_INFORMATION_LINKS_SUBMIT . '</b></a>';
}

I suggest you reverse these, so that nesting is maintained: </b></a>

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

24 Aug 2006, 12:01 AM
#5
bettysue avatar

bettysue

Inactive

Join Date:
May 2004
Posts:
747
Plugin Contributions:
0

Re: Links Manager 1.5 Makes XHTML Not Pass

Thank you Dr. Byte!

That got rid of the 4 mod warnings, now it's just down to the 5 being caused by the banner_box2. :cry:

Mucho thanks again!

betty

24 Aug 2006, 2:13 AM
#6
bettysue avatar

bettysue

Inactive

Join Date:
May 2004
Posts:
747
Plugin Contributions:
0

Re: Links Manager 1.5 Makes XHTML Not Pass

:oops:

This issue has turned into yet another duh moment by Betty.

After searching both with Homesite and with the Admin dev. toolkit to find any and all references to banner_box2 and finding no where I could modify the end image tag, I decided to go inside the banner manager.

Low and behold in the settings for the banner that the client put up last night was the problem rearing it's ugly face to me.

He had put in the banner as an html one and it was his image statement that was causing the errors :lamo:

Now for the screwed up version - The site validates in the w3.org validator with no warnings or issues. Yet now when I go to the CSS validator (made no changes to the files since yesterdays validation), I get the message:

**Please, validate your XML document first!

Line 295

Column 198

Open quote is expected for attribute "width" associated with an element type "img". **

Line 295 is the banner line again which passed the xhtml validator, so I'm VERY confused. This is the whole banner statement:

<a href="http://jacksbargainbin.mydollarshop.com/makemoney" target="_blank"><img src="http://jacksbargainbin.mydollarshop.com/creative/1/120x60.gif" width="120" height="60" border="0" alt="Own Your Own Dollar Store" /></a>

Any clues?

betty

24 Aug 2006, 5:08 PM
#7
designbydemeter avatar

designbydemeter

Zen Follower

Join Date:
Jun 2006
Location:
Taos,NM
Posts:
225
Plugin Contributions:
0

Re: Links Manager 1.5 Makes XHTML Not Pass

If I can piggyback on this, as I'm relearning XHMTL in order to move on too CSS (so I can stop asking so many questions about it~)

I understand the ampersand issue and why its not validating in the URL, but where oh where do I make the modificaton from '&' to &amp ?

Also, the validation seems to be tagging all the "id" and "chapters" as well.

I'm working from home today so i can start getting a handle on these clean up issues and would love a nudge in the right directions.

Thanks all~
Laura

Laura M Collins Invitation Designs

"The best way to navigate in a new area is to first get totally lost in it."...Mike L. Stein

28 Nov 2006, 7:45 AM
#8
miles avatar

miles

Zen Follower

Join Date:
Oct 2006
Location:
At Home
Posts:
357
Plugin Contributions:
0

Re: Links Manager 1.5 Makes XHTML Not Pass

i have the same issue. i installed links manager 2.0f and cant validate.

Line 157 column 142: end tag for "br" omitted, but OMITTAG NO was specified

....ain_page" value="links" /></form><br><b><a href="http://test-site

- Nothing is impossible. Some things are just less likely than others. -