Stock by Attribute v4.0 addon for v1.3.5-1.3.9

jimmie:

Thank you, u already know you are a coding genius, LOL
one more thing, when products are not in stock a banner in reds tells the customer this, but banner doesnt show with attributes out of stock

Regarding this "message", for some reason I'm not seeing where/what generates the one for the base product... seems like for me to recreate it in one of my test sites that I may need to know what the settings for the site are regarding stock control... I can recall that there were at one time some different "messages" made available on the shopping cart page, but then in later versions some things changed... I still have some older carts setup and could recreate the message for sba product if I could find out what created it for the base product.

this is the define file /var/www/clients/client1/web4/web/includes/languages/english/shopping_cart.php

Line #43 : define('OUT_OF_STOCK_CAN_CHECKOUT', 'Products marked with ' . STOCK_MARK_PRODUCT_OUT_OF_STOCK . ' Can be DropShipped.<br />Items in your Cart that are Special Ordered can be DropShipped from are Distributor to you.(Guaranteed Delivery 1-7 Business Days)<br />(Please Note, if you choose Our Standard Shipping Methods and your cart contains Stock and Non-Stock items we will wait until all Items become Available. Usually within 2-14 Days)<br />If there is an exception with your Order you are Guaranteed Notification Within (1) Business Day.');

mc12345678:

I just was able to add a "special order" product to the cart and was provided a notification that there was special ordering required (when viewing shipping options from the shopping cart page), I added an instock product and had the same options overall, then removed the special order product and was provided a different series of shipping options. Don't recall which "special order" product I selected, but from my perspective and limited knowledge of the site, it seemed like something was handled correctly.

i have to two shipping modules activated standard shipping and vendor shipping, you should not see same method, stock vs nonstock. stock 1-2 days shipping, nonstock 7 - 14 days, i put a #1 in title of vendor shipping when all stock in cart, and a # 2 in nonstock when all nonstock in cart, #2 nevers shows, also when looking at sono product, hit listing goto sono tile, has a Red light (NonStock item), i didnt add attributes to that yet

So I removed everything and installed it all back for a clean slate.
Anytime I add a quantity on the SBA page I get a msg at the top I get "Update failed" but looks like it took it.

I added two attributes, one to pick type of vinyl and the second to pick color.
I feel it is working backwards now. If I list a product in the zc_products_with_attributes_stock_attributes_non_stock` it shows that it is in stock. The items that are out of stock no longer show in the drop down as out of stock.

cubmanky:

So I removed everything and installed it all back for a clean slate.
Anytime I add a quantity on the SBA page I get a msg at the top I get "Update failed" but looks like it took it.

I added two attributes, one to pick type of vinyl and the second to pick color.
I feel it is working backwards now. If I list a product in the zc_products_with_attributes_stock_attributes_non_stock` it shows that it is in stock. The items that are out of stock no longer show in the drop down as out of stock.

In the update failed message there should be some information related to what failed or how it failed. It is likely something simple, but there isn't a "update kind of completed" setting. :)

As for the display being different, that's back to individual settings of what should be displayed related to stock items. Not everyone wants to have their "out-of-stock" items displayed.

Ohhh. Wait, the update failed message on modifying product, yes, there were some changes made to processing which is causing that message to appear. I've been working on the background code to provide the proper display. No its not as simple as just "always" forcing the message. It currently is likely to identify it failed when it actually succeeded. I haven't seen it identify success when it actually failed.

In otherwords it's more likely a false failure.

My biggest question now is why is the non stock working backwards. Items I place in non stock is only showing as the only items that are in stock

cubmanky:

My biggest question now is why is the non stock working backwards. Items I place in non stock is only showing as the only items that are in stock
Two things. Since you are using two attributes for one product, now also need to consider the setting for dynamic dropdowns (separate configuration menu). The other thing regarding display of quantities depends on how the variants are defined. If you are using two attributes on a product then either the two attributes need to be defined as a pair and an individual quantity assigned to that pair or each attribute individually with quantity assigned to the individual attributes. The availability will be determined by the lowest number of the combination attempting to identify a combination by mixing the attributes together first and if none found then by individual attribute.

As to the non-stock items, that table and it's usage is to allow items to be considered against a product that is tracked by stock where those items may not necessarily be a stock related item. Ie. A gift bag, to include a receipt or not, to be contacted about the product in the future, to put a cherry on top, etc... it's different than how it is desired to work here, but that's no matter, it is intended to follow the same thought: allow the purchase of the product with this/these attributes selected even though there is not a specific stock quantity assigned.

Hi all. I have an issue with the SBA add-on after upgrade to MySQL 5.7.24.

PHP Fatal error: 1140:In aggregated query without GROUP BY, expression #1 of SELECT list contains nonaggregated column 'freedomh_zencart.pwas.quantity'; this is incompatible with sql_mode=only_full_group_by :: select distinct pwas.quantity as quantity, count(distinct pwasans.attribute_type) as pwasans_quantity from products_with_attributes_stock pwas, products_with_attributes_stock_attributes_non_stock pwasans

This SELECT is in file /public_html/includes/classes/pad_sba_sequenced_dropdowns.php. It is quite a complicated looking SQL statement (for me anyway) with a number of OR statements. I'm assuming I need to add a GROUP BY statement in this SQL Statement, but not sure where. The other option would be to update SQL_MODE and remove the ONLY_FULL_GROUP_BY setting, but doesn't look like the correct thing to do here.

Any ideas how to correct or make this SELECT statement work with MySQL 5.7.24?

I'm running Zen Cart 1.5.5f, Database Patch Level: 1.5.5. Everything else seems find except when you hit the product Detail Screen and it hits this code.

Thanks for any pointers.

Chris

SQL as follows:

From file /public_html/includes/classes/pad_sba_sequenced_dropdowns.php

        $attribute_stock_query = "select distinct pwas.quantity as quantity, count(distinct pwasans.attribute_type) as pwasans_quantity from " . TABLE_PRODUCTS_WITH_ATTRIBUTES_STOCK . " pwas, " . TABLE_PRODUCTS_WITH_ATTRIBUTES_STOCK_ATTRIBUTES_NON_STOCK . " pwasans 
            where pwasans.attribute_type = :products_options: 
              and pwasans.attribute_type_source_id = :products_id: 
              AND pwasans.attribute_type_id = (
                SELECT pa.options_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
                   WHERE pa.products_id = :products_id: 
                     AND pa.options_values_id = :options_values_id:) 
              OR (
                  pwasans.attribute_type = :products_values: 
                  AND pwasans.attribute_type_source_id = :products_id:
                    AND pwasans.attribute_type_id = :options_values_id:
                    " . /*(SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
                      WHERE pa.products_attributes_id = :check_attribute_id:) */ "
                )
              OR (
                  pwasans.attribute_type = :values: 
                  AND pwasans.attribute_type_source_id = 0
                    AND pwasans.attribute_type_id = :options_values_id:
                    AND pwasans.attribute_type_id = (SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa
                      WHERE pa.products_id = :products_id:
                          AND pa.options_values_id = :options_values_id:)
                    " . /*(SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
                      WHERE pa.products_attributes_id = :check_attribute_id:) */ "
                )
              OR (
                  pwasans.attribute_type = :options: 
                  AND pwasans.attribute_type_source_id = 0
                    AND pwasans.attribute_type_id = :options_values_id:
                    AND pwasans.attribute_type_id = (SELECT pa.options_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa
                      WHERE pa.products_id = :products_id:
                          AND pa.options_values_id = :options_values_id:)
                    " . /*(SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
                      WHERE pa.products_attributes_id = :check_attribute_id:) */ "
                )
              
              
              OR pwas.products_id = :products_id: 
              " . (STOCK_ALLOW_CHECKOUT !== 'false' 
                ? "" 
                : "AND pwas.quantity > 0 ") . "
                AND pwas.stock_attributes 
                   like (SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
                     WHERE products_id = :products_id: 
                       and options_values_id = :options_values_id:) 
              OR pwas.products_id = :products_id: AND pwas.stock_attributes 
                like CONCAT((SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
                   WHERE products_id = :products_id: 
                     and options_values_id = :options_values_id:),',%') 
              " . (STOCK_ALLOW_CHECKOUT !== 'false' 
                ? "" 
                : "AND pwas.quantity > 0 ") . "
              or pwas.products_id = :products_id: 
                AND pwas.stock_attributes 
                like CONCAT('%,',(SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
                  WHERE products_id = :products_id: 
                    and options_values_id = :options_values_id:),',%') 
              " . (STOCK_ALLOW_CHECKOUT !== 'false' 
                ? "" 
                : "AND pwas.quantity > 0 ") . "
              or pwas.products_id = :products_id: 
                AND pwas.stock_attributes 
                like CONCAT('%,',(SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
                  WHERE products_id = :products_id: 
                    and options_values_id = :options_values_id:))
              " . (STOCK_ALLOW_CHECKOUT !== 'false' 
                ? "" 
                : "AND pwas.quantity > 0 ");

gohealth:

Hi all. I have an issue with the SBA add-on after upgrade to MySQL 5.7.24.

PHP Fatal error: 1140:In aggregated query without GROUP BY, expression #1 of SELECT list contains nonaggregated column 'freedomh_zencart.pwas.quantity'; this is incompatible with sql_mode=only_full_group_by :: select distinct pwas.quantity as quantity, count(distinct pwasans.attribute_type) as pwasans_quantity from products_with_attributes_stock pwas, products_with_attributes_stock_attributes_non_stock pwasans

This SELECT is in file /public_html/includes/classes/pad_sba_sequenced_dropdowns.php. It is quite a complicated looking SQL statement (for me anyway) with a number of OR statements. I'm assuming I need to add a GROUP BY statement in this SQL Statement, but not sure where. The other option would be to update SQL_MODE and remove the ONLY_FULL_GROUP_BY setting, but doesn't look like the correct thing to do here.

Any ideas how to correct or make this SELECT statement work with MySQL 5.7.24?

I'm running Zen Cart 1.5.5f, Database Patch Level: 1.5.5. Everything else seems find except when you hit the product Detail Screen and it hits this code.

Thanks for any pointers.

Chris

SQL as follows:

From file /public_html/includes/classes/pad_sba_sequenced_dropdowns.php

    $attribute_stock_query = "select distinct pwas.quantity as quantity, count(distinct pwasans.attribute_type) as pwasans_quantity from " . TABLE_PRODUCTS_WITH_ATTRIBUTES_STOCK . " pwas, " . TABLE_PRODUCTS_WITH_ATTRIBUTES_STOCK_ATTRIBUTES_NON_STOCK . " pwasans 
        where pwasans.attribute_type = :products_options: 
          and pwasans.attribute_type_source_id = :products_id: 
          AND pwasans.attribute_type_id = (
            SELECT pa.options_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
               WHERE pa.products_id = :products_id: 
                 AND pa.options_values_id = :options_values_id:) 
          OR (
              pwasans.attribute_type = :products_values: 
              AND pwasans.attribute_type_source_id = :products_id:
                AND pwasans.attribute_type_id = :options_values_id:
                " . /*(SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
                  WHERE pa.products_attributes_id = :check_attribute_id:) */ "
            )
          OR (
              pwasans.attribute_type = :values: 
              AND pwasans.attribute_type_source_id = 0
                AND pwasans.attribute_type_id = :options_values_id:
                AND pwasans.attribute_type_id = (SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa
                  WHERE pa.products_id = :products_id:
                      AND pa.options_values_id = :options_values_id:)
                " . /*(SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
                  WHERE pa.products_attributes_id = :check_attribute_id:) */ "
            )
          OR (
              pwasans.attribute_type = :options: 
              AND pwasans.attribute_type_source_id = 0
                AND pwasans.attribute_type_id = :options_values_id:
                AND pwasans.attribute_type_id = (SELECT pa.options_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa
                  WHERE pa.products_id = :products_id:
                      AND pa.options_values_id = :options_values_id:)
                " . /*(SELECT pa.options_values_id FROM " . TABLE_PRODUCTS_ATTRIBUTES . " pa 
                  WHERE pa.products_attributes_id = :check_attribute_id:) */ "
            )
          
          
          OR pwas.products_id = :products_id: 
          " . (STOCK_ALLOW_CHECKOUT !== 'false' 
            ? "" 
            : "AND pwas.quantity > 0 ") . "
            AND pwas.stock_attributes 
               like (SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
                 WHERE products_id = :products_id: 
                   and options_values_id = :options_values_id:) 
          OR pwas.products_id = :products_id: AND pwas.stock_attributes 
            like CONCAT((SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
               WHERE products_id = :products_id: 
                 and options_values_id = :options_values_id:),',%') 
          " . (STOCK_ALLOW_CHECKOUT !== 'false' 
            ? "" 
            : "AND pwas.quantity > 0 ") . "
          or pwas.products_id = :products_id: 
            AND pwas.stock_attributes 
            like CONCAT('%,',(SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
              WHERE products_id = :products_id: 
                and options_values_id = :options_values_id:),',%') 
          " . (STOCK_ALLOW_CHECKOUT !== 'false' 
            ? "" 
            : "AND pwas.quantity > 0 ") . "
          or pwas.products_id = :products_id: 
            AND pwas.stock_attributes 
            like CONCAT('%,',(SELECT products_attributes_id from " . TABLE_PRODUCTS_ATTRIBUTES . " 
              WHERE products_id = :products_id: 
                and options_values_id = :options_values_id:))
          " . (STOCK_ALLOW_CHECKOUT !== 'false' 
            ? "" 
            : "AND pwas.quantity > 0 ");

While I don't have mysql 5.7 currently installed to test and haven't yet forced the same requirement as what set off this error, my initial test under 5.6.xx worked by changing line 267 from:

            : "AND pwas.quantity > 0 ");

To:

            : "AND pwas.quantity > 0 ") . "
            GROUP BY pwas.quantity";

I'll see about changing the server's settings, but wanted to report what looked like would work.

mc12345678:

While I don't have mysql 5.7 currently installed to test and haven't yet forced the same requirement as what set off this error, my initial test under 5.6.xx worked by changing line 267 from:

            : "AND pwas.quantity > 0 ");

> To:
> ```
                : "AND pwas.quantity > 0 ") . "
                GROUP BY pwas.quantity";

I'll see about changing the server's settings, but wanted to report what looked like would work.
I can confirm that setting the db mode to ONLY_FULL_GROUP_BY and incorporating the above modification fixes that issue. Please let me know if other such issues arise so that they may be addressed.

As to the complexity of the query, well, some of that is because of how the SBA table has more information in a field than it should for trying to have a normalized database. There is a plan to split the data out a little more but is a bit of an overhaul of the underlying system.

Excellent! Yes, the above worked. There were also some problems when doing Admin creations of products and I'll need to test that as well. But thanks very much for the below. Really looking forward to this module becoming more permanent in future ZenCart releases... it always makes me nervous at upgrade and patching time!

mc12345678:

I can confirm that setting the db mode to ONLY_FULL_GROUP_BY and incorporating the above modification fixes that issue. Please let me know if other such issues arise so that they may be addressed.

As to the complexity of the query, well, some of that is because of how the SBA table has more information in a field than it should for trying to have a normalized database. There is a plan to split the data out a little more but is a bit of an overhaul of the underlying system.

So a new puzzle. I have some of my decals that are family. SO I need to use SBA for picking the vinyl color, but then non SBA attributes for picking family members. When I add that attribute they are coming in as SBA How do I keep them out of SBA.

cubmanky:

So a new puzzle. I have some of my decals that are family. SO I need to use SBA for picking the vinyl color, but then non SBA attributes for picking family members. When I add that attribute they are coming in as SBA How do I keep them out of SBA.
I think I somewhat understand what is desired, but I don't understand what problem is being seen.

What I understand is that there are two attributes with the product:
Stock dependent color
Non-stock dependent "person"

The attributes associated with the person should be added to the non-stock table.
The colors should be assigned stock quantities.
If not mistaken that is all that is needed to then support selecting each of the options and stock getting reduced for the vinyl/color. Right now, I very well could be mistaken.

Has this module been correctly updated for 1.5.6?
I downloaded it from github last week and the 1.5.6 folder contained files which whilst showing as 1.5.6, when running a 3 file comparison between stock 1.5.5, 1.5.6, and the SBA 1.5.6 file, some appeared to be 1.5.6 files with the 1.5.5 edits for SBA, completely removing changes made by the zc devs when creating 1.5.6.

Whislt I expect this will work, I don't know whether to use these files, or manually merge in the SBA edits to stock 1.5.6 files instead

strelitzia:

Has this module been correctly updated for 1.5.6?
I downloaded it from github last week and the 1.5.6 folder contained files which whilst showing as 1.5.6, when running a 3 file comparison between stock 1.5.5, 1.5.6, and the SBA 1.5.6 file, some appeared to be 1.5.6 files with the 1.5.5 edits for SBA, completely removing changes made by the zc devs when creating 1.5.6.

Whislt I expect this will work, I don't know whether to use these files, or manually merge in the SBA edits to stock 1.5.6 files instead
When previously checked had been looking at the original incorporation of ZC 1.5.6 files. A lot had changed since then. Last week a separate branch was created to specifically incorporate the ZC 1.5.6 changes. That branch has been incorporated into the master fileset. There are far fewer merges necessary with the ZC 1.5.6 fileset. There may even be a few fewer merges necessary to the files.

I still haven't checked through the installer program to validate that it will report a full successful install, but by that point in the code, the database should be up-to-date and should function. (famous last words, right?)

There have been some code updates as well to align more with the current ZC coding expectations (early return when a data condition is known, reduction of use of else statements where possible and it makes sense, additional strict control handling, etc...)

Thanks for the reply mc12345678. I'll grab the latest from your github account and take another look.

Doubt this will be a short story, but will try to keep it as short as possible.

When working in ZC versions 1.5.6 or 1.5.6a (so far), it is possible that there is a problem from the admin where a warning is thrown about ```
trim() expects parameter 1 to be string, object given in YOUR_ADMIN/includes/functions/general.php on line 441

Another zenner and I were trying to track down the issue.  Specifically it had been experienced when working with the attributes controller and I had come across it from another admin page.  We each came up with a different solution.  So I wanted to test both solutions as it applied to the attributes controller and specifically a product that had attribute images.  On the demo site tested, I had SBA installed and ZC 1.5.6a (plus other currently proposed changes for revision b).  Problem was that once I found a demo product that had attribute images (products_id=54), they were not displaying.  Come to find out, although I had at one time corrected the issue, I had reintroduced it.  I haven't gone through the detailed history to discover when it occurred, but I can say that before the below fix, if the option name's manager setting of displaying the option's image is set to other than 1 or 2 that there is a problem for product not controlled by SBA.

I have updated the observer class with the following git commit to allow attribute images to be displayed for all option name settings of all product and controlled as "hidden" with main image swap for just SBA product.  The hidden aspect is not limited to just the SBA options that are set to: 'SBA Select List (Dropdown) Basic' where the swap feature is made available.

Anyways, the patch for this issue is available at: <https://github.com/mc12345678/Stock_By_Attributes_Combined/commit/fa45a3f3c62976c8e4624120c7430cce55ed7f5a#diff-abdd8646c20ce6505cfc2e56a863263c>

i have been trying to install this on a new website (7 times now) and it always end the same, products attributes names turns out like this
i am using a demo product
2 attributes
suppose to be
premium
deluxe
instead i get this
Out of Stock :
Out of Stock: Out of Stock
if i add another attribute name then it turns out like this[
Out of Stock :
Out of Stock: Out of Stock
Out of Stock: Out of Stock: Out of Stock

jimmie:

i have been trying to install this on a new website (7 times now) and it always end the same, products attributes names turns out like this
i am using a demo product
2 attributes
suppose to be
premium
deluxe
instead i get this
Out of Stock :
Out of Stock: Out of Stock
if i add another attribute name then it turns out like this[
Out of Stock :
Out of Stock: Out of Stock
Out of Stock: Out of Stock: Out of Stock

Could you please provide more detail?
For starters, from where/what download link was the software obtained?
What version of Zen Cart?

Once installed, what are the settings for: configuration->Dynamic Dropdowns?
What are the settings for: configuration->Stock in particular those towards the end of the list.
what has been done to populate a product or does this issue occur without trying to do anything to populate it?

im using Stock_By_Attributes_Combined-master in zen version 1.51 from the github link, dynamic dropdown setting are defaulted to whatever they r set in installation.
i setup database with demo products,
stock settings

dynamic dropdowns

i am using the this product for testing
http://jnsflooringandsupplies.com/WORKINPROGRESS/index.php?main_page=product_info&cPath=1_4&products_id=2