Stock by Attribute v4.0 addon for v1.3.5-1.3.9

trollboy:

That is what I thought should happen, but t doesn't seem to be working properly. When I look at the Stock by Attributes admin page, the stock appears at the product level for any products for which I haven't set indivdual stocks by attribute. However, when I try and buy one of these products, the shopping cart tells me that there s not enough stock. If I "synchronise stock" on the Stock by Attributes admin page the stock value gets reset to zero, It seems as though the stock at the product level is not being recognised.
Any ideas as to what might be wrong?Sorry my earlier response wasn't very well-crafted. I'll try to make it a little more clear, though I fear you won't much like the answer.

The way the mod works is that once you enable stock by attribute it takes over the management of stock levels for all products with attributes. So if you have a product with attributes for which you do not create any variants and give them stock, then when a customer tries to buy them, the mod will return zero stock levels. This is not immediately obvious as the product stock level is not updated when the mod is first installed, but when you sync the stock, the product stock will go to zero. Products that have no attributes will continue to use the product stock level.

You can return to using only product level stock figures by uninstalling the mod (basically by over-writing the six core Zen Cart files changed by this mode and listed in the release notes with the equivalents from a default Zen Cart installation. You would then need to reset the stock for those products to which you had allocated product variants or synced the stock values.

Can you tell me a little more background to what you are trying to do so that I can take it into account for future Attribute Stock requirements?

bobage24:

I have installed this mod, but I am not sure if this is normal. I have a size set up for selling shirts. I only have them in size M,L,XL, but my attribute is for all sizes, so it includes S and XXL, XXXL. But I have zero of these in stock, but they are still showing up on the items page. Is this normal? Is there a way to make it so that the items not in stock don't show up as options?

Thanks,
BobHi Bob

Yes this is normal. The options showing in the product info page are built by core Zen Cart code that doesn't know anything about the stock values maintained by this add-on.

If you have just one attribute (size) there are other threads that refer to the "Grayson" solution for displaying attribute stock levels on the product_info page. This solution could be tweaked to instead suppress display of the option.

kuroi:

Can you tell me a little more background to what you are trying to do so that I can take it into account for future Attribute Stock requirements?

I have a mix of products, some of which require stock by attributes (e.g. tea-light holders which come in small, medium and large). But I also sell cushion covers, which I want to be able to sell with or without the cusion. This is more of a stock by raw materials problem, but since I have lots of cushions I was just going to keep track of stock using the total number of cushion covers sold, with or without cushions inside.
So the product is priced by attribute (with cushion or without), but I want to opt out of keeping track of the stock by attributes.

Is there any reason that all products with attributes have to be included in stock by attributes? Would it be difficult to add an option to allow products to opt out of tracking stock by attributes?

You have an example of what I think of as the "gift wrapping" problem. A situation where one of the attributes of a product refers to something that accompanies the product and has stock that is completely independent of that of the product itself. Ironcially, your attribute goes on the inside, rather than the outside.

It probably wouldn't be too difficult to extend the mod to cope with this, but there are no plans to do so. The reason for this is that the functionality is due to be incorporated into the next major release of Zen Cart and to push it to the next level will require a complete rewrite (in fact a completely different approach), so any changes made now would have a short life and make migration to the next release more difficult. However, coping with exactly the situation that you describe looms large in my recommendations to the Zen Cart team.

Thanks Kuroi, will get a copy today

Kind regards,

Goshawk

kuroi:

Hi Frank. Glad you solved the problem, and thanks for posting the answer. It's always helpful when people do that as Zen Cart now has such a large base that sooner or later somebody else will probably do something similar.

The Zen Cart 1.3.6 version (mod version 4.3) is now available in the download section. Due to my other commitments it's less extensively tested than previous releases. The changes shouldn't have introduced any new problems, but if you find any please post them.

I strongly recommend upgrading to this version as it incorporates some of the security changes added to Zen Cart 1.3.6.

If you are using languages other than English or French, you will need to make some minor adjustments to the language files, otherwise upgrading is simply a matter of overwriting your existing mod files.

First, a little bug that I found in your new release by using beyond compare with older ones.

In functions_lookups.php on line 163:

function zen_get_products_stock($products_id) {

should've been:

/* function zen_get_products_stock($products_id) {

Next, I applied a fix by Grayson posted in archived threads to show qty of attributes on product info page. For those who still having trouble with this fix, I am including the attributes.php file here. You may drop it in includes/modules/your_template/ folder.

I am also including another alternative version of this fix (I take no credit whatsoever on this), which shows attribute stock after price_fix and weight etc. display, which makes more sense to myself, becasue this way customer won't confuse stock level with quantity discounts/surcharges. This alternative file is called attributes_Alternative.php. You need to rename it to attributes.php to overwrite the existing one when using.

Don't forget to add a define to the product_info.php in includes/languages/english/your_template folder, such as:
[quote][define('TEXT_ATTRIBUTES_PIECES','pieces');/QUOTE]. I use 'in stock' instead of 'pieces', for it makes more sense.

Now, I need help for myself!! I tried hard to set a "display only" option value such as " select from below" to NOT show stock level, which is a conditional undone of the above fix in attributes.php. I tried codes as follows, but no luck:

/*

• check if attribute is display only
  */
  global $db;
  $check_attributes = $db->Execute("select *
  from " . TABLE_PRODUCTS_ATTRIBUTES . "
  where products_id = '" . (int)$products_id . "'
  and options_id = '" . (int)$option . "'
  and options_values_id = '" . (int)$value . "'");

if ($check_attributes->fields['attributes_display_only'] == '1') {
$products_options_value_id = $products_options->fields['products_options_values_id'];
$products_options_details = $products_options->fields['products_options_values_name'];
$products_options_details_noname = $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '<br />' . $products_options_display_weight : '');
}

This block of codes were applied after the "// prepare product options details" section and before "//radio buttons" section.

Any help on this would be greatly appreciated!

Hi Frank

I'm not sure whether the bug that you pointed out would have any functional implications, but it's clearly wrong so I've updated the release pack to 4.3.1. Many thanks for pointing it out.

In respect of the Grayson solution. It clearly works for some people, but comes with the big caveat that it is only suitable for situations where your products have just one attribute (the reason why it has not been incorporated into this or earlier versions of the mod).

kuroi:

Hi Frank

I'm not sure whether the bug that you pointed out would have any functional implications, but it's clearly wrong so I've updated the release pack to 4.3.1. Many thanks for pointing it out.

In respect of the Grayson solution. It clearly works for some people, but comes with the big caveat that it is only suitable for situations where your products have just one attribute (the reason why it has not been incorporated into this or earlier versions of the mod).

You are absloutely right. The Grayson solution is for products which have only one attribute! I have two attributes on one of my products. In order to use Grayson's fix, I combined the two attributes into one, and named it (very clumsy looking) something like "Color + Size Combination". I sincerely hope someone could come up with a better solution on multi-attribute stock control as well as product info display on these attributes in the near future!!!!

By the way, I solved my own dilemma. I tried to set a "displayonly" attribute as default selection to force attribute selection when add product to cart. Now, I figured out how to set this particular attribute back to NOT showing stock level (for many reasons, but mostly for a better looking). Here is my solution:

Find attributes.php in includes/modules/your_template floder from Kuroi's contrib( many many thanks to Kuroi! Great mod!). Change this code:

$products_options_array[] = array('id' => $products_options->fields['products_options_values_id'],
'text' => $products_options->fields['products_options_values_name']); to the following:
//check if attribute is display only
if ($products_options->fields['attributes_display_only'] == '1') {
$products_options_array[] = array('id' => $products_options->fields['products_options_values_id'],
'text' => $products_options->fields['products_options_values_name']);
} else {
$products_options_array[] = array('id' => $products_options->fields['products_options_values_id'],
'text' => $products_options->fields['products_options_values_name'] .' [' . $products_options->fields['quantity'] . ' '. TEXT_ATTRIBUTES_PIECES . ']');
}
Next, right above this line:
//radio buttons
add the following:
//check if attribute is display only
if ($products_options->fields['attributes_display_only'] == '1') {
$products_options_value_id = $products_options->fields['products_options_values_id'];
$products_options_details = $products_options->fields['products_options_values_name'];
$products_options_details_noname = $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '<br />' . $products_options_display_weight : '');
}
//check complete

I wish these changes can be of some help to somebody out there who needs it. I am not a programmer and I've got a lot of help from various smart people in this forum before. For that, I am very grateful.

"Stock by attributes" should be inculded in future zen-cart releases and hopefully has much more intelligent fuctions by then.

Hi Frank,

Thanx for your posted fixes... and actually, instead of showing the stock values beside the respective attributes option, I just want to show the 'Out of Stock' remark to only for those attributes that has reach to 0 in quantity BUT no remarks to the one that still have stock. So that next time the online shoppers no need to 'choose' and 'add to cart' the attributes and then find that no stock available to order!!! Do you have any idea how to code that?! :smile: or anyone out there?!

Kuroi,

Is it possible to implement a SEARCH facility to Stocks by Attributes mod?! :lamo: As what I can see now is that when you have a LOT of stocks with attributes to manage, it become paintful just to search for particular products thru the listing :wacko:

tajul_ashyqin:

Hi Frank,

Thanx for your posted fixes... and actually, instead of showing the stock values beside the respective attributes option, I just want to show the 'Out of Stock' remark to only for those attributes that has reach to 0 in quantity BUT no remarks to the one that still have stock. So that next time the online shoppers no need to 'choose' and 'add to cart' the attributes and then find that no stock available to order!!! Do you have any idea how to code that?! :smile: or anyone out there?!
In my situation, I have very limited stock level on each attribue. So, I wanted customers to see the quantities on each attribute, so that they would not add more than what's available. I also turned "show stock when low" in admin under Configuration/Stock, so that if my customers did add more than available quantities, they would get an warning message and show available stock in shopping cart.

In your situation, I assume that you have plenty merchandise in stock and you have a very tight stock level control in place. I would suggest another fix posted by Grayson before:

1. Switch back to original attributes.php by kuroi
2. If you want to force attribute selection, add a "display only" attribute as "default" selection
3. In attribute.php find

$products_options_details = $products_options->fields['products_options_values_name'];
replace it with:
if ($products_options->fields['quantity'] > 0) { $products_options_details = $products_options->fields['products_options_values_name']; } else { $products_options_details = $products_options->fields['products_options_values_name'] . ' [' . TEXT_ATTRIBUTES_NOT_IN_STOCK . ']'; }
next replace
$products_options_details_noname = $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '<br />' . $products_options_display_weight : '');
with
if ($products_options->fields['quantity'] > 0) { $products_options_details_noname = $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '<br />' . $products_options_display_weight : ''); } else { $products_options_details_noname = ' [' . TEXT_ATTRIBUTES_NOT_IN_STOCK . ']' . $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '<br />' . $products_options_display_weight : ''); }
A few lines below this, find
> $products_options_details_noname = $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '' . $products_options_display_weight : '');
Replace with:
if ($products_options->fields['quantity'] > 0) { $products_options_details_noname = $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '' . $products_options_display_weight : ''); } else { $products_options_details_noname = ' [' . TEXT_ATTRIBUTES_NOT_IN_STOCK . '] ' . $products_options_display_price . ($products_options->fields['products_attributes_weight'] != 0 ? '' . $products_options_display_weight : '');}

Do NOT forget to add a define of TEXT_ATTRIBUTES_NOT_IN_STOCK in product_info.php in includes/languages/english/your_template folder!!

By the way, the fix suggested above works for single attribute product only and for radio, checkbox options.

For default dropdown display, you need to modify:

$products_options_array[] = array()
statements in attributes.php and add a if{}else{} conditon, which is a little harder to achieve and I have not enough time to play with it.

frank_lyy:

...In your situation, I assume that you have plenty merchandise in stock and you have a very tight stock level control in place. I would suggest another fix posted by Grayson before...

Yup, you are correct as it reflects the real situation in my shops! I tried to insert the fixes posted but it didn't work as it shows the remarks to all the attributes defined even the stock has 0 quantity in it. I tried to change the logic though but when I define $products_options->fields['quantity'] = 0, no remarks shown instead!:no: BTW, thanx for your help, much appreciated!

tajul_ashyqin:

Yup, you are correct as it reflects the real situation in my shops! I tried to insert the fixes posted but it didn't work as it shows the remarks to all the attributes defined even the stock has 0 quantity in it. I tried to change the logic though but when I define $products_options->fields['quantity'] = 0, no remarks shown instead!:no: BTW, thanx for your help, much appreciated!

Sorry, my bad. I forgot to include the DB query change by Grayson. You need to change part of the DB query in attributes.php by kuori to ferry "quantity" from your DB first, then apply the fix I posted yesterday.

Here is the query change:

find this block of code:

$sql = "select pov.products_options_values_id,
pov.products_options_values_name,
pa.*
from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov
where pa.products_id = '" . (int)$_GET['products_id'] . "'
and pa.options_id = '" . (int)$products_options_names->fields['products_options_id'] . "'
and pa.options_values_id = pov.products_options_values_id
and pov.language_id = '" . (int)$_SESSION['languages_id'] . "' " .
$order_by;
change it to:
if ($products_options_names->fields['products_options_type'] != PRODUCTS_OPTIONS_TYPE_TEXT && $products_options_names->fields['products_options_type'] != PRODUCTS_OPTIONS_TYPE_FILE && $products_options_names->fields['products_options_type'] != PRODUCTS_OPTIONS_TYPE_READONLY) {
$sql = "select pov.products_options_values_id,
pov.products_options_values_name,
pwas.quantity,
pa.*
from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov, " . TABLE_PRODUCTS_WITH_ATTRIBUTES_STOCK . " pwas
where pa.products_id = '" . (int)$_GET['products_id'] . "'
and pa.options_id = '" . (int)$products_options_names->fields['products_options_id'] . "'
and pa.options_values_id = pov.products_options_values_id
and pwas.stock_attributes = pa.products_attributes_id
and pov.language_id = '" . (int)$_SESSION['languages_id'] . "' " .
$order_by;
} else {
$sql = "select pov.products_options_values_id,
pov.products_options_values_name,
pa.*
from " . TABLE_PRODUCTS_ATTRIBUTES . " pa, " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov
where pa.products_id = '" . (int)$_GET['products_id'] . "'
and pa.options_id = '" . (int)$products_options_names->fields['products_options_id'] . "'
and pa.options_values_id = pov.products_options_values_id
and pov.language_id = '" . (int)$_SESSION['languages_id'] . "' " .
$order_by;
}

This way, you got your quantities for each attribute then you can apply if {}else{}condition I suggested yesterday.

Keep in mind, these fix will only work for products have one attribute, and product attribute display style is radio buttons or check boxes.

In case of default dropdown display, you need to modify the $products_options_array[], such as:

if ($products_options->fields['quantity']) > 0) {$products_options_array[] = array('id' => $products_options->fields['products_options_values_id'],
'text' => $products_options->fields['products_options_values_name'] .' [' . $products_options->fields['quantity'] . ' '. TEXT_ATTRIBUTES_NOT_In_Stock . ']');
}

frank_lyy:

...Sorry, my bad. I forgot to include the DB query change by Grayson. You need to change part of the DB query in attributes.php by kuori to ferry "quantity" from your DB first, then apply the fix I posted yesterday...

Why I didn't think of that! :laugh: thank you very much Frank! that should fix it... :yes:

Hi, I'm not sure if the error I'm experiencing has to do with Stock by Attribute or not. My client had this add-on installed for Zen Cart 1.2. We then installed 1.3.6 for her in a test directory. I do not see the error on her old cart, only on the new one.

I noticed the following error happening in the Attributes Controller on her new site. When I try to copy the attributes from one product to another item or to a category, this message comes up:

1136 Column count doesn't match value count at row 1
in:
[insert into products_attributes values (0, '237', '70', '480', '1.5000', '+', '0', '1', '0', '+', '0', '0', '1', '', '1', '0.0000', '0.0000', '0.0000', '0.0000', '0.0000', '', '', '0.0000', '0', '0.0000', '0', '0')]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.

I thought that maybe installing the add-on would help, so I did, but it hasn't made any difference. There's no products_attributes_values table in my database...should there be?

Does this seem like an error that is somehow related to Stock by Attribute?

Thanks!
Shoshanna

Ok this is a simple question not really related to the functionality of the script so much as the location of the output on the products page --

if you look at the product page at - http://marylandcycling.com/shopping/index.php?main_page=product_info&cPath=1&products_id=1

The attributes selection box seems to be much lower and out of place as compared to the add item to cart screen. I am afraid users will not see the size selection... and I can't for the life of me find out where this attributes box is scripted into each zen cart product page.

Can someone direct me to where or how I can modify the location of the output of the attributes slection "please choose" on the product page?

Ideally I would like to get it above the "add to cart" box.

lemuria:

Does this seem like an error that is somehow related to Stock by Attribute?Hi Shoshanna

It's right that you have no products_attributes_values table. What this sql is doing is inserting values into the products_attributes table.

I'm afraid that I can see no link between this problem and Stock by Attribute. I think that your assessment is most likely correct and that the problem occurs in a database inset in the attributes controller. Stock by Attributes steers well clear of there.

I have a hypothesis however, about your problem. What version of MySQL are you running?

nickmd:

Ok this is a simple question not really related to the functionality of the script so much as the location of the output on the products pageActually this is even further off topic than that since this add-on does not actually output anything to the products page :D (though a lot of people wish it would :yes:).

Although I wouldn't want to see this thread wander off into a discussion about reworking the products page (a rather common request) here's a quick pointer in the right direction ... some of the formating is achieving through CSS, but to make the change you want to do would require some editing of the includes/templates/YOUR_TEMPLATE/templates/tpl_product_info.php file which determines the order in which content is served to the products page.

kuroi:

Actually this is even further off topic than that since this add-on does not actually output anything to the products page :D (though a lot of people wish it would :yes:).

Great thank you! After looking in the correct forum I found an answer -- (http://www.zen-cart.com/forum/showthread.php?t=51697) for some reason I thought this module created the attributes, but now I understand. Thanks!