[Done 1.3.8] SaleMaker - More Info

Hello, this is for sure a small bug affecting v1.3.5 and since there's no salemaker.php in changelog for v1.3.6 I suppose also this version is affected.

In SaleMaker, when you click on more info (the link activating the popup which tells which sales already include the specific category), the category name isn't bringed to the popup. In effect the variable $category[categories_name] has no value.

A quick fix for this is to replace lines 406 - 416 with:

    echo '        <td align="right"><table border="0" cellspacing="2" cellpadding="2">' . "\n";
	echo '        <tr>' . "\n";
	  if ($prev_categories_array[$category['categories_id']]) {
      echo '        <td>' . "\n";
$cname= zen_get_category_name($category['categories_id'], (int)$_SESSION['languages_id']);
?>
<script language="javascript" type="text/javascript"><!--
document.write('<?php echo '<a href="javascript:popupWindow(\\\'' . zen_href_link(FILENAME_SALEMAKER_POPUP, 'cid=' . $category['categories_id'] . '&cname='.$cname) . '\\\')">'.'(More Info)'.'</a>'; ?>');
//--></script>
<?php
	  }
	  echo "</td>\n";

We will look into this further for the next release ... thanks for the catch ...

That was a dumb fix ... :eek:

Fortunately it was not committed to v1.3.7 ...

The correct fix is to change the java portion around lines 410-414 in:
/admin/salemaker.php

To read:

?>
<script language="javascript" type="text/javascript"><!--
document.write('<?php echo '<a href="javascript:popupWindow(\\\'' . zen_href_link(FILENAME_SALEMAKER_POPUP, 'cid=' . $category['categories_id']) . '\\\')">'.'(More Info)'.'</a>'; ?>');
//--></script>
<?php

then change in:
/admin/salemaker_popup.php

  require(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . FILENAME_SALEMAKER_POPUP . '.php');

To read:

  require(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . FILENAME_SALEMAKER_POPUP . '.php');
  $cname = zen_get_category_name($_GET['cid'], (int)$_SESSION['languages_id']);

And the change:

<p class="main"><center><h1><?php echo HEADING_TITLE . ' - ' . $_GET['cname']; ?><?php echo zen_draw_separator(); ?></h1></center></p>

To read:

<p class="main"><center><h1><?php echo HEADING_TITLE . ' - ' . $cname; ?><?php echo zen_draw_separator(); ?></h1></center></p>

the other method would work for some category names and break in a horrible way for others ...

Ajeh:

The correct fix is to change the java portion around lines 410-414 in:
/admin/salemaker.php

To read:

?>

/admin/salemaker.php, line 400

	    echo ' Warning : ' . $prev_categories_array[$category['categories_id']] . ' sales already include this category';

Another hardcoded message posted here.

Dedek,

And how/what are these "bugs"??

Kobra,

there are many people using Zen Cart translated only to their native language.

If I install Zen Cart for my customers and must fix (translate) every hardcoded message, it is bug for me. If I don't fix it, it is bug for my customers. Not all of them understand English.

it is bug for me. If I don't fix it, it is bug for my customers.
Correct a "bug for you" not specifically a bug for ???many users

But being OpenSource you are free to alter it to fit your requirements

kobra:

Correct a "bug for you" not specifically a bug for ???many users

But being OpenSource you are free to alter it to fit your requirements

Kobra, it's vain discussion.

I don't claim nothing for myself. I found it, fixed and then reported for other. That's all.

Let's decide Zen Cart developers to fix it in future version or not.

This has been fixed for v1.3.8 ... thanks for the update ...

While it does not "break" anything it does make this wrong or incorrect for other languages which is more or less an unexpected feature ... which some might call a bug ... :smartalec: