Forums / Bug Reports / [Done v1.3.8] EZ Page problem

[Done v1.3.8] EZ Page problem

Locked

Views: 1,434

Results 1 to 2 of 2
This thread is locked. New replies are disabled.
22 Jan 2007, 12:45 AM
#1
quentinjs avatar

quentinjs

Zen Follower

Join Date:
Mar 2004
Location:
Calgary, Alberta
Posts:
289
Plugin Contributions:
0

[Done v1.3.8] EZ Page problem

Having never used this feature until today, its hard for me to know if it existed as problem in 1.3.6, but if I do a page with a setting of OPEN NEW PAGE... then go and click on the link, I am wondering about the additional parameter....

<li><a href="http://www.totalgarage.ca/products/index.php?main_page=pricelist?target=&quot;_blank" target="_blank">Price List</a></li> <li><a href="http://www.totalgarage.ca/products/rss2.php?target=&quot;_blank" target="_blank">RSS2 Feed</a></li>

the target= is not always accepted happily by other pages. I am wondering if this can be set as optional.

22 Jan 2007, 7:00 AM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Done v1.3.8] EZ Page problem

That's a bug.
/includes/functions/functions_ezpages.php
line 41 says:

                              ($ez_pages_alturl=='' ? '' : zen_href_link($ez_pages_alturl, 'target="_blank', ($ez_pages_is_ssl=='0' ? 'NONSSL' : 'SSL'), true, true, true));
```remove the 'target="_blank', like this:```
                              ($ez_pages_alturl=='' ? '' : zen_href_link($ez_pages_alturl, '', ($ez_pages_is_ssl=='0' ? 'NONSSL' : 'SSL'), true, true, true));

The proper rendering for target=_blank is done later on line 55 (which doesn't need any changes):```
$ez_link .= ($ez_pages_open_new_window == '1' ? '" target="_blank' : '');


Do the same for these files, removing the target="_blank from the zen_href_link function calls, but leaving it later in the file where the link is rendered.
/includes/modules/ezpages_bar_footer.php
/includes/modules/ezpages_bar_header.php
/includes/sideboxes/ezpages.php

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.