Zen Cart Logo
Forums / Bug Reports / [Done v1.3.9h] Minor error in admin upload class

[Done v1.3.9h] Minor error in admin upload class

Locked

Views: 2,008

Results 1 to 1 of 1
This thread is locked. New replies are disabled.
9 Feb 2007, 4:19 AM
#1
bunyip avatar

bunyip

Totally Zenned

Join Date:
Sep 2004
Location:
Western Massachusetts
Posts:
2,361
Plugin Contributions:
1

[Done v1.3.9h] Minor error in admin upload class

I had reason this evening to be looking closely at the upload class file in admin and noticed a minor (pretty much inconsequential) error in message stack use.
At lines 171-175 of admin/includes/classes/upload.php, this code if ($this->message_location == 'direct') { $messageStack->add_session(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error'); } else { $messageStack->add_session(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error'); } should read ```
if ($this->message_location == 'direct') {
$messageStack->add(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error');
} else {
$messageStack->add_session(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error');
}

That file hasn't been modified since Sep 2005, so it's obviously not a major problem...