Error coming from additional_images.php -- problems using + and [ and ] in image name

Hello. I've recently installed Zen-Cart v.1.3.7 and was very impressed by how easily I was able to get the store up and running. However, I'm getting lots and lots of entries in /error_log which all say:

[07-Feb-2007 14:15:18] PHP Warning: preg_match() [<a href='function.preg-match'>function.preg-match</a>]: Unknown modifier 'a' in /home/xxxx/public_html/cart/includes/modules/additional_images.php on line 47

Now, I haven't tinkered at all with that template (I've tinkered with very few, actually) and don't have a clue as to why it's throwing this error. Any help would be appreciated. Thanks.

If your includes/modudes/additional_images.php file,

if you replace:

if(preg_match("/" . $products_image_base . "/i", $file) == '1') {

with:

if(preg_match("/" . $products_image_base . "/i", $file) == 1) {

at line 47, will the error still appear in your logs ?

Thank you. The error on line 47 has now gone away but we have an identical error shifted further into the file:

[12-Feb-2007 03:06:12] PHP Warning: preg_match() [<a href='function.preg-match'>function.preg-match</a>]: Unknown modifier 'a' in /home/xxxxxx/public_html/cart/includes/modules/additional_images.php on line 93

A very strange query indeed I might add. In your includes/modules/additional_images.php file, on line 93 (approx);

find:

$noscript_link = '<noscript>' . ($flag_display_large ? '<a href="' . zen_href_link(FILENAME_POPUP_IMAGE_ADDITIONAL, 'pID=' . $_GET['products_id'] . '&pic=' . $i . '&products_image_large_additional=' . $products_image_large) . '" target="_blank">' . $thumb_regular . '<br /><span class="imgLinkAdditional">' . TEXT_CLICK_TO_ENLARGE . '</span></a>' : $thumb_regular ) . '</noscript>';

replace with:

$noscript_link = '<noscript>' . ($flag_display_large) ? '<a href="' . zen_href_link(FILENAME_POPUP_IMAGE_ADDITIONAL, 'pID=' . $_GET['products_id'] . '&pic=' . $i . '&products_image_large_additional=' . $products_image_large) . '" target="_blank">' . $thumb_regular . '<br /><span class="imgLinkAdditional">' . TEXT_CLICK_TO_ENLARGE . '</span></a>' : $thumb_regular. '</noscript>';

That appears to have solved the problem! Thanks very much for your help! :)

Excellent. Glad to know this problem was about a typo query. :smile:

I am getting this same error with version 1.3.7...

I made the change recommended to line 47 in this post...

My error is as follows...

Warning: preg_match() [function.preg-match]: Compilation failed: nothing to repeat at offset 0 in /home/twolittl/public_html/catalogp/includes/modules/additional_images.php on line 47

You can view the error at this link...

http://www.twolittlebunnies.com/catalogp/index.php?main_page=product_info&cPath=2&products_id=21

The change did not fix my problem..

Dave

What version of PHP are you using?

DrByte:

What version of PHP are you using?

4.4.4

General server information: Operating system Linux Service Status
Kernel version 2.6.9-42.0.2.ELsmp Machine Type i686 Apache version 1.3.37 (Unix) PERL version 5.8.7 Path to PERL /usr/bin/perl Path to sendmail /usr/sbin/sendmail Installed Perl Modules
PHP version 4.4.4 MySQL version 4.1.21-standard cPanel Build 10.9.0-STABLE 38 Theme cPanel X v2.6.0 Documentation
cPanel Pro 1.0 (RC36)

How many additional product images do you have for this product?
What are their filenames ?

DrByte:

How many additional product images do you have for this product?
What are their filenames ?

Thanks Dr. Byte...

You hit it on the nail when you asked for the filenames..

Someone had changed the pictures on a couple of products and called them:

+filename.jpg so I changed them to filename.jpg

And the problem has gone away..

Thanks again

Aha ... that makes sense ... the preg_match would croak on having a + symbol ... because Regular Expressions use + as a special parameter for pattern matching ... and Zen Cart isn't expecting to have + symbols in filenames ...

I'm having this same issue. I made the two changes suggested in the thread and now get a zillion of these on the page:
Warning: preg_match(): Unknown modifier 'b' in /Applications/xampp/htdocs/includes/modules/additional_images.php on line 47

When I uncomment this line (46)

if(preg_match("/" . $products_image_match . "/i", $file) == '1') {

I get just one error:

Parse error: parse error, unexpected $ in /Applications/xampp/htdocs/includes/modules/additional_images.php on line **114

**Only I can't figure out where anything is missing. I should say I'm a novice at PHP but a quick learner!

Any ideas!? When i uncommented that line did I need to add something elsewhere? Thanks so much.
**
Thanks-
Amy
**

check your image filenames - l got this error in one category only, and upon checking the image names, found that they contained spaces, and lots of symbols ( ) ; - etc - once l renamed them all to something 'clean', the problem disappeared alltogether :-)

I've done all the updates - also changed all 290 images in the store to a clean name but still get the error Warning: preg_match() [function.preg-match]: Unknown modifier '3' in /home/cq2730/public_html/store/includes/modules/additional_images.php on line **47. **Can someone help me?
https://www.eventboutique.ca/store

Did you make the changes suggested in posts 2 & 4 above? You should not need to, as those lines did not cause the reported problem, and the post 4 change would actually cause a different error in some conditions.

Don't use [ and ] in the image names.

More info How do I add multiple images to a product?

There was only one of the updates that I changed. As for the images - there are only a couple with [ ] in them. There are still images like the engraved beer mug which doesn't have the brackets and the error is still there. The only brackets are shown in the toolbar as the listed model number.

Your engraved beermug is available under:

Products_id=233 and the image is placed under:images/30008-L[1].jpg --> [] in the filename

and

Products_id=159 and the image translated under path :images//30008-L.jpg --> double // is because of wrong filename or incorrect images directory -> no picture shown.
Image available is under images/30008L.jpg

Thank you everyone for your help. I had duplicate products (and didn't have each image updated). I have changed all of the image files - thank you guys for your help!