Forums / Bug Reports / [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

[Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Locked

Views: 4,021

Results 1 to 20 of 20
This thread is locked. New replies are disabled.
7 Jun 2007, 6:28 AM
#1
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

[Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Is it just me or the product's meta tag title doesn't seem to work.

Product Name:
Yes No Title:
Yes No Model:
Yes No Price:
Yes No Title/Tagline:
The database fileds metatags_title_status, etc., all changed according to my selection, but source view still includes all of them. I can't seem to change the selection between yes/no.

I've ****Zen Cart v1.3.7** with the following contribution:

** Easy Populate EP_v1.2.5.4 Grid Layout for Products Listing: v1.3.7 Ultimate SEO Version 2.103

Hello. My name is dietcoke.

7 Jun 2007, 5:29 PM
#2
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Why is this moved?

I'm pretty certain it's a bug.

Hello. My name is dietcoke.

7 Jun 2007, 5:34 PM
#3
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Product Meta Tags work fine ...

What do you have set for the Custom Meta Tag settings?

Do you have an URL to this Product?

What happens if you turn off the SEO add-on?

Clean install or an upgrade?

How did you install? How did you upgrade?

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

7 Jun 2007, 5:48 PM
#4
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

I see.

No, I tried it on clean install and the meta tag through admin still doesn't seem to work either.

I think I'll just code it out.

Hello. My name is dietcoke.

7 Jun 2007, 5:50 PM
#5
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

There are Default settings and then there are Custom Settings ...

The Default Settings are the presets for the Custom Settings.

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

7 Jun 2007, 6:28 PM
#6
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

If you are having trouble finding how to add the Custom Meta Tags ... click the biohazard on the Categories/Products listing in the admin ...

Black means not customized ...

Orange means customized ...

And you can set what information to include ...

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

7 Jun 2007, 6:39 PM
#7
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Ajeh:

If you are having trouble finding how to add the Custom Meta Tags ... click the biohazard on the Categories/Products listing in the admin ...

Black means not customized ...

Orange means customized ...

And you can set what information to include ...

The metatag works, but what I'm saying is I can't turn it off.

I double checked on a clean install too. I didn't want the model number so I marked it off, and the database field reflected that. There it is again, when I go back.

That's why I think it's a bug.

Hello. My name is dietcoke.

7 Jun 2007, 7:36 PM
#8
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

I give up. I'll just turn it all off in:

Admin->Configuration->Products Info->Meta Tags

Hello. My name is dietcoke.

7 Jun 2007, 7:55 PM
#9
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,515
Plugin Contributions:
176

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

If the edits you made in the admin are properly stored in the database as you indicated, then the only thing causing the metatags to not follow those instructions would be customized code in the /includes/modules/meta_tags.php or an override in /includes/modules/YOURTEMPLATE/meta_tags.php that has busted the normal operation of the code.
Additionally, if you have modified the html_header.php file to call a different meta_tags module or somehow handle metatags differently, then you'd end up with similar problems.

A clean install of v1.3.7 including demo products shows it working fine:
a. clean install with demo products
b. go to admin, select a product, hit the biohazard button and enter custom text in the 3 fields, and turn OFF the price and model number radio buttons. Save settings.
c. go to storefront, access that product, and bam ... custom title, keywords, description, and the title does NOT include price or model number.

What differs on yours ?

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

7 Jun 2007, 8:55 PM
#10
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

DrByte:

If the edits you made in the admin are properly stored in the database as you indicated, then the only thing causing the metatags to not follow those instructions would be customized code in the /includes/modules/meta_tags.php or an override in /includes/modules/YOURTEMPLATE/meta_tags.php that has busted the normal operation of the code.
Additionally, if you have modified the html_header.php file to call a different meta_tags module or somehow handle metatags differently, then you'd end up with similar problems.

A clean install of v1.3.7 including demo products shows it working fine:
a. clean install with demo products
b. go to admin, select a product, hit the biohazard button and enter custom text in the 3 fields, and turn OFF the price and model number radio buttons. Save settings.
c. go to storefront, access that product, and bam ... custom title, keywords, description, and the title does NOT include price or model number.

What differs on yours ?

Got it. I have to have value in the fields in order for me to use the options to metatag title **particular **product, or turn on customization.

I thought by changing (making selection) then update will make it turn on the customization.

This is purely my fault. Costing the time extra work of fine folks.

Hello. My name is dietcoke.

7 Jun 2007, 9:05 PM
#11
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Actually, that shouldn't be too hard. Just an if and else on checking 0 should do it. I'll take a crack at it after I finish setting it up.

Hello. My name is dietcoke.

7 Jun 2007, 10:11 PM
#12
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,515
Plugin Contributions:
176

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

dietcoke:

Got it. I have to have value in the fields in order for me to use the options to metatag title **particular **product, or turn on customization.Correct - the logic currently requires that the keywords or description must have custom content in order for the rest of the switches to take effect for that particular product.

    if (!empty($product_info_metatags->fields['metatags_keywords']) or !empty($product_info_metatags->fields['metatags_description'])) {

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

7 Jun 2007, 10:49 PM
#13
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Still, why not detect switch fields not "0," too.

Hello. My name is dietcoke.

7 Jun 2007, 10:57 PM
#14
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

The administrator has specified that you can only edit messages for 7 minutes after you have posted. This limit has expired, so you must contact the administrator to make alterations on your message.

What I'm saying is why not add switch fields are 0 too.

Hello. My name is dietcoke.

8 Jun 2007, 1:03 AM
#15
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,515
Plugin Contributions:
176

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Customizing and making those kind of changes would be perfectly acceptable if that's what meets your needs.

You'll have to alter the codeblock starting with the line I quoted, and move/edit/re-arrange, and troubleshoot the logic to operate on those different fields regardless of whether the text fields have content.

It would be advisable to save your edits into the overrides folder:
/includes/modules/YOURTEMPLATE/meta_tags.php

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

8 Jun 2007, 6:52 AM
#16
dietcoke avatar

dietcoke

New Zenner

Join Date:
Jun 2007
Posts:
23
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Doc,

Thanks. I really appreciate this.

Hello. My name is dietcoke.

12 Jul 2007, 11:13 AM
#17
pasher avatar

pasher

New Zenner

Join Date:
Dec 2005
Posts:
64
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Have read thru' this thread, but still not clear what the solution is -

I have many products set as 'Call For Price', which actually enters a zero price in the product database. The Title tag shows a price of 0.00, which is subsequently found by the googlebots so when my products are googled, searchers see a zero price in the search summary. Great for getting hits, but ultimately misleading to potential customers !!
So I goto the product admin page, select metatags, turn off the price in the title, update, but the price is still in the product page source title tag. Also, when I go back to the admin and look again, the show product price is still set.
Are we sure this isn't a bug?
Cheers
Pa

16 Jul 2007, 12:17 PM
#18
pasher avatar

pasher

New Zenner

Join Date:
Dec 2005
Posts:
64
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

pasher:

Have read thru' this thread, but still not clear what the solution is -

I have many products set as 'Call For Price', which actually enters a zero price in the product database. The Title tag shows a price of 0.00, which is subsequently found by the googlebots so when my products are googled, searchers see a zero price in the search summary. Great for getting hits, but ultimately misleading to potential customers !!
So I goto the product admin page, select metatags, turn off the price in the title, update, but the price is still in the product page source title tag. Also, when I go back to the admin and look again, the show product price is still set.
Are we sure this isn't a bug?
Cheers
Pa

Anyone???

16 Jul 2007, 8:45 PM
#19
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,515
Plugin Contributions:
176

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

To handle call-for-price products that have no price set, you could try this:

/includes/modules/meta_tags.php
line 200:pd.products_description, p.product_is_free,add another field, like this:```
pd.products_description, p.product_is_free,[B] p.product_is_call,[/B]


line 253:
      if (zen_check_show_prices() == true) {
        $meta_products_price = zen_get_products_actual_price($product_info_metatags->fields['products_id']);
        $meta_products_price = SECONDARY_SECTION . $currencies->display_price($meta_products_price, zen_get_tax_rate($product_info_metatags->fields['products_tax_class_id']));
      }

change to this:
if (zen_check_show_prices() == true) {
$meta_products_price = zen_get_products_actual_price($product_info_metatags->fields['products_id']);
[B] $prod_is_call_and_no_price = ($product_info_metatags->fields['product_is_call'] == '1' && $meta_products_price == 0);[/B]
$meta_products_price = ([B]!$prod_is_call_and_no_price ? [/B]SECONDARY_SECTION . $currencies->display_price($meta_products_price, zen_get_tax_rate($product_info_metatags->fields['products_tax_class_id']))[B] : '')[/B];
}

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

17 Jul 2007, 8:44 AM
#20
pasher avatar

pasher

New Zenner

Join Date:
Dec 2005
Posts:
64
Plugin Contributions:
0

Re: [Done v1.3.8] Product's Meta Tag Title vs Call For Price and $0.00 display

Yep - That fixes it up
Thanks DrB

Pa