Zen Follower
- Join Date:
- Mar 2009
- Location:
- Essex, UK
- Posts:
- 448
- Plugin Contributions:
- 0
Dynamic Price Updater
Hi MC
I have just launched the upgraded website. Hopefully you can now see what I do.
Views: 342,263
Zen Follower
Hi MC
I have just launched the upgraded website. Hopefully you can now see what I do.
Totally Zenned
dharrison:
Hi MC
I have just launched the upgraded website. Hopefully you can now see what I do.
https://sitstandforbusiness.com/fundamental-manual-standing-desk-c-22_73_88/fundamental-height-adjustable-sitstand-desk-with-manual-crank-adjustment-p-113.html
Having looked at the code for the include/exclude VAT pricing and the source code of the now live site (which appeared similar to the previous page in the area of concern), to replicate the results of the module in DPU requires basically incorporation of that price display content into DPU which I would see to be done in the DPU class. Unfortunately the other module doesn't provide a sort of "slip in/out" capability for displaying the price as it depends on the product's id as the source, not the selections and possible selections as used by DPU.
What that ultimately means is that there will be two places in the code that would determine the content to be displayed instead of using a single piece of code to create the output based on essential input... I'll see what I can pull together and provide the github location to incorporate the additional code.
Ideally, the other module would get updated to split the "display" out possibly or some other variation to where a single input is needed for the existing function but some other code could be accessed such that when given specific data that it outputs consistent with the existing format and/or offer the ability to customize it...
Zen Follower
Thanks MC Numbers.
I welcome any help. :)
Totally Zenned
Ran across an issue if ZC requires main_page to be on the web address when products_id is present (new condition for ZC 1.5.7). As written, the ajax query has been passing products_id in the web address so that other operations can be performed using that information. While it is possible to add main_page to the ajax query request, it is not required and can be omitted through this related commit that maintains the overall information and operation but does away with the additional information on the product information page.
The general symptom observed is that the page continuously reloads, especially on changing a selection on the page.
https://github.com/mc12345678/Dynamic_Price_Updater/pull/22/files
Totally Zenned
zc 156c
dpu 3.2.0
Dynamic Price Updater (Update Check) set FALSE
why is DPU trying to "phone home"? and generating adm debug files
Isn't 'phone home' code frowned upon?
what does it take to disable this check since the switch doesn't appear to work as expected?
[30-May-2020 12:49:15 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:138]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: CURL error checking plugin versions: 7:Failed to connect to plugins.zen-cart.com port 443: Connection refused
Trying http instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 138.
[30-May-2020 12:49:16 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:145]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: CURL error checking plugin versions: 7:Failed to connect to plugins.zen-cart.com port 80: Connection refused
Trying www instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 145.
[30-May-2020 12:49:17 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:157]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: CURL error checking plugin versions: 7:Failed to connect to www.zen-cart.com port 80: Connection refused
Trying file_get_contents() instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 157.
[30-May-2020 12:49:18 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 file_get_contents() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:159]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Warning: file_get_contents(https://plugins.zen-cart.com/versioncheck/1301): failed to open stream: Connection refused in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 159.
[30-May-2020 12:49:18 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:161]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: file_get_contents() error checking plugin versions.
Trying http instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 161.
[30-May-2020 12:49:19 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 file_get_contents() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:162]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Warning: file_get_contents(http://plugins.zen-cart.com/versioncheck/1301): failed to open stream: Connection refused in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 162.
[30-May-2020 12:49:19 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:165]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: file_get_contents() error checking plugin versions.
Aborting. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 165.
Totally Zenned
Not sure what goes wrong, but the "phone home" is Zen Cart default code. Not something build in to the module. Zen Cart checks the module for updates on the zen cart site, but on your site that is not working.
RixStix:
zc 156c
dpu 3.2.0Dynamic Price Updater (Update Check) set FALSE
why is DPU trying to "phone home"? and generating adm debug files
Isn't 'phone home' code frowned upon?what does it take to disable this check since the switch doesn't appear to work as expected?
[30-May-2020 12:49:15 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:138]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: CURL error checking plugin versions: 7:Failed to connect to plugins.zen-cart.com port 443: Connection refused
Trying http instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 138.
[30-May-2020 12:49:16 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:145]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: CURL error checking plugin versions: 7:Failed to connect to plugins.zen-cart.com port 80: Connection refused
Trying www instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 145.
[30-May-2020 12:49:17 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:157]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: CURL error checking plugin versions: 7:Failed to connect to www.zen-cart.com port 80: Connection refused
Trying file_get_contents() instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 157.
[30-May-2020 12:49:18 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 file_get_contents() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:159]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Warning: file_get_contents(https://plugins.zen-cart.com/versioncheck/1301): failed to open stream: Connection refused in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 159.
[30-May-2020 12:49:18 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:161]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: file_get_contents() error checking plugin versions.
Trying http instead. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 161.
[30-May-2020 12:49:19 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 file_get_contents() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:162]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Warning: file_get_contents(http://plugins.zen-cart.com/versioncheck/1301): failed to open stream: Connection refused in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 162.
[30-May-2020 12:49:19 America/Los_Angeles] Request URI: /MYADMINFOLDER/configuration.php?gID=56&cID=2151, IP address: MY_IP_ADDRESS
#1 trigger_error() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:165]
#2 this_plugin_version_check_for_updates() called at [/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php:185]
#3 require(/home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php) called at [/home/HostName/public_html/includes/autoload_func.php:48]
#4 require(/home/HostName/public_html/includes/autoload_func.php) called at [/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php:171]
#5 require(/home/HostName/public_html/MYADMINFOLDER/includes/application_top.php) called at [/home/HostName/public_html/MYADMINFOLDER/configuration.php:9]
--> PHP Notice: file_get_contents() error checking plugin versions.
Aborting. in /home/HostName/public_html/MYADMINFOLDER/includes/init_includes/init_dpu_config.php on line 165.
Totally Zenned
Design75:
Not sure what goes wrong, but the "phone home" is Zen Cart default code. Not something build in to the module. Zen Cart checks the module for updates on the zen cart site, but on your site that is not working.
Not sure that I understand. The switch is set to false, don't check for DPU updates but even then the check that was not expected to happen failed and caused adm-debug files to be generated.
I didn't realize that default zencart code was built into every plugin to phone home regardless of switch setting true/false. Why have a switch setting to check plugin version it is not intended to work?
Totally Zenned
It appears to me that the DPU module is not functioning as expected based upon this comment.
// Respect the admin setting for version checking to prevent checking this if the store is disabled. (typically set because the version checker may generate warnings/errors.
The adm debug file creation occurred today on several occassions. Other errors, are the typical undefined_constant errors which seem to be quite frequent since beginning the update to 156c.
Totally Zenned
I just had a better look at the code, and it appears that there is an older version of the "call home function." I already was working on a new version of this mod, so will include this..
The new mod will include updates made by MC123456778, he did the major development, over the last years. My updates are mainly getting the code to the latest standards.
Totally Zenned
Design75:
I just had a better look at the code, and it appears that there is an older version of the "call home function." I already was working on a new version of this mod, so will include this..
The new mod will include updates made by MC123456778, he did the major development, over the last years. My updates are mainly getting the code to the latest standards.
It's not the "age" of the call home that is an issue, but as RixStix has pointed out that regardless the setting it still tries. This goes back to the use of a constant and the value of that constant. In this case, the text value of false... In a loose comparison (not using === for example), true == 'false' == 'true'..
The test would work even if it were == 'true', but without any comparison the text value of 'false' causes the inner content to be executed.
The "older" version of the call home had been retained because that was the version that worked on older style systems that would not be expected to require or may not support the newer style(s) where newer ZC versions would already have the call home code and that portion of the file would be omitted. Although in webchills' version of ZC, he has removed the call home code and therefore if it is not included in the file such as this, then installation to a fully German based ZC site causes issues in this portion of the code.
Anyways, where:
constant($module_constant . '_PLUGIN_CHECK')
``` is present by itself, it could be changed to:
constant($module_constant . '_PLUGIN_CHECK') == 'true'
Or better still:
constant($module_constant . '_PLUGIN_CHECK') === 'true'
Would be more understood to mean that it better be that value or else. :)
Sorry for any previous "flippant" attempt to incorporate such a switch. I think it is a common problem across the plugins that use or attempt to offer an independent control for the plugin separate from the ZC control.
Totally Zenned
thx for the clarification.
mc12345678:
It's not the "age" of the call home that is an issue, but as RixStix has pointed out that regardless the setting it still tries. This goes back to the use of a constant and the value of that constant. In this case, the text value of false... In a loose comparison (not using === for example), true == 'false' == 'true'..
The test would work even if it were == 'true', but without any comparison the text value of 'false' causes the inner content to be executed.
The "older" version of the call home had been retained because that was the version that worked on older style systems that would not be expected to require or may not support the newer style(s) where newer ZC versions would already have the call home code and that portion of the file would be omitted. Although in webchills' version of ZC, he has removed the call home code and therefore if it is not included in the file such as this, then installation to a fully German based ZC site causes issues in this portion of the code.
Anyways, where:
constant($module_constant . '_PLUGIN_CHECK')
> ```
constant($module_constant . '_PLUGIN_CHECK') == 'true'
Or better still:
constant($module_constant . '_PLUGIN_CHECK') === 'true'
> Would be more understood to mean that it better be that value or else. :)
>
> Sorry for any previous "flippant" attempt to incorporate such a switch. I think it is a common problem across the plugins that use or attempt to offer an independent control for the plugin separate from the ZC control.
Totally Zenned
mc12345678:
Anyways, where:
constant($module_constant . '_PLUGIN_CHECK')
> ```
constant($module_constant . '_PLUGIN_CHECK') == 'true'
Or better still:
constant($module_constant . '_PLUGIN_CHECK') === 'true'
> Would be more understood to mean that it better be that value or else. :)
>
> Sorry for any previous "flippant" attempt to incorporate such a switch. I think it is a common problem across the plugins that use or attempt to offer an independent control for the plugin separate from the ZC control.
TNX but for a coding dummy, it would help to know which line and the complete line so that more problems don't occur due to a fatfinger in the edit? I'm guessing that the debug files were only generated because the zencart.com phonehome server was having troubles with accepting the phone call yesterday.
Appears on line 114 and 184
constant($module_constant . '_PLUGIN_CHECK')
Totally Zenned
Both of those are appropriate lines in which to make the change when referring to an unaltered intact fileset. I am contemplating the use of != 'false' instead of == 'true'...
Totally Zenned
mc12345678:
Both of those are appropriate lines in which to make the change when referring to an unaltered intact fileset. I am contemplating the use of != 'false' instead of == 'true'...
I think it is more of a problem that the zencart plugin server not accepting the phone home attempt.
If you would post the entire lines of code instead of just a snippet of the line, it would make it easier for a non-coder to fix and reduce the potential for an oops.
Totally Zenned
RixStix:
I think it is more of a problem that the zencart plugin server not accepting the phone home attempt.
If you would post the entire lines of code instead of just a snippet of the line, it would make it easier for a non-coder to fix and reduce the potential for an oops.
Here is the PR that incorporates the suggested change: https://github.com/mc12345678/Dynamic_Price_Updater/pull/23/files
The red text is where removal occurs, the green text is where insertion is.
The change is based off of the version 3.2.1 proposed distribution, though Design75 is planning to issue the plugin as a 1.5.6 or perhaps 1.5.7 only version which is expected to remove some of the fallback support that has been maintained. For example the DPU class will likely be completely moved into the ajax area instead of being an extra class in the class list. This may mean that the class file currently in the store's catalog would have to be moved/removed to support.
As far as the attempted phone home attempt, it typically is not related to the Zen Cart server or any issue with its ability to communicate but instead the server that is attempting to execute the code as it may not be connected to the internet, https server certificates may not be installed/setup, or there may be some other issue. That's not to say that there occasionally isn't a real issue between the two and unrelated to specifically one or the other, just talking about what is "often" seen.
Anyways, there is no fool proof method to provide changes/suggested changes, so hopefully the above will support your needs and/or way of making changes.
Totally Zenned
Thank you mc12345678
I can understand and make those edits without fearing a catastrophic fatfingered mistake.
The bits and pieces I read, updating to 157 scares the crap out of me.
Totally Zenned
RixStix:
The bits and pieces I read, updating to 157 scares the crap out of me.I guess it's like the bible. One group reads it and drinking is fine while the other says it's a sin.
Don't read into any info about upgrade without optimism as your glasses. So many things are improved. Many are involved. Nearly decades old bugs are being "found" because more are invited to contribute. Heck, they even let me help here and there.:P
I've found I can swap in 1.5.7 even faster than before and easier than with 1.5.6c. The only thing you have to fear.... Well, you know.
But, it's more about what the owner thinks they need than what they really need. "Gotta have purdy!" "Need geo tags!" Really? So the person can stop buying on line at 2 AM and wait until tomorrow to drive to your store?
But here's just one small part of 1.5.7. Accessibility. Doesn't mean you get more workspace on your desk. It's standards the W3C have set forth worldwide to make it better for everyone to shop. There's a couple of Chrome extensions (Web Developer and Lighthouse) that can make a store owner stop the craziness of thinking the SEs like big, fancy colors and graphics which the SEs will NEVER be able to see. We've been playing with responsive_classic as there still needs to be something for the little guy to use until they can find something "better". And, believe me, I use the term facetiously!.
https://tinyurl.com/yb5b3p36 is a test site for 1.5.7 with no mods and all demo products added. It has all sideboxes and visible settings turned on.
Using Web Developer, the site has no CSS errors except for those in the font-awesome.css that we can't control. And, there's only one HTML warning still to be addressed. Web Developer's Accessibility test gives us no errors (well, occasionally one when the bannerSix doesn't have an alt tag) and, importantly, no contrast errors. The Alerts are really a feature for the responsiv_classic template in that they result from Zen Cart "covering" the page with your product's name. It's Zen Cart's version of, "That number to call, again, is.."
Using Lighthouse, we get a score of 99, 100, 100, 100. Again, the 99 is due to external issues (jQuery and the aforementioned font-awesome.css). We could bring them in house but, you'd have to update once a week. Now, THAT is scary. I've attached an image of the score.
SO.... After all this, what in the world does it have to do with DPU? Actually, a lot. When you add a special/discount, the price is shown with any changes on the product's page and any other page that contains a listing for the product. The original price is lined out and the new price is in red (good old #FF0000). Nearly 10% of the world's population might never see the price. They cannot see red. So, if you look at the Specials Page, you may think the color is a little off but, its setting means the entire world has a better chance of seeing it. Google Web Accessibility Lawsuits. 2017 - #814. 2018 - #2285. 2019 - ~2500+. These are US figures.[Attachment no longer available]
Totally Zenned
dbltoe:
Don't read into any info about upgrade without optimism as your glasses. So many things are improved. Many are involved. Nearly decades old bugs are being "found" because more are invited to contribute. Heck, they even let me help here and there.:P
I understand. It seems as though many 156c questions that are not in the bugs forum are answered by 'go get this file from 157' That's a good thing
dbltoe:
But, it's more about what the owner thinks they need than what they really need. "Gotta have purdy!" "Need geo tags!" Really? So the person can stop buying on line at 2 AM and wait until tomorrow to drive to your store?
We gave up on the really purdy stuff a few years ago... outside of color changes... we don't do BLUE around here and BLUE seems to be the majority favorite.
dbltoe:
But here's just one small part of 1.5.7. Accessibility. Doesn't mean you get more workspace on your desk. It's standards the W3C have set forth worldwide to make it better for everyone to shop. There's a couple of Chrome extensions (Web Developer and Lighthouse) that can make a store owner stop the craziness of thinking the SEs like big, fancy colors and graphics which the SEs will NEVER be able to see. We've been playing with responsive_classic as there still needs to be something for the little guy to use until they can find something "better". And, believe me, I use the term facetiously!.
https://tinyurl.com/yb5b3p36 is a test site for 1.5.7 with no mods and all demo products added. It has all sideboxes and visible settings turned on.
Using Web Developer, the site has no CSS errors except for those in the font-awesome.css that we can't control. And, there's only one HTML warning still to be addressed. Web Developer's Accessibility test gives us no errors (well, occasionally one when the bannerSix doesn't have an alt tag) and, importantly, no contrast errors. The Alerts are really a feature for the responsiv_classic template in that they result from Zen Cart "covering" the page with your product's name. It's Zen Cart's version of, "That number to call, again, is.."
Using Lighthouse, we get a score of 99, 100, 100, 100. Again, the 99 is due to external issues (jQuery and the aforementioned font-awesome.css). We could bring them in house but, you'd have to update once a week. Now, THAT is scary. I've attached an image of the score. Can't say we've given that a thought/consideration
dbltoe:
SO.... After all this, what in the world does it have to do with DPU? Actually, a lot. When you add a special/discount, the price is shown with any changes on the product's page and any other page that contains a listing for the product. The original price is lined out and the new price is in red (good old #FF0000). Nearly 10% of the world's population might never see the price. They cannot see red. So, if you look at the Specials Page, you may think the color is a little off but, its setting means the entire world has a better chance of seeing it. Google Web Accessibility Lawsuits. 2017 - #814. 2018 - #2285. 2019 - ~2500+. These are US figures.
Specials/discounted price display is not a big thing for us, nor is the color. With over 1000 attribute combinations possible on a single product sold in fractional units, with some attributes affecting pricing also in fractional units, it is easier for a customer to see what they are getting ready to add to cart instead of being required to add to cart in order to see the price.
The part that scares me is when I read portions of a current plugin is now part of core.... AND what happens to the portion of the plugin that is not core? For a user who might not read everything before they start. That's one thing I have learned over the past 10 years... people dont read... myself included at times. But at least I can say that I make an effort to read. Might not be able to comprehend what I am reading well enough to implement things or attempt to implement and cause myself a few days of headache. But I did read.
I avoid customizations like the plague except as last resort. That is a guarantee for disaster in future upgrades. I avoid code that has some people's name attached except as last resort too. That, I have learned over the last 10 years also.
I do appreciate the time you have taken which has made me take the time to think things through a bit more thoroughly.
Totally Zenned
RixStix:
The part that scares me is when I read portions of a current plugin is now part of core.... AND what happens to the portion of the plugin that is not core? For a user who might not read everything before they start. That's one thing I have learned over the past 10 years... people dont read... myself included at times. But at least I can say that I make an effort to read. Might not be able to comprehend what I am reading well enough to implement things or attempt to implement and cause myself a few days of headache. But I did read.Two good points.
Again, think of the mod as having certain elements that may well have been moved into the core in 155 or especially 156. It may just be that new functionality in some other area of pricing eliminates the need for all of DPU to be ported over.
Reading!?! You think people need to read!?!. I like the ones that read the posting tips reminder juuuussssst enough to know to remove that portion before posting. No current version, no mods, no link, etc, etc, etc.:frusty:
Your site does very well on Accessibility. The only item that is not already fixed in 1.5.7's non-css area is the contrast of your site. It's also one of the reasons we're revamping the Color Change mod for 1.5.7. In your case, color-second is the problem (probably copied from our mod -- or so I read:P) The hex is too harsh if the browser doesn't use the rgba. Compatibility is driving us to lighter hex and more opaque rgba colors to keep from "blasting" folks out.
And, so many are finding that the opacity really go off the charts if two or more are on top of each other. A quick example is to go to your site and F12 or right-click to inspect. Navigate to the @navManWrapper and turn off both the hex and rgba. Watch your Categories header as you turn either one back on. Notice how it can be three different colors depending upon where the opacity is entered.
Anyway, enough of the hijacking. Keep those positive thoughts going and you won't be #0000FF:D
Totally Zenned
zc 157
vanilla install
drop db tables
import 156c db tables from live site
clone responsive classic template
OPC plugin installed
DPU doesn't play nice. Product screens just flash and flash and flash
Is this an example of plugin not ready for primetime 157, an ID10t error on my part or something else?
https://srevaewniahc (A DOT GOES HERE) info/index.php?main_page=product_info&cPath=1_7&products_id=9
Fields marked required must be completed.
Tell staff why this post should be reviewed.
Required for login, security, and core site functionality.
Help us understand how the site is used so we can improve it.
Used for promotion and personalized campaign measurement.