Zen Cart Logo
Forums / General Questions / Please Review My Website

Please Review My Website

Locked

Views: 1,209

Results 1 to 14 of 14
This thread is locked. New replies are disabled.
17 Jul 2007, 6:40 PM
#1
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Please Review My Website

Hi. I have recently uploaded my first e-commerce website. I have had a lot of help and advice from certain members. AJEH, MISTY, KUROI and especially CONOR. Thankyou all. The website is far from finished, and what I am looking for is good honest opinions of what people think of the site so far and what I can do to improve it.

You can view my site at www.bodykitsonline.co.uk/shop

Ben

17 Jul 2007, 8:14 PM
#2
kuroi avatar

kuroi

Totally Zenned

Join Date:
Apr 2006
Location:
London, UK
Posts:
10,475
Plugin Contributions:
11

Re: Please Review My Website

Ben

Sorry, but the site has some major, major problems in Firefox. The cause seems to be the way in which you have inserted some javascript. This has led to two HTML comments being opened, with only one closure.

Internet Explorer just ignores the mismatch and does a good job of rendering the page. FF takes what you've told it more literally and doesn't stop the comment when it hits the first comment terminator. As a result a big chunk of very important structural HTML (including the layout table becomes ineffective).

18 Jul 2007, 8:56 AM
#3
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Re: Please Review My Website

Oh Know:(..... I dont have Firefox and dont know anyone with it, so it never got checked, Do you have any idea what the Javascript was thats been added, so I can get rid of it.

Thanks

18 Jul 2007, 9:06 AM
#4
kuroi avatar

kuroi

Totally Zenned

Join Date:
Apr 2006
Location:
London, UK
Posts:
10,475
Plugin Contributions:
11

Re: Please Review My Website

You only have one block of javascript being added, and the problem isn't with the javascript itself, but with the comment tags being used to add it. Unfortunately, I can't tell from this end where or how it's being added, but at the end of your common/tpl_header.php seems the best candidate.

18 Jul 2007, 9:33 AM
#5
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Re: Please Review My Website

I know what it is then. I tried putting a right click disable code in a while ago, and nothing happened so I left it. I have just tried to delete the code that I wrote in, but when I refresh my site in IE the main layout of the site is ok but all of the written content drops below. Any Idea why it is doing it.

Thanks

P.S I put the code back in again just so that the site looks ok in IE

18 Jul 2007, 9:39 AM
#6
kuroi avatar

kuroi

Totally Zenned

Join Date:
Apr 2006
Location:
London, UK
Posts:
10,475
Plugin Contributions:
11

Re: Please Review My Website

Unfortunately, I can't comment on this without seeing the problem.

18 Jul 2007, 9:41 AM
#7
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Re: Please Review My Website

I thought you may say that. I have just deleted the code so if you view www.bodykitsonline.co.uk/shop in IE you should see the problem

Thanks

18 Jul 2007, 9:47 AM
#8
kuroi avatar

kuroi

Totally Zenned

Join Date:
Apr 2006
Location:
London, UK
Posts:
10,475
Plugin Contributions:
11

Re: Please Review My Website

You can put it back. I've seen what I needed to ...

18 Jul 2007, 9:50 AM
#9
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Re: Please Review My Website

Ok, Code is back in place.

18 Jul 2007, 9:57 AM
#10
kuroi avatar

kuroi

Totally Zenned

Join Date:
Apr 2006
Location:
London, UK
Posts:
10,475
Plugin Contributions:
11

Re: Please Review My Website

The problem is that even after you'd taken the javascript out, there was still a spurious HTML comment tag (marked in red below that caused the code that I have included below to be ignored, and unfortunately this is the code that determines your page's structure.> <!--

<table width="100%" border="0" cellspacing="0" cellpadding="0" id="contentMainWrapper"> <tr> <td id="navColumnOne" class="columnLeft" style="width: 150px"> <div id="navColumnOneWrapper" style="width: 150px"><!--// bof: categories //-->You need to track down and eliminate this tag. My guess is that it's in your tpl_header.php file and is also the reason why your right click disablement (which is actually a bad idea nayway) didn't work.
18 Jul 2007, 10:00 AM
#11
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Re: Please Review My Website

Thankyou. I will track it down, and will let you know how I get on.

Cheers
Ben

18 Jul 2007, 10:44 AM
#12
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Re: Please Review My Website

I think I have found that bit of code, as Right click disable is now working, which I know is a bad thing to have, and pointless as stated many times in the forum, But it is purely there just until i can get all the images water marked.

Any way back onto to the problem, can you check to see if Fire Fox is showing the site ok.

Many Thanks

Ben

18 Jul 2007, 10:47 AM
#13
kuroi avatar

kuroi

Totally Zenned

Join Date:
Apr 2006
Location:
London, UK
Posts:
10,475
Plugin Contributions:
11

Re: Please Review My Website

Working in Firefox. Would recommend that you install it yourself however, as it's free and great.

18 Jul 2007, 10:55 AM
#14
ben_harry avatar

ben_harry

Zen Follower

Join Date:
Mar 2007
Location:
Cornwall - uk
Posts:
462
Plugin Contributions:
0

Re: Please Review My Website

Brilliant, thankyou once again Kuroi.

I will try and download Fire Fox I have heard some where that its better than IE but I dont know what the reason was, In my case its probably worth having purely to double check that my site is functioning properly.

Cheers