If this is your first visit, check our documentation. To post, register or login.
Forums / Upgrading from 1.2 to 1.3.x / Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Locked

Started by laage on 5 Aug 2007, 2:44 PM · Views: 2,267

Results 1 to 8 of 8
This thread is locked. New replies are disabled.
5 Aug 2007, 2:44 PM
#1
laage avatar

laage

New Zenner

Join Date:
Jan 2006
Posts:
6
Plugin Contributions:
0

Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Hi, I'm upgrading a shop from 1.2.4 to 1.3.7, and I think I've got most of the snags worked out, however there are two problems I've not been able to fix right away.

The login-page doesn't parse the constants/defines in the template. Ie. instead of the text: "Returning Customers: Please Log In" i just get "HEADING_RETURNING_CUSTOMER" and so on for all the defines. I've got both english and swedish language files installed and both have the same error. On a related note (I assume) I'm unable to log-in as a customer in the shop, when I try to log in I'm just returned to the same page again - but as I said I'm assuming it's related.

the next problem is in the reviews section, when I try to read a product review I get the following error: "Warning: sprintf() [function.sprintf]: Too few arguments in [MY_SITE]/includes/templates/template_default/templates/tpl_product_reviews_info_default.php on line 51"

Line 51 contains the following:
"<h3 class="rating"><?php echo zen_image(DIR_WS_TEMPLATE_IMAGES . 'stars_' . $review_info->fields['reviews_rating'] . '.gif', sprintf(TEXT_OF_5_STARS, $review_info->fields['reviews_rating'])), sprintf(TEXT_OF_5_STARS, $review_info->fields['reviews_rating']); ?></h3>"

From this thread:
http://www.zen-cart.com/forum/showthread.php?t=39706

I understand that the problem is probably somewhere in the language files, but I'm unsure which file I need to edit, and what I need to change in order to get this to work properly.
I've only got reviews in Swedish, and as I'm unable to log-in (see above) I can't add an english review for comparison.


Laage


Laage

5 Aug 2007, 4:50 PM
#2
brandtim avatar

brandtim

Zen Follower

Join Date:
Apr 2006
Posts:
250
Plugin Contributions:
0

Re: Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

I ran into a similar problem as the one you describe on the login page on a site with multiple developers ... when the language file had been repeatedly opened and closed on different platforms, the line endings got changed. Try changing the line endings in both login.php language files to CR+LF.

BrandTim

5 Aug 2007, 9:18 PM
#3
laage avatar

laage

New Zenner

Join Date:
Jan 2006
Posts:
6
Plugin Contributions:
0

Re: Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Hi, thanks for the suggestion.

I looked at both files (swedish and english login.php) and as I suspected they were both CR+LF Windows formatted (I'm the only "dev" on this site).
I tried changing both files to LF only, reuploaded and refreshed - No change and then changed both files back to CR+LF, reuploaded and refreshed a couple of times, with no change in result.
It still doesn't parse the defines.


Laage

6 Aug 2007, 9:39 PM
#4
brandtim avatar

brandtim

Zen Follower

Join Date:
Apr 2006
Posts:
250
Plugin Contributions:
0

Re: Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Ok, I'm out of guesses. :blink:

Could you provide a link so I can look at the HTML source for that page?

BrandTim

6 Aug 2007, 11:12 PM
#5
laage avatar

laage

New Zenner

Join Date:
Jan 2006
Posts:
6
Plugin Contributions:
0

Re: Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Here's a link to the login-page:
http://www.by-laage.com/zc137/index.php?main_page=login

I took it off maintenance mode so you'd be able to look at it.

thx for your time.


Laage

7 Aug 2007, 1:14 AM
#6
brandtim avatar

brandtim

Zen Follower

Join Date:
Apr 2006
Posts:
250
Plugin Contributions:
0

Re: Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Hmmm. Ok, next guess. Try re-uploading your includes/modules/pages/login/header_php.php file.

If that doesn't fix it, add this as the first line of your includes/languages/english/classic/login.php file:

<?php die('I loaded includes/languages/english/classic/login.php!'); ?>

We'll see what those do and go from there.

BrandTim

7 Aug 2007, 8:01 AM
#7
laage avatar

laage

New Zenner

Join Date:
Jan 2006
Posts:
6
Plugin Contributions:
0

Re: Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Found it, thank you...

It's always the smallest thing isn't it, though?

Seems like the ftp upload somehow choked on the includes/modules/pages/login/header_php.php file, because when I went to reset it to CR+LF the file on the server was 0b in size!

Uploaded a shiny new version from the zip-file and everything worked... well, at least logging in worked :)

Thx for you time again.


Laage

8 Aug 2007, 10:17 PM
#8
brandtim avatar

brandtim

Zen Follower

Join Date:
Apr 2006
Posts:
250
Plugin Contributions:
0

Re: Two (possibly three) problems in upgrading 1.2.4 to 1.3.7,

Glad you got it worked out. :smile:

BrandTim