[Done v1.3.8] PAYMENT_METHOD_FOOTER isn't working in html emails.

12 Nov 2007, 7:41 AM

New Zenner

Join Date:: Nov 2007
Posts:: 1
Plugin Contributions:: 0

[Done v1.3.8] PAYMENT_METHOD_FOOTER isn't working in html emails.

I don't think the code $PAYMENT_METHOD_FOOTER in HTML emails is working in version 1.3.7. Line 956 of includes/classes/order.php is...

$html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']] && $GLOBALS[$payment_class]->email_footer != '') ? $GLOBALS[$payment_class]->email_footer : $this->info['cc_type'] );

I believe that the ) just before the ? should actually be before the && as it's currently testing if

$GLOBALS[$_SESSION['payment']] && $GLOBALS[$payment_class]->email_footer != ''

is an object rather than just

$GLOBALS[$_SESSION['payment']]

12 Nov 2007, 7:49 AM

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,515
Plugin Contributions:: 176

Re: [Done v1.3.8] PAYMENT_METHOD_FOOTER isn't working in html emails.

Yes, there was a bug with misplaced parenthesis, etc ... discussed here, along with solution:
http://www.zen-cart.com/forum/showthread.php?t=54819

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.