Forums / Bug Reports / [Not a bug] Missing ?> in advanced_search_result/header_php.php

[Not a bug] Missing ?> in advanced_search_result/header_php.php

Locked

Results 1 to 3 of 3

This thread is locked. New replies are disabled.

5 Dec 2007, 12:22 PM

pasi

Zen Follower

Join Date:: Mar 2004
Location:: Finland
Posts:: 435
Plugin Contributions:: 1

[Not a bug] Missing ?> in advanced_search_result/header_php.php

In file: includes/modules/pages/advanced_search_result/header_php.php

The ending ?> seems to be missing in 1.3.8

With a diff viewer the last line has changed from ?> to //EOF

I'm in the process of updating my shop so I can't confirm if it actually breaks anything(?)

5 Dec 2007, 1:05 PM

cjpinder

Totally Zenned

Join Date:: Apr 2007
Location:: Herts. UK
Posts:: 893
Plugin Contributions:: 0

Re: [Not a bug] Missing ?> in advanced_search_result/header_php.php

Hi,

PHP doesn't require the closing tag, it is assumed when the end of the file is reached. Leaving them out helps prevent accidents, like additional whitespace after the closing tag, which cause errors (headers already sent message).

More information can be found here...
http://uk.php.net/basic-syntax.instruction-separation

Regards,
Christian.

5 Dec 2007, 3:28 PM

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,513
Plugin Contributions:: 177

Re: [Not a bug] Missing ?> in advanced_search_result/header_php.php

Christian is correct. And this will be an increasing practice in future versions of Zen Cart.

An FAQ has been added for future reference:
https://www.zen-cart.com/tutorials/index.php?article=313