Drop Shipping Purchase Orders Module for v1.3.8

Danielle:

I assumed version 3.22 would be newer than what is on github since it was just uploaded on October 26. I will look at the github files too.

I just realized I completely entered the wrong version number, I am using version 1.5.4 of Zen-Cart, not 1.5.1. The server is using PHP 5.6, so I'm assuming that is causing the problem? I manually checked and all the tables are there. I am not sure what to do to make this work? I have upgraded this entire site to 1.5.4 and it's ready to go except for this module, which is an absolute requirement for my client.

I am happy to play around with it and try and get it working, I'm just not sure where to start?

I do see that it's not compatible with 1.5.2+. I am hoping to find a way to get it working. I did try rolling the PHP version on the server back to PHP 5.4, but the database errors are still there.

I almost have this working with 1.5.4 on PHP 5.6. Everything connects and the data shows up, but I'm getting these log errors:

[16-Nov-2015 12:32:43 America/New_York] PHP Fatal error: Call to undefined function pasek() in /home1/***/public_html/new/shopadmin/set_subcontrac.php on line 254

[16-Nov-2015 12:30:28 America/New_York] PHP Fatal error: Call to undefined function pasek() in /home1/***/public_html/new/shopadmin/send_pos.php on line 937

Danielle:

I assumed version 3.22 would be newer than what is on github since it was just uploaded on October 26. I will look at the github files too.

I just realized I completely entered the wrong version number, I am using version 1.5.4 of Zen-Cart, not 1.5.1. The server is using PHP 5.6, so I'm assuming that is causing the problem? I manually checked and all the tables are there. I am not sure what to do to make this work? I have upgraded this entire site to 1.5.4 and it's ready to go except for this module, which is an absolute requirement for my client.

I am happy to play around with it and try and get it working, I'm just not sure where to start?

Danielle:

I almost have this working with 1.5.4 on PHP 5.6. Everything connects and the data shows up, but I'm getting these log errors:

[16-Nov-2015 12:32:43 America/New_York] PHP Fatal error: Call to undefined function pasek() in /home1/***/public_html/new/shopadmin/set_subcontrac.php on line 254

[16-Nov-2015 12:30:28 America/New_York] PHP Fatal error: Call to undefined function pasek() in /home1/***/public_html/new/shopadmin/send_pos.php on line 937

From github set, should be in: YOUR_ADMIN/includes/functions/extra_functions/purchaseorders.php

Btw, might want to consider changing the admin folder name for that site.

Danielle:

I assumed version 3.22 would be newer than what is on github since it was just uploaded on October 26. I will look at the github files too.

I just realized I completely entered the wrong version number, I am using version 1.5.4 of Zen-Cart, not 1.5.1. The server is using PHP 5.6, so I'm assuming that is causing the problem? I manually checked and all the tables are there. I am not sure what to do to make this work? I have upgraded this entire site to 1.5.4 and it's ready to go except for this module, which is an absolute requirement for my client.

I am happy to play around with it and try and get it working, I'm just not sure where to start?

In the lat few pages of this support thread, you will see that the person who uploaded the version in the Zen Cart downloads hadn't seen the Github version which IS more up to date than what's in the Zen Cart downloads..

That said this module still needs LOTS of work which is why I've never advanced what's in Github beyond the work I've already done.. The changes needed are WAY over my paygrade to execute, and this this REALLY needs to be integrated with Drop Ship Core to be a REALLY effective and useful module IMHO..

Diva, I'm probably going to fix these issues - should I start with the version in Github or the one in the plugins?

swguy:

Diva, I'm probably going to fix these issues - should I start with the version in Github or the one in the plugins?That would be AWESOME!!!:clap:

My Github version as I got rid of some of the odd Polish functions, classes and such.... Will you be attempting to integrate it with Drop Ship Core?? You KNOW I'm not one to do "feature" requests, but integrating these two would make this something SUPER useful.. :blush: Would be happy to explain why I think this is so offline if you wanna shoot me an email..

I doubt that but let's see. Let me start with straightening out what's there now.

swguy:

I doubt that but let's see. Let me start with straightening out what's there now.

I hope you will reconsider.. :smile: Integration with Dropship Core (or adding the same features that are in Dropship Core) would turn this module into a fully functioning dropship module.. I explained this briefly a few pages back

DivaVocals:

May I make a feature suggestion?? it's a VERY simple one.. I know this since it's one that even I was able to execute.. :laugh:

*Can your re-write adopt the subcontractors table structure used in the DropShip Core module.. http://www.zen-cart.com/downloads.php?do=file&id=1536

Like my client, others may want to connect the Dropship PDF module with Dropship Core, and making this module use the same table name/structure as the sub contractors in Dropship Core means that shopowners will NOT have to enter their subcontractors data twice..*

I should have a PR by later this week. Got a bunch of this taken care of this morning.

Why is there now a subcontractors_shipping table when there used to be a subcontactors table?
Why did you get rid of edit_subcontrac.php?

swguy:

Why is there now a subcontractors_shipping table when there used to be a subcontactors table?
Why did you get rid of edit_subcontrac.php?

All done so that this module integrated with DropShip Core.

See: https://github.com/DivaVocals/zen_DropShipPO/commit/0ef886d035e6bf188fa6982adb397debb23af699

I see what you're thinking - but right now the module is broken for people who don't install DropShip Core, which is an abandoned mod that hasn't been updated in years. We can keep your idea of integrating the tables but we need these management tools.

swguy:

I see what you're thinking - but right now the module is broken for people who don't install DropShip Core, which is an abandoned mod that hasn't been updated in years. We can keep your idea of integrating the tables but we need these management tools.I get this module is broken, but even fixed I found out very quickly that for clients who's business really depends on having more than just "minor down and dirty" drop shipping features, this module's featureset is very LIMITED (which is why I integrated it with Dropship Core to begin with). The features it's missing are the ones in Dropship Core, and it was pretty EASY to merge the two (since even I with my minor dev skills was able to manage the merge:laugh:) My plan was to make these two modules ONE module..

FYI.. Dropship Core is no more out of date than this module.. (IJS :smile:)

I got rid of the old mysql* stuff, and my changes seem to be working with 1.5.5. But there were a MILLION frickin' changes and so I'm anxious for someone to put a second set of eyes on it to find what I missed. I'll submit a PR after my client does some more testing.

OK the PR is submitted. But shouldn't confirm_track_sub.php also be in this contrib?

swguy:

I got rid of the old mysql* stuff, and my changes seem to be working with 1.5.5. But there were a MILLION frickin' changes and so I'm anxious for someone to put a second set of eyes on it to find what I missed. I'll submit a PR after my client does some more testing.
I have tested your database query changes in 1.5.5 and they are fine. There was a wrong field and a typo in the set_subcontrac.php so changing the subcontractor for a product was not saved.
I have seen that the pdf packinglist functionality was removed, not sure why as it is working fine.
I have changed from fpdf to tfpdf to enable the needed utf-8 support, so special characters and umlauts in product names, customer addresses and customer comments are now correct in the pdf.
I did some other minor changes, everything available here:
https://github.com/webchills/zen_DropShipPO/tree/154-155-compatibility
This is a great module, I'm sure that we can iron out the last bugs together.

Thanks for your help - this is good news. I just pulled in your set_subcontrac.php fixes.
Can you let me know where the pdf packinglist stuff was?

Most of the pdf stuff was commented out in Divas GitHub. I took it back from the old version in the ZC Downloads Section. But it was useless anyway as the used fpdf does not support utf-8. I have replaced it completely with tfpdf and the pdf packinglist is working fine. What I haven't tested yet is the Ty Package Tracker integration, the confirm_track files do need some work too for sure.

webchills:

Most of the pdf stuff was commented out in Divas GitHub. I took it back from the old version in the ZC Downloads Section. But it was useless anyway as the used fpdf does not support utf-8. I have replaced it completely with tfpdf and the pdf packinglist is working fine. What I haven't tested yet is the Ty Package Tracker integration, the confirm_track files do need some work too for sure.
You can also pull the latest fpdf from the Super Orders repository. This should be utf 8 compatible.

webchills:

Most of the pdf stuff was commented out in Divas GitHub. I took it back from the old version in the ZC Downloads Section. But it was useless anyway as the used fpdf does not support utf-8. I have replaced it completely with tfpdf and the pdf packinglist is working fine. What I haven't tested yet is the Ty Package Tracker integration, the confirm_track files do need some work too for sure.

If I commented it out (and it's been a while so I don't remember) it would have been because the version of FPDF was too old..